Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint #55852

varkor · 2018-11-10T18:09:19Z

Fixes #51043.

rust-highfive · 2018-11-10T18:09:22Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

zackmdavis

Thanks!!

zackmdavis · 2018-11-10T21:08:52Z

src/test/ui/range/range-inclusive-pattern-precedence.stderr

   |
 LL |         &0...9 => {}
-   |           ^^^ help: use `..=` for an inclusive range
+   |         ^^^^^^ help: use `..=` for an inclusive range


In the case where we recommend parentheses (and only then), I think we want to use span_suggestion_with_applicability (rather than span_suggestion_short_with_applicability), because that'll print the corrected code snippet after the span message (whereas the short variant methods omit it):

LL | &0...9 => {} | ^^^^^^ help: use `..=` for an inclusive range: &(0..=9)

Ah, that's a good point.

addressed

zackmdavis · 2018-11-10T23:23:56Z

r? @zackmdavis

@bors r+

bors · 2018-11-10T23:23:57Z

📌 Commit c63df7c has been approved by zackmdavis

zackmdavis · 2018-11-10T23:24:31Z

Do we want to slip this into 1.31?

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint Fixes rust-lang#51043.

@ghost

Rollup of 17 pull requests Successful merges: - #55182 (Redox: Update to new changes) - #55211 (Add BufWriter::buffer method) - #55507 (Add link to std::mem::size_of to size_of intrinsic documentation) - #55530 (Speed up String::from_utf16) - #55556 (Use `Mmap` to open the rmeta file.) - #55622 (NetBSD: link libstd with librt in addition to libpthread) - #55750 (Make `NodeId` and `HirLocalId` `newtype_index`) - #55778 (Wrap some query results in `Lrc`.) - #55781 (More precise spans for temps and their drops) - #55785 (Add mem::forget_unsized() for forgetting unsized values) - #55852 (Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint) - #55865 (Unix RwLock: avoid racy access to write_locked) - #55901 (fix various typos in doc comments) - #55926 (Change sidebar selector to fix compatibility with docs.rs) - #55930 (A handful of hir tweaks) - #55932 (core/char: Speed up `to_digit()` for `radix <= 10`) - #55956 (add tests for some fixed ICEs) Failed merges: r? @ghost

nagisa · 2018-11-15T15:27:46Z

Accepted for a backport to beta.

3431: rustup rust-lang/rust#55852 r=flip1995 a=matthiaskrgr Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>

Fixes clippy toolstate. Changes: ```` rustup rust-lang#55852 Fix "too" -> "foo" typo in format.rs Fix `use_self` violation Fix wrong suggestion for `redundant_closure_call` Check for common metadata Fix `use_self` false positive on `use` statements Fix `use_self` false positive Remove `+` from `has_unary_equivalent` Fix dogfood Update println! formatting Fix false positive in check mode caused by `gen_deprecated` RIIR update lints: Add check mode (update_lints.py rewrite complete) changed into_iter to iter and fixed a lint check Fix `collapsible_if` error Fix `possible_missing_comma` false positives format code fix comment spacing change single char str to char add lint to lintarray macro Revert "small fix" small fix added float support for mistyped literal lints tmp progress ````

matthiaskrgr · 2018-11-15T16:51:50Z

Note: this broke clippy on nightly so it might also break clippy on beta.

https://github.com/rust-lang-nursery/rust-clippy/pull/3431/files

submodules: update clippy from d8b4269 to 7e0ddef Fixes clippy toolstate. Changes: ```` rustup #55852 Fix "too" -> "foo" typo in format.rs Fix `use_self` violation Fix wrong suggestion for `redundant_closure_call` Check for common metadata Fix `use_self` false positive on `use` statements Fix `use_self` false positive Remove `+` from `has_unary_equivalent` Fix dogfood Update println! formatting Fix false positive in check mode caused by `gen_deprecated` RIIR update lints: Add check mode (update_lints.py rewrite complete) changed into_iter to iter and fixed a lint check Fix `collapsible_if` error Fix `possible_missing_comma` false positives format code fix comment spacing change single char str to char add lint to lintarray macro Revert "small fix" small fix added float support for mistyped literal lints tmp progress ````

@ghost

[beta] Rollup backports Merged and approved: * #55947: xLTO: Don't pass --plugin-opt=thin to LLD. That's not supported anymore. * #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint * #55800: Fix ICE in `return_type_impl_trait` * #55630: resolve: Filter away macro prelude in modules with `#[no_implicit_prelude]` on 2018 edition r? @ghost

pietroalbini · 2018-11-15T22:50:32Z

Clippy needs to be updated on the beta branch to cherry-pick rust-lang/rust-clippy#3431 if you want to backport this to beta.

@nrc

beta backport rollup Backports of some beta-approved PRs - [x] #55385: NLL: cast causes failure to promote to static - [x] #56043: remove "approx env bounds" if we already know from trait - [x] #56003: do not propagate inferred bounds on trait objects if they involve `Self` - [x] #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint - [x] #55804: rustdoc: don't inline `pub use some_crate` unless directly asked to - [x] #56059: Increase `Duration` approximate equal threshold to 1us - [x] Keep resolved defs in path prefixes and emit them in save-analysis #54145 - [x] Adjust Ids of path segments in visibility modifiers #55487 - [x] save-analysis: bug fix and optimisation. #55521 - [x] save-analysis: be even more aggressive about ignorning macro-generated defs #55936 - [x] save-analysis: fallback to using path id #56060 - [x] save-analysis: Don't panic for macro-generated use globs #55879 - [x] Add temporary renames to manifests for rustfmt/clippy #56081 - [x] Revert #51601 #56049 - [x] Fix stability hole with `static _` #55983 - [x] #56077 - [x] Fix Rustdoc ICE when checking blanket impls #55258 - [x] Updated RELEASES.md for 1.31.0 #55678 - [x] ~~#56061~~ #56111 - [x] Stabilize `extern_crate_item_prelude` #56032 Still running tests locally, and I plan to backport @nrc's other PRs too (cc @petrochenkov -- thanks for the advice)

Fixes clippy toolstate. Changes: ```` rustup rust-lang/rust#55852 Fix "too" -> "foo" typo in format.rs Fix `use_self` violation Fix wrong suggestion for `redundant_closure_call` Check for common metadata Fix `use_self` false positive on `use` statements Fix `use_self` false positive Remove `+` from `has_unary_equivalent` Fix dogfood Update println! formatting Fix false positive in check mode caused by `gen_deprecated` RIIR update lints: Add check mode (update_lints.py rewrite complete) changed into_iter to iter and fixed a lint check Fix `collapsible_if` error Fix `possible_missing_comma` false positives format code fix comment spacing change single char str to char add lint to lintarray macro Revert "small fix" small fix added float support for mistyped literal lints tmp progress ````

rust-highfive assigned cramertj Nov 10, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 10, 2018

varkor changed the title ~~Rewrite ... as ..= as a MachineApplicable 2018 idiom lint~~ Rewrite ... as ..= as a MachineApplicable 2018 idiom lint Nov 10, 2018

This comment has been minimized.

Sign in to view

Rewrite ... as ..= as a MachineApplicable 2018 idiom lint

c148714

varkor force-pushed the dotdotequals-lint branch from 420689f to c148714 Compare November 10, 2018 19:27

zackmdavis previously requested changes Nov 10, 2018

View reviewed changes

Use non-short suggestion for parenthesised ..=

c63df7c

rust-highfive assigned zackmdavis and unassigned cramertj Nov 10, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2018

zackmdavis added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 10, 2018

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 12, 2018

Rollup merge of rust-lang#55852 - varkor:dotdotequals-lint, r=zackmdavis

70d6c53

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint Fixes rust-lang#51043.

pietroalbini mentioned this pull request Nov 12, 2018

Rollup of 19 pull requests #55902

Closed

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 15, 2018

Rollup merge of rust-lang#55852 - varkor:dotdotequals-lint, r=zackmdavis

3c7acc7

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint Fixes rust-lang#51043.

pietroalbini mentioned this pull request Nov 15, 2018

Rollup of 17 pull requests #55974

Merged

nagisa added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 15, 2018

bors merged commit c63df7c into rust-lang:master Nov 15, 2018

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Nov 15, 2018

rustup rust-lang/rust#55852

2d0d41f

bors bot added a commit to rust-lang/rust-clippy that referenced this pull request Nov 15, 2018

Merge #3431

f5d868c

3431: rustup rust-lang/rust#55852 r=flip1995 a=matthiaskrgr Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>

pietroalbini mentioned this pull request Nov 15, 2018

[beta] Rollup backports #55989

Merged

pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2018

pietroalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2018

SimonSapin mentioned this pull request Nov 19, 2018

Use Mmap to open the rmeta file. #55556

Merged

pietroalbini mentioned this pull request Nov 19, 2018

[beta] Rollup backports #56077

Closed

alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 19, 2018

alexcrichton added this to the Rust 2018 Release milestone Nov 19, 2018

nikomatsakis mentioned this pull request Nov 20, 2018

beta backport rollup #56102

Merged

20 tasks

alexcrichton pushed a commit to rust-lang/rust-clippy that referenced this pull request Nov 20, 2018

rustup rust-lang/rust#55852

246a77e

varkor deleted the dotdotequals-lint branch April 17, 2019 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint #55852

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint #55852

varkor commented Nov 10, 2018

rust-highfive commented Nov 10, 2018

This comment has been minimized.

zackmdavis left a comment

zackmdavis Nov 10, 2018

varkor Nov 10, 2018

zackmdavis commented Nov 10, 2018

bors commented Nov 10, 2018

zackmdavis commented Nov 10, 2018

nagisa commented Nov 15, 2018

matthiaskrgr commented Nov 15, 2018

pietroalbini commented Nov 15, 2018

Rewrite ... as ..= as a MachineApplicable 2018 idiom lint #55852

Rewrite ... as ..= as a MachineApplicable 2018 idiom lint #55852

Conversation

varkor commented Nov 10, 2018

rust-highfive commented Nov 10, 2018

This comment has been minimized.

zackmdavis left a comment

Choose a reason for hiding this comment

zackmdavis Nov 10, 2018

Choose a reason for hiding this comment

varkor Nov 10, 2018

Choose a reason for hiding this comment

zackmdavis commented Nov 10, 2018

bors commented Nov 10, 2018

zackmdavis commented Nov 10, 2018

nagisa commented Nov 15, 2018

matthiaskrgr commented Nov 15, 2018

pietroalbini commented Nov 15, 2018

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint #55852

Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint #55852