-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize extern_crate_item_prelude
#56032
Conversation
r? @Centril |
Stabilization reportFeature name: Implemented in #54658 and landed 23 days ago. Why it's desirable to stabilize for the edition releaseThe feature provides the same usage model for "normal" crates (passed with As a result this code "just works" on 2018 edition: extern crate proc_macro;
use proc_macro::TokenStream; If this is not stabilized for the edition release, nothing too terrible happens, but users of the aforementioned crates will have to use them like something from the local crate for some time (e.g. until the next release). extern crate proc_macro;
use crate::proc_macro::TokenStream; What is being stabilizedIf item If the name extern crate foo;
mod m {
use foo; // OK
use ::foo; // OK
let x = foo::bar; // OK
let x = ::foo::bar; // OK
} Some details and corner casesIf mod inner {
pub(crate) extern crate foo;
}
use inner::foo; If Macro expanded Interactions of the feature with unstable macros 2.0 |
I propose that we stabilize @rfcbot merge |
Team member @Centril has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed. Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
☔ The latest upstream changes (presumably #56042) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors: p=1 beta nominated |
(I checked @pnkfelix as they are on PTO) |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
e3f8134
to
d4934c7
Compare
@bors r=nikomatsakis |
📌 Commit d4934c7 has been approved by |
beta backport rollup Backports of some beta-approved PRs - [x] #55385: NLL: cast causes failure to promote to static - [x] #56043: remove "approx env bounds" if we already know from trait - [x] #56003: do not propagate inferred bounds on trait objects if they involve `Self` - [x] #55852: Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint - [x] #55804: rustdoc: don't inline `pub use some_crate` unless directly asked to - [x] #56059: Increase `Duration` approximate equal threshold to 1us - [x] Keep resolved defs in path prefixes and emit them in save-analysis #54145 - [x] Adjust Ids of path segments in visibility modifiers #55487 - [x] save-analysis: bug fix and optimisation. #55521 - [x] save-analysis: be even more aggressive about ignorning macro-generated defs #55936 - [x] save-analysis: fallback to using path id #56060 - [x] save-analysis: Don't panic for macro-generated use globs #55879 - [x] Add temporary renames to manifests for rustfmt/clippy #56081 - [x] Revert #51601 #56049 - [x] Fix stability hole with `static _` #55983 - [x] #56077 - [x] Fix Rustdoc ICE when checking blanket impls #55258 - [x] Updated RELEASES.md for 1.31.0 #55678 - [x] ~~#56061~~ #56111 - [x] Stabilize `extern_crate_item_prelude` #56032 Still running tests locally, and I plan to backport @nrc's other PRs too (cc @petrochenkov -- thanks for the advice)
Stabilize `extern_crate_item_prelude` Closes #55599
☀️ Test successful - status-appveyor, status-travis |
Closes #55599