New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_c_str should call the AllocationExtra hooks #56210

Merged
merged 4 commits into from Nov 25, 2018

Conversation

Projects
None yet
4 participants
@RalfJung
Member

RalfJung commented Nov 25, 2018

I just hope we do not have other methods that bypass get_bytes/get_bytes_mut... (looking over the file, I could not find any)

r? @oli-obk

@oli-obk

This comment has been minimized.

Contributor

oli-obk commented Nov 25, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 25, 2018

📌 Commit 0fac350 has been approved by oli-obk

@RalfJung

This comment has been minimized.

Member

RalfJung commented Nov 25, 2018

@oli-obk found a bug and fixed it, could you review the latest commit as well?

Show resolved Hide resolved src/librustc/mir/interpret/allocation.rs Outdated
Typo
Co-Authored-By: RalfJung <post@ralfj.de>
@oli-obk

This comment has been minimized.

Contributor

oli-obk commented Nov 25, 2018

@bors r+

@bors

This comment has been minimized.

Contributor

bors commented Nov 25, 2018

📌 Commit 2472e83 has been approved by oli-obk

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 25, 2018

Rollup merge of rust-lang#56210 - RalfJung:c_str, r=oli-obk
read_c_str should call the AllocationExtra hooks

I just hope we do not have other methods that bypass `get_bytes`/`get_bytes_mut`... (looking over the file, I could not find any)

r? @oli-obk

bors added a commit that referenced this pull request Nov 25, 2018

Auto merge of #56215 - pietroalbini:rollup, r=pietroalbini
Rollup of 14 pull requests

Successful merges:

 - #56024 (Don't auto-inline const functions)
 - #56045 (Check arg/ret sizedness at ExprKind::Path)
 - #56072 (Stabilize macro_literal_matcher)
 - #56075 (Encode a custom "producers" section in wasm files)
 - #56100 (generator fields are not necessarily initialized)
 - #56101 (Incorporate `dyn` into more comments and docs.)
 - #56144 (Fix BTreeSet and BTreeMap gdb pretty-printers)
 - #56151 (Move a flaky process test out of libstd)
 - #56170 (Fix self profiler ICE on Windows)
 - #56176 (Panic setup msg)
 - #56204 (Suggest correct enum variant on typo)
 - #56207 (Stabilize the int_to_from_bytes feature)
 - #56210 (read_c_str should call the AllocationExtra hooks)
 - #56211 ([master] Forward-ports from beta)

Failed merges:

r? @ghost

@bors bors merged commit 2472e83 into rust-lang:master Nov 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RalfJung RalfJung deleted the RalfJung:c_str branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment