panic when calling MaybeUninhabited::into_inner on uninhabited type #57145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Dec 27, 2018
|
So... I am confident that the impl does what it promises. I just don't know if I can single handedly sign off on this. I think it would be enough for @rust-lang/libs to sign off on this, although it kind of touches language and compiler. |
oli-obk
added
I-nominated
T-libs-api
|
@bors: try |
|
⌛ Trying commit c118b17 with merge c8bd38c4de0d52227df9d7c04afd10f3080e9a6a... |
|
Er sorry, just now realizing that the implementation already does this, we're just adding something else under that umbrella. Sounds good to me! @bors: r+ |
|
📌 Commit c118b17 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jan 3, 2019
…excrichton panic when calling MaybeUninhabited::into_inner on uninhabited type I do this by adding an internal-only intrinsic `panic_if_uninhabited`. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!
bors
added a commit
that referenced
this pull request
Jan 5, 2019
panic when calling MaybeUninhabited::into_inner on uninhabited type I do this by adding an internal-only intrinsic `panic_if_uninhabited`. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!
|
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 5, 2019
Tested on commit rust-lang/rust@8c2d0f4. Direct link to PR: <rust-lang/rust#57145> 💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb, @rust-lang/infra).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do this by adding an internal-only intrinsic
panic_if_uninhabited. I have no idea what I am doing here, just mindlessly copying code around, so please review carefully!