New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make privacy checking, intrinsic checking and liveness checking incremental #57253

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@Zoxc
Copy link
Contributor

Zoxc commented Jan 2, 2019

Blocked on #51487

r? @michaelwoerister

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 2, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

⌛️ Trying commit 31241ce with merge d9689e3...

bors added a commit that referenced this pull request Jan 2, 2019

Auto merge of #57253 - Zoxc:incr-passes2, r=<try>
[WIP] Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on #51487

r? @michaelwoerister
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 2, 2019

☀️ Test successful - status-travis
State: approved= try=True

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 2, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 2, 2019

Success: Queued d9689e3 with parent 9653034, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 2, 2019

Finished benchmarking try commit d9689e3

@Zoxc Zoxc force-pushed the Zoxc:incr-passes2 branch from 31241ce to 234715a Jan 2, 2019

bors added a commit that referenced this pull request Jan 6, 2019

Auto merge of #57293 - Zoxc:incr-passes3, r=<try>
[WIP] Make some lints incremental

Blocked on #57253

r? @michaelwoerister
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 13, 2019

☔️ The latest upstream changes (presumably #51487) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:incr-passes2 branch from 234715a to 959c870 Jan 13, 2019

@Zoxc Zoxc changed the title [WIP] Make privacy checking, intrinsic checking and liveness checking incremental Make privacy checking, intrinsic checking and liveness checking incremental Jan 14, 2019

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 14, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 14, 2019

⌛️ Trying commit 959c870 with merge 9fcae8a...

bors added a commit that referenced this pull request Jan 14, 2019

Auto merge of #57253 - Zoxc:incr-passes2, r=<try>
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on #51487

r? @michaelwoerister
@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 14, 2019

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 14, 2019

Success: Queued 9fcae8a with parent 9aee7ed, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

rust-timer commented Jan 14, 2019

Finished benchmarking try commit 9fcae8a

@michaelwoerister
Copy link
Contributor

michaelwoerister left a comment

Thanks, @Zoxc! Looks great! I left a couple of minor nits, r=me with those addressed.

Oh my, adding a query needs a lot of boilerplate ...


let krate = tcx.hir().krate();

for &module in tcx.hir().krate().modules.keys() {

This comment has been minimized.

@michaelwoerister

michaelwoerister Jan 14, 2019

Contributor

Could you re-use the krate binding here that is created the line before. Otherwise it might be confusing, i.e. one might think that's some special reason why tcx.hir().krate() is called twice here.

@@ -782,6 +782,10 @@ impl<'a, 'tcx> Visitor<'tcx> for NamePrivacyVisitor<'a, 'tcx> {
NestedVisitorMap::All(&self.tcx.hir())
}

fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
// Don't visit modules inside

This comment has been minimized.

@michaelwoerister

michaelwoerister Jan 14, 2019

Contributor

Can explain in the comment why we are not recursing down into nested modules? Something like "Don't visit nested modules, since we run a separate visitor walk for each module in privacy_access_levels()".

@@ -917,6 +921,10 @@ impl<'a, 'tcx> Visitor<'tcx> for TypePrivacyVisitor<'a, 'tcx> {
NestedVisitorMap::All(&self.tcx.hir())
}

fn visit_mod(&mut self, _m: &'tcx hir::Mod, _s: Span, _n: ast::NodeId) {
// Don't visit modules inside

This comment has been minimized.

@michaelwoerister

michaelwoerister Jan 14, 2019

Contributor

Here too, just copying the comment is fine.

@Zoxc Zoxc force-pushed the Zoxc:incr-passes2 branch from 959c870 to e301f90 Jan 14, 2019

@Zoxc

This comment has been minimized.

Copy link
Contributor

Zoxc commented Jan 15, 2019

@bors r=michaelwoerister

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 15, 2019

📌 Commit 959c870 has been approved by michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister

bors added a commit that referenced this pull request Jan 15, 2019

Auto merge of #57624 - Centril:rollup, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #57253 (Make privacy checking, intrinsic checking and liveness checking incremental)
 - #57352 (forbid manually impl'ing one of an object type's marker traits)
 - #57486 (Simplify `TokenStream` some more)
 - #57537 (Small perf improvement for fmt)
 - #57579 (Add core::iter::once_with())
 - #57587 (Add 'rustc-env:RUST_BACKTRACE=0' to const-pat-ice test)
 - #57608 (Simplify 'product' factorial example)
 - #57614 ([rustdoc] Fix crates filtering box not being filled)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019

Rollup merge of rust-lang#57253 - Zoxc:incr-passes2, r=michaelwoerister
Make privacy checking, intrinsic checking and liveness checking incremental

Blocked on rust-lang#51487

r? @michaelwoerister

bors added a commit that referenced this pull request Jan 15, 2019

Auto merge of #57627 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #57253 (Make privacy checking, intrinsic checking and liveness checking incremental)
 - #57352 (forbid manually impl'ing one of an object type's marker traits)
 - #57537 (Small perf improvement for fmt)
 - #57579 (Add core::iter::once_with())
 - #57587 (Add 'rustc-env:RUST_BACKTRACE=0' to const-pat-ice test)
 - #57608 (Simplify 'product' factorial example)
 - #57614 ([rustdoc] Fix crates filtering box not being filled)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jan 15, 2019

Auto merge of #57627 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #57253 (Make privacy checking, intrinsic checking and liveness checking incremental)
 - #57352 (forbid manually impl'ing one of an object type's marker traits)
 - #57537 (Small perf improvement for fmt)
 - #57579 (Add core::iter::once_with())
 - #57587 (Add 'rustc-env:RUST_BACKTRACE=0' to const-pat-ice test)
 - #57608 (Simplify 'product' factorial example)
 - #57614 ([rustdoc] Fix crates filtering box not being filled)

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 15, 2019

@bors r=michaelwoerister

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 15, 2019

📌 Commit e301f90 has been approved by michaelwoerister

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment