Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-do docs for core::cmp #57496

Merged
merged 1 commit into from
Jan 13, 2019
Merged

re-do docs for core::cmp #57496

merged 1 commit into from
Jan 13, 2019

Conversation

steveklabnik
Copy link
Member

Fixes #32934

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2019
@rust-highfive

This comment has been minimized.

Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for further improvement :)

src/libcore/cmp.rs Outdated Show resolved Hide resolved
src/libcore/cmp.rs Outdated Show resolved Hide resolved
src/libcore/cmp.rs Outdated Show resolved Hide resolved
src/libcore/cmp.rs Outdated Show resolved Hide resolved
src/libcore/cmp.rs Show resolved Hide resolved
src/libcore/cmp.rs Outdated Show resolved Hide resolved
src/libcore/cmp.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Jan 10, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned aidanhs Jan 10, 2019
@rust-lang rust-lang deleted a comment from rust-highfive Jan 10, 2019
src/libcore/cmp.rs Outdated Show resolved Hide resolved
Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! r=me if no other changes!

@Centril
Copy link
Contributor

Centril commented Jan 12, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 12, 2019

📌 Commit 186d5d7 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Jan 12, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 13, 2019
bors added a commit that referenced this pull request Jan 13, 2019
Rollup of 16 pull requests

Successful merges:

 - #57351 (Don't actually create a full MIR stack frame when not needed)
 - #57353 (Optimise floating point `is_finite` (2x) and `is_infinite` (1.6x).)
 - #57412 (Improve the wording)
 - #57436 (save-analysis: use a fallback when access levels couldn't be computed)
 - #57453 (lldb_batchmode.py: try `import _thread` for Python 3)
 - #57454 (Some cleanups for core::fmt)
 - #57461 (Change `String` to `&'static str` in `ParseResult::Failure`.)
 - #57473 (std: Render large exit codes as hex on Windows)
 - #57474 (save-analysis: Get path def from parent in case there's no def for the path itself.)
 - #57494 (Speed up item_bodies for large match statements involving regions)
 - #57496 (re-do docs for core::cmp)
 - #57508 (rustdoc: Allow inlining of reexported crates and crate items)
 - #57547 (Use `ptr::eq` where applicable)
 - #57557 (resolve: Mark extern crate items as used in more cases)
 - #57560 (hygiene: Do not treat `Self` ctor as a local variable)
 - #57564 (Update the const fn tracking issue to the new metabug)

Failed merges:

r? @ghost
@bors bors merged commit 186d5d7 into rust-lang:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants