Add a query type which is always marked as red if it runs #57770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors try |
|
⌛ Trying commit 980741a with merge 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1... |
|
☀️ Test successful - checks-travis |
|
@rust-timer build 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 |
|
Success: Queued 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 with parent 588f94b, comparison URL. |
|
Finished benchmarking try commit 51ba902cfedbb68bcc63bbefa6add90ca73dbaf1 |
|
@bors try |
|
⌛ Trying commit 0ccc8fa with merge ccd8d903fea581884646e7aacc105503e37ece94... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Test successful - checks-travis |
|
@rust-timer build ccd8d903fea581884646e7aacc105503e37ece94 |
|
Success: Queued ccd8d903fea581884646e7aacc105503e37ece94 with parent d38d6be, comparison URL. |
|
Finished benchmarking try commit ccd8d903fea581884646e7aacc105503e37ece94 |
|
@bors try |
bors
added a commit
that referenced
this pull request
Jan 21, 2019
Add a query type which is always marked as red if it runs This is useful for queries which produce results which are very likely to change if their inputs do. I also expect this to be useful for end to end queries because 1) we don't need `HashStable` impls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map. r? @michaelwoerister
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☀️ Test successful - checks-travis |
|
@rust-timer build cb75345 |
|
Success: Queued cb75345 with parent e730697, comparison URL. |
|
Finished benchmarking try commit cb75345 |
|
Thanks, @Zoxc. This looks good and I like how it is implemented. I had this implemented at some point (with an The biggest downside is that it relies on intuition on where it might be beneficial based on the current topology of query dependencies. If the topology changes (e.g. there are additional consumers of a query) then it would have to be re-evaluated if a given query should be Another downside is that it skews the data we collect about cache-hits. It gets harder to reason about what's actually going on as far as re-use is concerned. That being said, the above concerns are also true for The first thing I'd like to try is to remove |
|
It actually shouldn't be too hard to collect data on this. All queries that are re-evaluated but then turn out to be green should go through this branch: rust/src/librustc/dep_graph/graph.rs Line 292 in ffee835 That should tell us how likely it is for a given query that it turns red if its inputs change. |
|
@bors try |
|
@michaelwoerister Yeah. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Great! @bors r+ |
|
📌 Commit b4a6f59 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b4a6f59 with merge 6a1134da5894be1a23f3fe6fca38af049a7dd895... |
|
💔 Test failed - checks-travis |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-review
|
@bors retry 3 hour timeout |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b4a6f59 with merge ee7091c79949ddd7bf86773183f750ab82eb8cc7... |
|
☀️ Test successful - checks-travis, status-appveyor |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 10, 2019
Add a query type which is always marked as red if it runs This is useful for queries which produce results which are very likely to change if their inputs do. I also expect this to be useful for end to end queries because 1) we don't need `HashStable` impls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map. r? @michaelwoerister
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for queries which produce results which are very likely to change if their inputs do.
I also expect this to be useful for end to end queries because 1) we don't need
HashStableimpls and 2) we avoid the overhead of hashing the result of large results like the AST or the HIR map.r? @michaelwoerister