Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeck: remove leaky nested probe during trait object method resolution #57835

Merged
merged 2 commits into from
Jan 23, 2019
Merged

typeck: remove leaky nested probe during trait object method resolution #57835

merged 2 commits into from
Jan 23, 2019

Commits on Jan 22, 2019

  1. Do not initiate nested probe within assemble_probe. 

    In particular, the table entries (associated with type-variables
created during the probe) must persist as long as the candidates
assembled during the probe. If you make a nested probe without
creating a nested `ProbeContext`, the table entries are popped at the
end of the nested probe, while the type-variables would leak out via
the assembled candidates attached to `self` (the outer
`ProbeContext`). This causes an ICE (*if you are lucky*)!
    @pnkfelix
    pnkfelix committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    2dea8ec View commit details
    Browse the repository at this point in the history

  2. unit test for issue 57673.

    @pnkfelix
    pnkfelix committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    33c2ceb View commit details
    Browse the repository at this point in the history