Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to clean predicates involving ReErased #57851

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Projects
None yet
9 participants
@Aaron1011
Copy link
Contributor

Aaron1011 commented Jan 23, 2019

There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806

I haven't been able to come up with a minimized reproduction for the issue, but I've confirmed that this allows the docs to build for parqet-rs

Don't try to clean predicates involving ReErased
There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 23, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 4, 2019

Thanks!

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

📌 Commit e4fedf4 has been approved by GuillaumeGomez

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

⌛️ Testing commit e4fedf4 with merge 1edb31f...

bors added a commit that referenced this pull request Feb 4, 2019

Auto merge of #57851 - Aaron1011:fix/clean-lifetime, r=GuillaumeGomez
Don't try to clean predicates involving ReErased

There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806

I haven't been able to come up with a minimized reproduction for the issue, but I've confirmed that this allows the docs to build for `parqet-rs`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 4, 2019

💔 Test failed - status-appveyor

@Aaron1011

This comment has been minimized.

Copy link
Contributor Author

Aaron1011 commented Feb 4, 2019

@GuillaumeGomez: This appears to be a spurious failure. Here's the end of the log for the failing Appveyor log:

Successful compile (408.281 sec). Resulting Setup program filename is:
C:\projects\rust\build\tmp\dist\exe\rust-nightly-x86_64-pc-windows-gnu.exe
rust.wxs
ui.wxs
rustwelcomedlg.wxs
RustcGroup.wxs
DocsGroup.wxs
CargoGroup.wxs
StdGroup.wxs
RlsGroup.wxs
ClippyGroup.wxs
MiriGroup.wxs
AnalysisGroup.wxs
GccGroup.wxs
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 4, 2019

Not convenient...

@bors: retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

⌛️ Testing commit e4fedf4 with merge dadc4ee...

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #57851 - Aaron1011:fix/clean-lifetime, r=GuillaumeGomez
Don't try to clean predicates involving ReErased

There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806

I haven't been able to come up with a minimized reproduction for the issue, but I've confirmed that this allows the docs to build for `parqet-rs`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 5, 2019

The job dist-x86_64-apple-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:01:37]    Compiling serde_derive v1.0.81
[00:01:39]    Compiling toml v0.4.10
[00:01:39]    Compiling serde_json v1.0.33
[00:01:50]    Compiling bootstrap v0.0.0 (/Users/travis/build/rust-lang/rust/src/bootstrap)
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Aaron1011

This comment has been minimized.

Copy link
Contributor Author

Aaron1011 commented Feb 5, 2019

@GuillaumeGomez: A travis job seems to have randomly hung.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Feb 5, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

⌛️ Testing commit e4fedf4 with merge ca463ab...

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #57851 - Aaron1011:fix/clean-lifetime, r=GuillaumeGomez
Don't try to clean predicates involving ReErased

There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806

I haven't been able to come up with a minimized reproduction for the issue, but I've confirmed that this allows the docs to build for `parqet-rs`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 5, 2019

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:41:51] test vec::test_split_at_mut ... ok
[01:41:51] test vec::test_split_off ... ok
[01:41:51] test vec::test_splice_unbounded ... ok
[01:41:51] test vec::test_swap_remove_empty ... ok
[01:41:52] died due to signal 11
[01:41:52] 
[01:41:52] 
[01:41:52] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:41:52] expected success, got: exit code: 3
---
travis_time:end:0047c8e0:start=1549383719637788139,finish=1549383719654481604,duration=16693465
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0c8f1ed4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:110e7004
travis_time:start:110e7004
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0bd44166
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Feb 5, 2019

@bors retry #55861

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

⌛️ Testing commit e4fedf4 with merge 4b1e39b...

bors added a commit that referenced this pull request Feb 5, 2019

Auto merge of #57851 - Aaron1011:fix/clean-lifetime, r=GuillaumeGomez
Don't try to clean predicates involving ReErased

There's nothing to render when we have a bound involving ReErased (either
a type or region outliving it), so we don't attempt to generate a clean
WherePredicate

Fixes #57806

I haven't been able to come up with a minimized reproduction for the issue, but I've confirmed that this allows the docs to build for `parqet-rs`
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: GuillaumeGomez
Pushing 4b1e39b to master...

@bors bors merged commit e4fedf4 into rust-lang:master Feb 5, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.