Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RISC-V atomic compare and swap #57925

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Conversation

fintelia
Copy link
Contributor

Fixes #56564

@rust-highfive

This comment has been minimized.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2019
@memoryruins
Copy link
Contributor

cc #52787 @japaric @dvc94ch

@nagisa
Copy link
Member

nagisa commented Jan 26, 2019

From what I can see the LLVM submodule has not been updated in the past 6 weeks. It doesn’t seem like this should be landed before an LLVM update, but I would be fine with merging this if this PR updated the LLVM submodule as well...

@nikic
Copy link
Contributor

nikic commented Jan 26, 2019

@nagisa LLVM was updated in #57675. You probably still have the (now no longer used) pre-monorepo submodule lying around.

@nagisa
Copy link
Member

nagisa commented Jan 26, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Jan 26, 2019

📌 Commit 607c543 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2019
@Centril
Copy link
Contributor

Centril commented Jan 27, 2019

r? @nagisa

You r+ it, you own it ;)

@rust-highfive rust-highfive assigned nagisa and unassigned cramertj Jan 27, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 27, 2019
@bors
Copy link
Contributor

bors commented Jan 27, 2019

⌛ Testing commit 607c543 with merge 677064b...

bors added a commit that referenced this pull request Jan 27, 2019
Enable RISC-V atomic compare and swap

Fixes #56564
@bors
Copy link
Contributor

bors commented Jan 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing 677064b to master...

@bors bors merged commit 607c543 into rust-lang:master Jan 27, 2019
dumblob referenced this pull request in betrusted-io/betrusted-soc Nov 12, 2019
…ures

A pretty awful and very forced port of the cortex-m linked list
allocator. The main issue is that the RiscV runtime doesn't seem
to support atomic boolean swaps, which means the Mutex implementation
won't work.

Pulled in a Mutex implementation and lied to the system that the
mutex is always available. This will get us through initial board
bring-up but someone with real OS knowledge needs to fix this
down the road....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants