New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize the time_checked_add feature #58034

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
7 participants
@faern
Copy link
Contributor

faern commented Jan 31, 2019

Closes #55940

Stabilizes checked_add and checked_sub on Instant and SystemTime.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

rust-highfive commented Jan 31, 2019

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

Show resolved Hide resolved src/libstd/time.rs Outdated
@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 31, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

Centril commented Jan 31, 2019

Since that didn't work... moving on:

r? @alexcrichton

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 1, 2019

Thanks @faern! This looks good to go to me, so I'm going to marked this blocked on the FCP happening in #55940

@faern

This comment has been minimized.

Copy link
Contributor Author

faern commented Feb 12, 2019

The FCP is now complete. Merge?

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 12, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit 2f2d495 has been approved by alexcrichton

@bors bors added S-waiting-on-bors and removed S-blocked labels Feb 12, 2019

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Feb 12, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58034 - faern:stabilize-time-checked-add, r…
…=alexcrichton

Stabilize the time_checked_add feature

Closes rust-lang#55940

Stabilizes `checked_add` and `checked_sub` on `Instant` and `SystemTime`.

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58034 - faern:stabilize-time-checked-add, r…
…=alexcrichton

Stabilize the time_checked_add feature

Closes rust-lang#55940

Stabilizes `checked_add` and `checked_sub` on `Instant` and `SystemTime`.

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58413 - Centril:rollup, r=Centril
Rollup of 13 pull requests

Successful merges:

 - #57693 (Doc rewording)
 - #57815 (Speed up the fast path for assert_eq! and assert_ne!)
 - #58034 (Stabilize the time_checked_add feature)
 - #58057 (Stabilize linker-plugin based LTO (aka cross-language LTO))
 - #58137 (Cleanup: rename node_id_to_type(_opt))
 - #58166 (allow shorthand syntax for deprecation reason)
 - #58196 (Add specific feature gate error for const-unstable features)
 - #58200 (fix str mutating through a ptr derived from &self)
 - #58273 (Rename rustc_errors dependency in rust 2018 crates)
 - #58289 (impl iter() for dyn Error)
 - #58387 (Disallow `auto` trait alias syntax)
 - #58404 (use Ubuntu keyserver for CloudABI ports)
 - #58405 (Remove some dead code from libcore)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019

Rollup merge of rust-lang#58034 - faern:stabilize-time-checked-add, r…
…=alexcrichton

Stabilize the time_checked_add feature

Closes rust-lang#55940

Stabilizes `checked_add` and `checked_sub` on `Instant` and `SystemTime`.

bors added a commit that referenced this pull request Feb 13, 2019

Auto merge of #58415 - Centril:rollup, r=Centril
Rollup of 12 pull requests

Successful merges:

 - #57693 (Doc rewording)
 - #57815 (Speed up the fast path for assert_eq! and assert_ne!)
 - #58034 (Stabilize the time_checked_add feature)
 - #58057 (Stabilize linker-plugin based LTO (aka cross-language LTO))
 - #58137 (Cleanup: rename node_id_to_type(_opt))
 - #58166 (allow shorthand syntax for deprecation reason)
 - #58200 (fix str mutating through a ptr derived from &self)
 - #58273 (Rename rustc_errors dependency in rust 2018 crates)
 - #58289 (impl iter() for dyn Error)
 - #58387 (Disallow `auto` trait alias syntax)
 - #58404 (use Ubuntu keyserver for CloudABI ports)
 - #58405 (Remove some dead code from libcore)

Failed merges:

r? @ghost

@bors bors merged commit 2f2d495 into rust-lang:master Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment