Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic simd saturated add/sub intrinsics #58304

Merged
merged 4 commits into from Feb 24, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Feb 8, 2019

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:046b0bae:start=1549636456292843745,finish=1549636531242800166,duration=74949956421
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:08:17] .................................................................................................... 4300/5377
[01:08:20] .................................................................................................... 4400/5377
[01:08:24] .................................................................................................... 4500/5377
[01:08:29] ..........................i......................................................................... 4600/5377
[01:08:35] ........................................................................F........................... 4700/5377
[01:08:42] .................................................................................................... 4900/5377
[01:08:46] .................................................................................................... 5000/5377
[01:08:50] .................................................................................................... 5100/5377
[01:08:53] .................................................................................................... 5200/5377
[01:08:53] .................................................................................................... 5200/5377
[01:08:56] .................................................................................................... 5300/5377
[01:08:59] ................i............................................................
[01:08:59] failures:
[01:08:59] 
[01:08:59] ---- [ui] ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs stdout ----
[01:08:59] diff of stderr:
[01:08:59] 
[01:08:59] 1 error[E0511]: invalid monomorphization of `simd_saturating_add` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type
[01:08:59] -   --> $DIR/simd-intrinsic-generic-arithmetic-saturating.rs:31:9
[01:08:59] +   --> $DIR/simd-intrinsic-generic-arithmetic-saturating.rs:33:9
[01:08:59] 3    |
[01:08:59] 4 LL |         simd_saturating_add(z, z);
[01:08:59] 
[01:08:59] 6 
[01:08:59] 6 
[01:08:59] 7 error[E0511]: invalid monomorphization of `simd_saturating_sub` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type
[01:08:59] -   --> $DIR/simd-intrinsic-generic-arithmetic-saturating.rs:33:9
[01:08:59] +   --> $DIR/simd-intrinsic-generic-arithmetic-saturating.rs:35:9
[01:08:59] 9    |
[01:08:59] 10 LL |         simd_saturating_sub(z, z);
[01:08:59] 
[01:08:59] 
[01:08:59] The actual stderr differed from the expected stderr.
[01:08:59] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating/simd-intrinsic-generic-arithmetic-saturating.stderr
[01:08:59] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating/simd-intrinsic-generic-arithmetic-saturating.stderr
[01:08:59] To update references, rerun the tests and pass the `--bless` flag
[01:08:59] To only update this specific test, also pass `--test-args simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs`
[01:08:59] error: 1 errors occurred comparing output.
[01:08:59] status: exit code: 1
[01:08:59] status: exit code: 1
[01:08:59] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating/auxiliary" "-A" "unused"
[01:08:59] ------------------------------------------
[01:08:59] 
[01:08:59] ------------------------------------------
[01:08:59] stderr:
[01:08:59] stderr:
[01:08:59] ------------------------------------------
[01:08:59] {"message":"invalid monomorphization of `simd_saturating_add` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type","code":{"code":"E0511","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs","byte_start":799,"byte_end":824,"line_start":33,"line_end":33,"column_start":9,"column_end":34,"is_primary":true,"text":[{"text":"        simd_saturating_add(z, z);","highlight_start":9,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0511]: invalid monomorphization of `simd_saturating_add` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type\n  --> /checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs:33:9\n   |\nLL |         simd_saturating_add(z, z);\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:08:59] {"message":"invalid monomorphization of `simd_saturating_sub` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type","code":{"code":"E0511","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs","byte_start":944,"byte_end":969,"line_start":35,"line_end":35,"column_start":9,"column_end":34,"is_primary":true,"text":[{"text":"        simd_saturating_sub(z, z);","highlight_start":9,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error[E0511]: invalid monomorphization of `simd_saturating_sub` intrinsic: expected element type `f32` of vector type `f32x4` to be a signed or unsigned integer type\n  --> /checkout/src/test/ui/simd-intrinsic/simd-intrinsic-generic-arithmetic-saturating.rs:35:9\n   |\nLL |         simd_saturating_sub(z, z);\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:08:59] {"message":"For more information about this error, try `rustc --explain E0511`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0511`.\n"}
[01:08:59] 
[01:08:59] ------------------------------------------
[01:08:59] 
---
[01:08:59] 
[01:08:59] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:502:22
[01:08:59] 
[01:08:59] 
[01:08:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:08:59] 
[01:08:59] 
[01:08:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:08:59] Build completed unsuccessfully in 0:04:29
[01:08:59] Build completed unsuccessfully in 0:04:29
[01:08:59] Makefile:48: recipe for target 'check' failed
[01:08:59] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01833ac3
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb  8 15:44:40 UTC 2019
---
travis_time:end:08849358:start=1549640682097515510,finish=1549640682103235757,duration=5720247
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:05427f68
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!ch

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:259e2165:start=1549641334392445045,finish=1549641499834454546,duration=165442009501
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[01:07:19] .................................................................................................... 2100/2948
[01:07:41] .................................................................................................... 2200/2948
[01:07:43] ........................test [run-pass] run-pass/mpsc_stress.rs has been running for over 60 seconds
[01:07:52] ...........................................ii............................... 2300/2948
[01:08:07] .....................................i.....F........................................................ 2400/2948
[01:08:50] .................................................................................................... 2600/2948
[01:09:00] .................................................................................................... 2700/2948
[01:09:09] .................................................................................................... 2800/2948
[01:09:20] .................................................................................................... 2900/2948
[01:09:20] .................................................................................................... 2900/2948
[01:09:27] ................................................
[01:09:27] failures:
[01:09:27] 
[01:09:27] ---- [run-pass] run-pass/simd/simd-intrinsic-generic-arithmetic-saturating.rs stdout ----
[01:09:27] 
[01:09:27] error: test compilation failed although it shouldn't!
[01:09:27] status: exit code: 1
[01:09:27] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/auxiliary"
[01:09:27] ------------------------------------------
[01:09:27] 
[01:09:27] ------------------------------------------
[01:09:27] stderr:
[01:09:27] stderr:
[01:09:27] ------------------------------------------
[01:09:27] {"message":"linking with `cc` failed: exit code: 1","code":null,"level":"error","spans":[],"children":[{"message":"\"cc\" \"-Wl,--as-needed\" \"-Wl,-z,noexecstack\" \"-m64\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.1.rcgu.o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.2.rcgu.o\" \"-o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a\" \"-Wl,--gc-sections\" \"-pie\" \"-Wl,-zrelro\" \"-Wl,-znow\" \"-Wl,-O1\" \"-nodefaultlibs\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/auxiliary\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"-Wl,--start-group\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"-lstd-b71c391837386050\" \"-Wl,--end-group\" \"-Wl,-Bstatic\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-ec024234a641382a.rlib\" \"-Wl,-Bdynamic\" \"-ldl\" \"-lrt\" \"-lpthread\" \"-lgcc_s\" \"-lc\" \"-lm\" \"-lrt\" \"-lpthread\" \"-lutil\" \"-lutil\" \"-Wl,-rpath,$ORIGIN/../../../../stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"-Wl,-rpath,/checkout/obj/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"-Wl,--enable-new-dtags\"","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x52): undefined reference to `llvm.uadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xbc): undefined reference to `llvm.uadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x142): undefined reference to `llvm.uadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x1b7): undefined reference to `llvm.uadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x22c): undefined reference to `llvm.uadd.sat.v4i32'\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x2b2): more undefined references to `llvm.uadd.sat.v4i32' follow\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x3b0): undefined reference to `llvm.usub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x422): undefined reference to `llvm.usub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x49e): undefined reference to `llvm.usub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x51c): undefined reference to `llvm.usub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x59c): undefined reference to `llvm.usub.sat.v4i32'\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x619): more undefined references to `llvm.usub.sat.v4i32' follow\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x6f3): undefined reference to `llvm.sadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x771): undefined reference to `llvm.sadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x7f4): undefined reference to `llvm.sadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x866): undefined reference to `llvm.sadd.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x8d8): undefined reference to `llvm.sadd.sat.v4i32'\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x953): more undefined references to `llvm.sadd.sat.v4i32' follow\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xd01): undefined reference to `llvm.ssub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xd70): undefined reference to `llvm.ssub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xdf1): undefined reference to `llvm.ssub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xe79): undefined reference to `llvm.ssub.sat.v4i32'\nsimd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xeee): undefined reference to `llvm.ssub.sat.v4i32'\n/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xf6c): more undefined references to `llvm.ssub.sat.v4i32' follow\ncollect2: error: ld returned 1 exit status\n","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: linking with `cc` failed: exit code: 1\n   |\n   = note: \"cc\" \"-Wl,--as-needed\" \"-Wl,-z,noexecstack\" \"-m64\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.1.rcgu.o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.2.rcgu.o\" \"-o\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a\" \"-Wl,--gc-sections\" \"-pie\" \"-Wl,-zrelro\" \"-Wl,-znow\" \"-Wl,-O1\" \"-nodefaultlibs\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/sreference to `llvm.uadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x1b7): undefined reference to `llvm.uadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x22c): undefined reference to `llvm.uadd.sat.v4i32'\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x2b2): more undefined references to `llvm.uadd.sat.v4i32' follow\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x3b0): undefined reference to `llvm.usub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x422): undefined reference to `llvm.usub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x49e): undefined reference to `llvm.usub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x51c): undefined reference to `llvm.usub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x59c): undefined reference to `llvm.usub.sat.v4i32'\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x619): more undefined references to `llvm.usub.sat.v4i32' follow\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x6f3): undefined reference to `llvm.sadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x771): undefined reference to `llvm.sadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x7f4): undefined reference to `llvm.sadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x866): undefined reference to `llvm.sadd.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x8d8): undefined reference to `llvm.sadd.sat.v4i32'\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0x953): more undefined references to `llvm.sadd.sat.v4i32' follow\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o: In function `simd_intrinsic_generic_arithmetic_saturating::main::h39f3b3b44399cf8e':\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xd01): undefined reference to `llvm.ssub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xd70): undefined reference to `llvm.ssub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xdf1): undefined reference to `llvm.ssub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xe79): undefined reference to `llvm.ssub.sat.v4i32'\n           simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xeee): undefined reference to `llvm.ssub.sat.v4i32'\n           /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/simd/simd-intrinsic-generic-arithmetic-saturating/a.simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0.rcgu.o:simd_intrinsic_generic_arithmetic_saturating.7rcbfp3g-cgu.0:(.text._ZN44simd_intrinsic_generic_arithmetic_saturating4main17h39f3b3b44399cf8eE+0xf6c): more undefined references to `llvm.ssub.sat.v4i32' follow\n           collect2: error: ld returned 1 exit status\n           \n\n"}
[01:09:27] 
[01:09:27] ------------------------------------------
[01:09:27] 
[01:09:27] thread '[run-pass] run-pass/simd/simd-intrinsic-generic-arithmetic-saturating.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:09:27] 
[01:09:27] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:502:22
[01:09:27] 
[01:09:27] 
[01:09:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:09:27] 
[01:09:27] 
[01:09:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:09:27] Build completed unsuccessfully in 0:10:09
[01:09:27] Build completed unsuccessfully in 0:10:09
[01:09:27] Makefile:48: recipe for target 'check' failed
[01:09:27] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:04e90bd6
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Fri Feb  8 17:07:55 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb
Copy link
Member

eddyb commented Feb 14, 2019

r? @rkruppe / @nagisa

@rust-highfive rust-highfive assigned hanna-kruppe and unassigned eddyb Feb 14, 2019
@hanna-kruppe
Copy link
Contributor

r? @nagisa then, I won't be able to review for at least a week from now due to travel

@rust-highfive rust-highfive assigned nagisa and unassigned hanna-kruppe Feb 14, 2019
@nagisa
Copy link
Member

nagisa commented Feb 16, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2019

📌 Commit f0783d5 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2019
@Centril
Copy link
Contributor

Centril commented Feb 23, 2019

Too big to rollup, @bors p=1

@bors
Copy link
Contributor

bors commented Feb 24, 2019

⌛ Testing commit f0783d5 with merge 7cb3ee4...

bors added a commit that referenced this pull request Feb 24, 2019
Add generic simd saturated add/sub intrinsics

r? @eddyb
@bors
Copy link
Contributor

bors commented Feb 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing 7cb3ee4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 24, 2019
@bors
Copy link
Contributor

bors commented Feb 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: nagisa
Pushing 7cb3ee4 to master...

@bors bors merged commit f0783d5 into rust-lang:master Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants