New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Small fixes in chalkification #58305

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@scalexm
Copy link
Member

scalexm commented Feb 8, 2019

Small fixes around region constraints and builtin impls. There are still some type inference errors, for example the following code errors out:

fn main() {
    let mut x: Vec<i32> = Vec::new();
    //                    ^^^^^^^^ cannot infer type for `std::vec::Vec<_>`
}

but explicitly specifying Vec::<i32>::new works.

With these few fixes, the following code now passes type-checking:

fn main() {
    let mut x: Vec<i32> = Vec::<i32>::new();
    x.push(5);
    println!("{:?}", x);
}

I also fixed the implied bounds bug as discussed on Zulip and in rust-lang-nursery/chalk#206

cc @tmandry
r? @nikomatsakis

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 9, 2019

☔️ The latest upstream changes (presumably #58316) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment