Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #58495

Merged
merged 60 commits into from
Feb 17, 2019
Merged

Rollup of 19 pull requests #58495

merged 60 commits into from
Feb 17, 2019

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Feb 15, 2019

Successful merges:

GuillaumeGomez and others added 30 commits January 27, 2019 00:34
It's no longer necessary, as there is no license header anymore.
This change was accidentally introduced while removing license headers.
This is a non-POSIX extension implemented in Solaris and in glibc 2.29.
With this we can still use `posix_spawn()` when `Command::current_dir()`
has been set, otherwise we fallback to `fork(); chdir(); exec()`.
Since `compiler_builtins` is being injected automatically, its docs
aren't masked. This commit masks the crate's docs if it's brought in as
an extern crate.
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2019
@kennytm
Copy link
Member Author

kennytm commented Feb 17, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2019
…r, r=alexcrichton

Fix runtime error in generate-keyword-tests

The script was made unusable after removing license headers.
…tyle-files, r=ollie27

Rustdoc remove old style files

Reopening of rust-lang#56577 (which I can't seem to reopen...).

I made the flag unstable so with this change, what was blocking the PR is now gone I assume.
…frewsxcv

Fix documentation for std::path::PathBuf::pop

Closes rust-lang#58474.
…ate_maintainers, r=oli-obk

Notify myself when Clippy toolstate changes
…tboats

Fix tracking issue for error iterators
@kennytm
Copy link
Member Author

kennytm commented Feb 17, 2019

@bors r+

Removed #58477 (already testing)
Added #58521.

@bors
Copy link
Contributor

bors commented Feb 17, 2019

📌 Commit c65a82a has been approved by kennytm

@bors
Copy link
Contributor

bors commented Feb 17, 2019

⌛ Testing commit c65a82a with merge 8af675a...

bors added a commit that referenced this pull request Feb 17, 2019
Rollup of 19 pull requests

Successful merges:

 - #57929 (Rustdoc remove old style files)
 - #57981 (Fix #57730)
 - #58074 (Stabilize slice_sort_by_cached_key)
 - #58196 (Add specific feature gate error for const-unstable features)
 - #58293 (Remove code for updating copyright years in generate-deriving-span-tests)
 - #58306 (Don't default on std crate when manipulating browser history)
 - #58359 (librustc_mir: use ? in impl_snapshot_for! macro)
 - #58395 (Instant::checked_duration_since)
 - #58429 (fix Box::into_unique effecitvely transmuting to a raw ptr)
 - #58433 (Update which libcore/liballoc tests Miri ignores, and document why)
 - #58438 (Use posix_spawn_file_actions_addchdir_np when possible)
 - #58440 (Whitelist the ARM v6 target-feature)
 - #58448 (rustdoc: mask `compiler_builtins` docs)
 - #58468 (split MaybeUninit into several features, expand docs a bit)
 - #58479 (compile-pass test for #53606)
 - #58489 (Fix runtime error in generate-keyword-tests)
 - #58496 (Fix documentation for std::path::PathBuf::pop)
 - #58509 (Notify myself when Clippy toolstate changes)
 - #58521 (Fix tracking issue for error iterators)
@bors
Copy link
Contributor

bors commented Feb 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: kennytm
Pushing 8af675a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2019
@bors bors merged commit c65a82a into rust-lang:master Feb 17, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:26403f80
$ git clone --depth=2 --branch=master https://github.com/rust-lang/rust.git rust-lang/rust
---
  fi
travis_time:end:0002623e:start=1550398500132386472,finish=1550398500139270972,duration=6884500
travis_fold:end:before_script.3
travis_time:start:0ba89b50
$ MESSAGE_FILE=$(mktemp -t msg.XXXXXX); . src/ci/docker/x86_64-gnu-tools/repo.sh; commit_toolstate_change "$MESSAGE_FILE" "$TRAVIS_BUILD_DIR/src/tools/publish_toolstate.py" "$(git rev-parse HEAD)" "$(git log --format=%s -n1 HEAD)" "$MESSAGE_FILE" "$TOOLSTATE_REPO_ACCESS_TOKEN";

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet