Make migrate mode work at item level granularity #58788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit a046c38 has been approved by |
bors
added
S-waiting-on-bors
|
beta nominating since this bug is causing soundness bugs to be masked as warnings without good reason. |
pnkfelix
added
beta-nominated
|
discussed at T-compiler meeting; approved for beta backport |
pnkfelix
added
the
beta-accepted
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Mar 1, 2019
…nkfelix Make migrate mode work at item level granularity Migrate mode now works entirely at the item level rather than the body level, ensuring that we don't lose any errors in contained closures. Closes rust-lang#58776 r? @pnkfelix
|
☔ The latest upstream changes (presumably #58836) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
matthewjasper
force-pushed
the
compare-children
branch
from
a046c38
to
2742b23
Compare
|
@bors r=pnkfelix |
|
📌 Commit 2742b23 has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…nkfelix Make migrate mode work at item level granularity Migrate mode now works entirely at the item level rather than the body level, ensuring that we don't lose any errors in contained closures. Closes rust-lang#58776 r? @pnkfelix
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…nkfelix Make migrate mode work at item level granularity Migrate mode now works entirely at the item level rather than the body level, ensuring that we don't lose any errors in contained closures. Closes rust-lang#58776 r? @pnkfelix
|
Speculatively assigning blame to failure in #59067 (comment), @bors r- |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
matthewjasper
force-pushed
the
compare-children
branch
from
2742b23
to
7285b56
Compare
|
@bors r=pnkfelix |
|
📌 Commit 7285b56 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 10, 2019
…nkfelix Make migrate mode work at item level granularity Migrate mode now works entirely at the item level rather than the body level, ensuring that we don't lose any errors in contained closures. Closes rust-lang#58776 r? @pnkfelix
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2019
…nkfelix Make migrate mode work at item level granularity Migrate mode now works entirely at the item level rather than the body level, ensuring that we don't lose any errors in contained closures. Closes rust-lang#58776 r? @pnkfelix
|
☀️ Test successful - checks-travis, status-appveyor |
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 16, 2019
[beta] Rollup backports Cherry-picked: * Include bounds from promoted constants in NLL #57202 * Warning period for detecting nested impl trait #58608 * Don't promote function calls to nonpromotable things #58784 * Make migrate mode work at item level granularity #58788 * Expand where negative supertrait specific error is shown #58861 * Expand where negative supertrait specific error is shown #58861 Rolled up: * [BETA] Update cargo #59217 r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate mode now works entirely at the item level rather than the body level,
ensuring that we don't lose any errors in contained closures.
Closes #58776
r? @pnkfelix