Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When encountering `||{}()`, suggest the likely intended `(||{})()` #59035

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
4 participants
@estebank
Copy link
Contributor

commented Mar 9, 2019

Fix #55851.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@davidtwco

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

📌 Commit 9aa89b2 has been approved by davidtwco

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

bors added a commit that referenced this pull request Mar 10, 2019

Auto merge of #59067 - Centril:rollup, r=Centril
Rollup of 17 pull requests

Successful merges:

 - #58021 (Fix fallout from #57667)
 - #58330 (Add rustdoc JS non-std tests)
 - #58788 (Make migrate mode work at item level granularity)
 - #58789 (Update compiler_builtins to 0.1.7 to get windows/arm fix)
 - #58803 (fs::copy() linux: set file mode early)
 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58848 (Prevent cache issues on version updates)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58872 (Adds help message in error for invalid `impl for T` syntax)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59047 (resolve: Account for new importable entities)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

bors added a commit that referenced this pull request Mar 10, 2019

Auto merge of #59069 - Centril:rollup, r=Centril
Rollup of 16 pull requests

Successful merges:

 - #58021 (Fix fallout from #57667)
 - #58330 (Add rustdoc JS non-std tests)
 - #58789 (Update compiler_builtins to 0.1.7 to get windows/arm fix)
 - #58803 (fs::copy() linux: set file mode early)
 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58848 (Prevent cache issues on version updates)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58872 (Adds help message in error for invalid `impl for T` syntax)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59047 (resolve: Account for new importable entities)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

bors added a commit that referenced this pull request Mar 10, 2019

Auto merge of #59075 - Centril:rollup, r=Centril
Rollup of 17 pull requests

Successful merges:

 - #58021 (Fix fallout from #57667)
 - #58788 (Make migrate mode work at item level granularity)
 - #58789 (Update compiler_builtins to 0.1.7 to get windows/arm fix)
 - #58803 (fs::copy() linux: set file mode early)
 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58848 (Prevent cache issues on version updates)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58872 (Adds help message in error for invalid `impl for T` syntax)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58901 (Change `std::fs::copy` to use `copyfile` on MacOS and iOS)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59047 (resolve: Account for new importable entities)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
 - #59072 (we can now skip should_panic tests with the libtest harness)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

bors added a commit that referenced this pull request Mar 11, 2019

Auto merge of #59081 - Centril:rollup, r=Centril
Rollup of 15 pull requests

Successful merges:

 - #58021 (Fix fallout from #57667)
 - #58788 (Make migrate mode work at item level granularity)
 - #58789 (Update compiler_builtins to 0.1.7 to get windows/arm fix)
 - #58829 (librustc_interface: Update scoped-tls to 1.0)
 - #58848 (Prevent cache issues on version updates)
 - #58855 (std: Spin for a global malloc lock on wasm32)
 - #58872 (Adds help message in error for invalid `impl for T` syntax)
 - #58876 (Parse lifetimes that start with a number and give specific error)
 - #58938 (core: ensure VaList passes improper_ctypes lint)
 - #58941 (MIPS: add r6 support)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59036 (Fix ICE in MIR pretty printing)
 - #59047 (resolve: Account for new importable entities)
 - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std)
 - #59072 (we can now skip should_panic tests with the libtest harness)

Failed merges:

r? @ghost

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 13, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2019

Rollup merge of rust-lang#59035 - estebank:closure-instacall, r=david…
…twco

When encountetring `||{}()`, suggest the likely intended `(||{})()`

Fix rust-lang#55851.

bors added a commit that referenced this pull request Mar 17, 2019

Auto merge of #59244 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #58995 (Refactor tools/build-mainfest)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59038 (Track embedded-book in the toolstate)
 - #59047 (resolve: Account for new importable entities)
 - #59068 (HirIdification: kill off NodeId stragglers)
 - #59096 (middle: replace NodeId with HirId in AccessLevels)
 - #59106 (Add peer_addr function to UdpSocket)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)

Failed merges:

 - #59195 (When moving out of a for loop head, suggest borrowing it)

r? @ghost

bors added a commit that referenced this pull request Mar 17, 2019

Auto merge of #59244 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #58995 (Refactor tools/build-mainfest)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59038 (Track embedded-book in the toolstate)
 - #59047 (resolve: Account for new importable entities)
 - #59068 (HirIdification: kill off NodeId stragglers)
 - #59096 (middle: replace NodeId with HirId in AccessLevels)
 - #59106 (Add peer_addr function to UdpSocket)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)

Failed merges:

 - #59195 (When moving out of a for loop head, suggest borrowing it)

r? @ghost

bors added a commit that referenced this pull request Mar 17, 2019

Auto merge of #59244 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #58995 (Refactor tools/build-mainfest)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59038 (Track embedded-book in the toolstate)
 - #59047 (resolve: Account for new importable entities)
 - #59068 (HirIdification: kill off NodeId stragglers)
 - #59096 (middle: replace NodeId with HirId in AccessLevels)
 - #59106 (Add peer_addr function to UdpSocket)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)

Failed merges:

 - #59195 (When moving out of a for loop head, suggest borrowing it)

r? @ghost

bors added a commit that referenced this pull request Mar 17, 2019

Auto merge of #59244 - Centril:rollup, r=Centril
Rollup of 9 pull requests

Successful merges:

 - #57729 (extra testing of how NLL handles wildcard type `_`)
 - #58995 (Refactor tools/build-mainfest)
 - #59035 (When encountetring `||{}()`, suggest the likely intended `(||{})()`)
 - #59038 (Track embedded-book in the toolstate)
 - #59047 (resolve: Account for new importable entities)
 - #59068 (HirIdification: kill off NodeId stragglers)
 - #59096 (middle: replace NodeId with HirId in AccessLevels)
 - #59106 (Add peer_addr function to UdpSocket)
 - #59116 (Be more discerning on when to attempt suggesting a comma in a macro invocation)

Failed merges:

 - #59195 (When moving out of a for loop head, suggest borrowing it)

r? @ghost

@estebank estebank changed the title When encountetring `||{}()`, suggest the likely intended `(||{})()` When encountering `||{}()`, suggest the likely intended `(||{})()` Mar 18, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

⌛️ Testing commit 9aa89b2 with merge 2210e9a...

bors added a commit that referenced this pull request Mar 22, 2019

Auto merge of #59035 - estebank:closure-instacall, r=davidtwco
When encountering `||{}()`, suggest the likely intended `(||{})()`

Fix #55851.
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: davidtwco
Pushing 2210e9a to master...

@bors bors added the merged-by-bors label Mar 22, 2019

@bors bors merged commit 9aa89b2 into rust-lang:master Mar 22, 2019

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.