Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn HIR indexing into a query #59064

Open
wants to merge 3 commits into
base: master
from

Conversation

@Zoxc
Copy link
Contributor

commented Mar 10, 2019

r? @michaelwoerister

@@ -458,6 +458,7 @@ define_dep_nodes!( <'tcx>
[eval_always] PrivacyAccessLevels(CrateNum),
[eval_always] CheckPrivateInPublic(CrateNum),
[eval_always] Analysis(CrateNum),
[eval_always] HirMap(CrateNum),

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 10, 2019

Author Contributor

Probably need a true eval_always query type, since these are actually eval if HIR changes, and we don't know if the HIR changes until after the HIR is hashed, which happens in the HirMap query.

This comment has been minimized.

Copy link
@michaelwoerister

michaelwoerister Mar 26, 2019

Contributor

This refers to #59091, right?

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 26, 2019

Author Contributor

Yeah.

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Mar 10, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1f50e5e0:start=1552217841025718581,finish=1552217841896323943,duration=870605362
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
travis_time:start:test_incremental
Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:19:25] 
[01:19:25] running 99 tests
[01:19:35] F.FFFFFFFFFFFFFFFFFFFF.FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF.FFF.FFF..FFFFFFFFFFFFF..FFFFFFFFFFFFFFFFFFF
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_add_field/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_add_field/struct_point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_add_field/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_add_field/struct_point/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_add_field/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_add_field/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_add_field/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] 
[01:19:35] ---- [incremental] incremental/callee_caller_cross_crate/b.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass2`: auxiliary build of "/checkout/src/test/incremental/callee_caller_cross_crate/auxiliary/a.rs" failed to compile: 
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/callee_caller_cross_crate/auxiliary/a.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/callee_caller_cross_crate/b/b.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/callee_caller_cross_crate/b/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/callee_caller_cross_crate/b/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath --crate-type dylib
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/callee_caller_cross_crate/b.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/callee_caller_cross_crate/b.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/add_private_fn_at_krate_root_cc/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: auxiliary build of "/checkout/src/test/incremental/add_private_fn_at_krate_root_cc/auxiliary/point.rs" failed to compile: 
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/add_private_fn_at_krate_root_cc/auxiliary/point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/add_private_fn_at_krate_root_cc/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/add_private_fn_at_krate_root_cc/struct_point/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/add_private_fn_at_krate_root_cc/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath --crate-type dylib
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/add_private_fn_at_krate_root_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/add_private_fn_at_krate_root_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_crate_dep_kind.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_crate_dep_kind.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_dep_kind/change_crate_dep_kind.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_dep_kind/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-Cpanic=unwind" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_dep_kind/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath -C panic=unwind
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_crate_dep_kind.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_crate_dep_kind.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_name_of_static_in_fn.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass2`: compilation failed!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_name_of_static_in_fn.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_name_of_static_in_fn/change_name_of_static_in_fn.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_name_of_static_in_fn/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_name_of_static_in_fn/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_name_of_static_in_fn.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_name_of_static_in_fn.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_private_fn/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_private_fn/struct_point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_private_fn/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_private_fn/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_crate_order/main.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass2`: auxiliary build of "/checkout/src/test/incremental/change_crate_order/auxiliary/a.rs" failed to compile: 
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_crate_order/auxiliary/a.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/main.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath --crate-type dylib
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_crate_order/main.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_crate_order/main.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_private_impl_method/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_private_impl_method/struct_point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method/struct_point/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_private_impl_method/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_private_impl_method/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_private_fn_cc/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: auxiliary build of "/checkout/src/test/incremental/change_private_fn_cc/auxiliary/point.rs" failed to compile: 
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_private_fn_cc/auxiliary/point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn_cc/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn_cc/struct_point/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_fn_cc/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath --crate-type dylib
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_private_fn_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_private_fn_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_private_impl_method_cc/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: auxiliary build of "/checkout/src/test/incremental/change_private_impl_method_cc/auxiliary/point.rs" failed to compile: 
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_private_impl_method_cc/auxiliary/point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method_cc/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method_cc/struct_point/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type" "dylib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_private_impl_method_cc/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath --crate-type dylib
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_private_impl_method_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_private_impl_method_cc/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_pub_inherent_method_body/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_pub_inherent_method_body/struct_point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_body/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_body/struct_point/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_body/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_pub_inherent_method_body/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_pub_inherent_method_body/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_symbol_export_status.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass2`: compilation failed!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_symbol_export_status.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_symbol_export_status/change_symbol_export_status.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_symbol_export_status/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zquery-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_symbol_export_status/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"lint `private_no_mangle_fns` has been removed: `no longer a warning, #[no_mangle] functions always exported`","code":{"code":"renamed_and_removed_lints","explanation":null},"level":"warning","spans":[{"file_name":"/checkout/src/test/incremental/change_symbol_export_status.rs","byte_start":99,"byte_end":120,"line_start":5,"line_end":5,"column_start":10,"column_end":31,"is_primary":true,"text":[{"text":"#![allow(private_no_mangle_fns)]","highlight_start":10,"highlight_end":31}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"#[warn(renamed_and_removed_lints)] on by default","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"warning: lint `private_no_mangle_fns` has been removed: `no longer a warning, #[no_mangle] functions always exported`\n  --> /checkout/src/test/incremental/change_symbol_export_status.rs:5:10\n   |\nLL | #![allow(private_no_mangle_fns)]\n   |          ^^^^^^^^^^^^^^^^^^^^^\n   |\n   = note: #[warn(renamed_and_removed_lints)] on by default\n\n"}
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_symbol_export_status.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_symbol_export_status.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/change_pub_inherent_method_sig/struct_point.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: test compilation failed although it shouldn't!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_pub_inherent_method_sig/struct_point.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_sig/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_sig/struct_point/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_pub_inherent_method_sig/struct_point/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/change_pub_inherent_method_sig/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/change_pub_inherent_method_sig/struct_point.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/crate_hash_reorder.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass2`: compilation failed!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/crate_hash_reorder.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/crate_hash_reorder/crate_hash_reorder.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/crate_hash_reorder/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/crate_hash_reorder/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/crate_hash_reorder.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/crate_hash_reorder.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/cyclic-trait-hierarchy.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: Error: expected failure status (Some(1)) but received status Some(101).
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/cyclic-trait-hierarchy.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/cyclic-trait-hierarchy.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/cyclic-trait-hierarchy/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/cyclic-trait-hierarchy.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/cyclic-trait-hierarchy.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/dirty_clean.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `cfail2`: Error: expected failure status (Some(1)) but received status Some(101).
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/dirty_clean.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail2" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/dirty_clean/dirty_clean.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/dirty_clean/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/dirty_clean/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/dirty_clean.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] thread '[incremental] incremental/dirty_clean.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:19:35] 
[01:19:35] ---- [incremental] incremental/commandline-args.rs stdout ----
[01:19:35] 
[01:19:35] error in revision `rpass3`: compilation failed!
[01:19:35] status: exit code: 101
[01:19:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/commandline-args.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass3" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/commandline-args/commandline-args.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/commandline-args/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-C" "debuginfo=2" "--verbose" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/commandline-args/auxiliary"
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] stderr:
[01:19:35] stderr:
[01:19:35] ------------------------------------------
[01:19:35] {"message":"src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate","code":null,"level":"error: internal compiler error","spans":[],"children":[],"rendered":"error: internal compiler error: src/librustc/ty/query/plumbing.rs:1238: force_from_dep_node() - Encountered Krate\n\n"}
[01:19:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:19:35] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:19:35] 
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] note: the compiler unexpectedly panicked. this is a bug.
[01:19:35] 
[01:19:35] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:19:35] 
[01:19:35] note: rustc 1.35.0-dev running on x86_64-unknown-linux-gnu
[01:19:35] 
[01:19:35] note: compiler flags: -Z threads=1 -Z incremental-verify-ich -Z incremental-queries -Z ui-testing -Z unstable-options -Z query-dep-graph -C incremental -C prefer-dynamic -C rpath -C debuginfo=2
[01:19:35] 
[01:19:35] ------------------------------------------
[01:19:35] 
[01:19:35] thread '[incremental] incremental/commandline-args.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:19:35] test result: FAILED. 8 passed; 91 failed; 0 ignored; 0 measured; 0 filtered out
[01:19:35] 
[01:19:35] 
[01:19:35] 
[01:19:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/incremental" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "incremental" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:19:35] 
[01:19:35] 
[01:19:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:19:35] Build completed unsuccessfully in 0:11:33
---
travis_time:end:00737e50:start=1552222629464693073,finish=1552222629469069181,duration=4376108
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0d056768
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:170edbef
travis_time:start:170edbef
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1625da62
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 57e0f33 to 0a99972 Mar 11, 2019

@rust-highfive

This comment was marked as outdated.

Copy link
Collaborator

commented Mar 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:1afde2be:start=1552296699888209224,finish=1552296775795550620,duration=75907341396
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:11:08] .......................................i............................................................ 600/5448
[01:11:12] .................................................................................................... 700/5448
[01:11:16] .................................................................................................... 800/5448
[01:11:21] ................................................................................................i... 900/5448
[01:11:25] ............i.............F......................................................................... 1000/5448
[01:11:29] .........................iiiii...................................................................... 1100/5448
[01:11:34] .................................................................................................... 1300/5448
[01:11:37] .................................................................................................... 1400/5448
[01:11:40] .................................................................................................... 1500/5448
[01:11:43] .................................................................................................... 1600/5448
---
[01:14:08] 
[01:14:08] ---- [ui] ui/dep-graph/dep-graph-variance-alias.rs stdout ----
[01:14:08] diff of stderr:
[01:14:08] 
[01:14:08] - error: OK
[01:14:08] + error: no path from `TypeAlias` to `ItemVariances`
[01:14:08] 3    |
[01:14:08] 3    |
[01:14:08] 4 LL | #[rustc_then_this_would_need(ItemVariances)] //~ ERROR OK
[01:14:08] 
[01:14:08] The actual stderr differed from the expected stderr.
[01:14:08] The actual stderr differed from the expected stderr.
[01:14:08] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-variance-alias/dep-graph-variance-alias.stderr
[01:14:08] To update references, rerun the tests and pass the `--bless` flag
[01:14:08] To only update this specific test, also pass `--test-args dep-graph/dep-graph-variance-alias.rs`
[01:14:08] error: 1 errors occurred comparing output.
[01:14:08] status: exit code: 1
[01:14:08] status: exit code: 1
[01:14:08] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/dep-graph/dep-graph-variance-alias.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-variance-alias/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/dep-graph/dep-graph-variance-alias/auxiliary" "-A" "unused"
[01:14:08] ------------------------------------------
[01:14:08] 
[01:14:08] ------------------------------------------
[01:14:08] stderr:
[01:14:08] stderr:
[01:14:08] ------------------------------------------
[01:14:08] {"message":"no path from `TypeAlias` to `ItemVariances`","code":null,"level":"error","spans":[{"file_name":"/checkout/src/test/ui/dep-graph/dep-graph-variance-alias.rs","byte_start":315,"byte_end":359,"line_start":19,"line_end":19,"column_start":1,"column_end":45,"is_primary":true,"text":[{"text":"#[rustc_then_this_would_need(ItemVariances)] //~ ERROR OK","highlight_start":1,"highlight_end":45}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: no path from `TypeAlias` to `ItemVariances`\n  --> /checkout/src/test/ui/dep-graph/dep-graph-variance-alias.rs:19:1\n   |\nLL | #[rustc_then_this_would_need(ItemVariances)] //~ ERROR OK\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n\n"}
[01:14:08] 
[01:14:08] ------------------------------------------
[01:14:08] 
[01:14:08] thread '[ui] ui/dep-graph/dep-graph-variance-alias.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
---
[01:14:08] 
[01:14:08] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:14:08] 
[01:14:08] 
[01:14:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:14:08] 
[01:14:08] 
[01:14:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:14:08] Build completed unsuccessfully in 0:04:20
[01:14:08] Build completed unsuccessfully in 0:04:20
[01:14:08] make: *** [check] Error 1
[01:14:08] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:027fb9c4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon Mar 11 10:47:14 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 0a99972 to 009631a Mar 14, 2019

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 009631a to 26cc324 Mar 15, 2019

@Zoxc Zoxc changed the title [WIP] Turn HIR indexing into a query Turn HIR indexing into a query Mar 15, 2019

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 26cc324 to 30e23f6 Mar 15, 2019

@Zoxc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

⌛️ Trying commit 30e23f6 with merge eb9092d...

bors added a commit that referenced this pull request Mar 15, 2019

Auto merge of #59064 - Zoxc:query-hir, r=<try>
Turn HIR indexing into a query

r? @michaelwoerister
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

☀️ Try build successful - checks-travis
Build commit: eb9092d

@Zoxc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

@rust-timer

This comment has been minimized.

Copy link

commented Mar 15, 2019

Success: Queued eb9092d with parent 70d1150, comparison URL.

@rust-timer

This comment has been minimized.

Copy link

commented Mar 15, 2019

Finished benchmarking try commit eb9092d

@Zoxc

This comment has been minimized.

Copy link
Contributor Author

commented Mar 16, 2019

Looks like caching the HIR query is effectively removes the performance penalty from making it a query. These results are pretty much identical to #59091. (compare with no caching in #57024).

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from b7f8f8c to 244f8e7 Mar 18, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

☔️ The latest upstream changes (presumably #56462) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch 2 times, most recently from ddfc6c3 to 25b731e Mar 19, 2019

@oli-obk
Copy link
Contributor

left a comment

You are suggesting that our eval_always queries are not true eval_always queries, can you explain/document this in more detail?

@@ -601,9 +601,13 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {
pub(super) fn ensure_query<Q: QueryDescription<'gcx>>(self, key: Q::Key) -> () {
let dep_node = Q::to_dep_node(self, &key);

// Ensuring an "input" or anonymous query makes no sense
if dep_node.kind.is_eval_always() {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

Why does ensuring an eval_always query make sense? No data should be cached by doing this, so at best we see some diagnostics?

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 19, 2019

Author Contributor

Ensuring queries just make sure the side effects of the query has been applied. This also applies to eval_always queries. However it doesn't make sense trying to mark them green with try_mark_green_and_read because we don't record dependencies for them, so they are handled separately here.

src/librustc/ty/context.rs Show resolved Hide resolved
src/librustc/ty/context.rs Outdated Show resolved Hide resolved

pub hir_defs: hir::map::Definitions,

hir_map: AtomicCell<Option<&'tcx hir_map::Map<'tcx>>>,

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

Can you use Once here?

@@ -1082,7 +1089,17 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> {

#[inline(always)]
pub fn hir(self) -> &'a hir_map::Map<'gcx> {
&self.hir_map
let value = self.hir_map.load();
if unlikely!(value.is_none()) {

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

This should be simplified significantly by the use of Once

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 19, 2019

Author Contributor

Once is slow, and the hir function is very hot.

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

ok, can you at least fold this into your AtomicCell (by passing a closure to some method) so the non-query code stays out of the query?

Since the AtomicCell is just used for this, maybe rename it to AtomicOnce and hide the Option from the use site.

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 19, 2019

Author Contributor

AtomicCell is a crossbeam-utils type. I can't modify it.

non-query code stays out of the query

Not sure what you mean here. This is just a regular function.

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

I just saw your version in rustc_datastructures, but I realize now that's just for nonparallel rustc.

This comment has been minimized.

Copy link
@oli-obk

oli-obk Mar 19, 2019

Contributor

Not sure what you mean here. This is just a regular function.

well it's like an emulated query. It would be a regular query just for the caching if it weren't so hot or had any arguments, right?

Which reminds me. Doesn't this being a memoization mean we'll not have an edge from queries calling hir to the hir_map query, except for the first query to call hir? Is that problematic?

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 19, 2019

Author Contributor

except for the first query to call hir?

It uses with_ignore so there won't be any edges even for the first one. Having edges to the real hir_map query would be bad, as it is no_hash and eval_always which makes it effectively always red (and everything which depends on it always execute).

Not adding edges here is fine since the HIR map adds edges when you use it to access things.

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 23, 2019

Author Contributor

I ending up using this pattern in a couple more places so I'm adding a AtomicOnce type for it.

@@ -388,10 +388,7 @@ impl DepGraph {
|_| None,
|data, key, fingerprint, _| {
let mut current = data.borrow_mut();
let krate_idx = current.node_to_node_index[
&DepNode::new_no_params(DepKind::Krate)

This comment has been minimized.

Copy link
@Zoxc

Zoxc Mar 19, 2019

Author Contributor

eval_always queries are hardcoded to depend on the entire HIR (Krate) here. I changed these to instead always execute instead of executing only when the HIR changes. Also see comments / perf on #59091

bors added a commit that referenced this pull request Mar 20, 2019

Auto merge of #59205 - Zoxc:query-hir-lowering, r=<try>
Turn HIR lowering into a query

Builds on #59064.

r? @michaelwoerister

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 25b731e to 9b45f91 Mar 23, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

☔️ The latest upstream changes (presumably #59433) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch 2 times, most recently from 2db0fbe to df25514 Mar 26, 2019

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 52404c3 to 71df4d2 Apr 13, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

How do we deal with a situation like this one where one member wants to work on something complicated with long-term effects but there is not enough bandwidth in the rest of the team to come up with (or at least think through and review) a proposed architecture/design?

Nominating for discussion in next week's compiler meeting

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

☔️ The latest upstream changes (presumably #59967) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 71df4d2 to 1135901 Apr 24, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

☔️ The latest upstream changes (presumably #60195) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 1135901 to 695af21 May 5, 2019

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

We discussed this in the triage meeting. There were a few points raised:

  • This PR itself is likely fairly simple and not worthy of meeting all by its lonesome
  • But many of us would like to see the overall direction sketched out
  • We'll need to find the right people to do the reviewing (@oli-obk seemed interested)
  • Niko (me!) feels like this ought to be a working group we can check in on periodically

So I'm removing nomination but in general we would like to hold up until we've had agreement on the overall "end-to-end" plan.

@bors

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

☔️ The latest upstream changes (presumably #60683) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Marking as waiting on the compiler team -- the overall plan needs to be sketched out and possibly a meeting scheduled to approve it for implementation. Once that happens, @Zoxc has a series of PRs which will need to be re-opened (#59404, #59338, #59282, and #59205) that depend on this one and each other.

@mark-i-m

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Has this been discussed at any point?

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from 695af21 to bb9129c Jun 12, 2019

@pnkfelix

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

triage meeting: we may want to dedicate a planning meeting to resolving the plan here

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

☔️ The latest upstream changes (presumably #61817) made this pull request unmergeable. Please resolve the merge conflicts.

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch 2 times, most recently from 8a6d2a5 to ebdd666 Jun 14, 2019

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from ebdd666 to d16a8f4 Jun 27, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Need to get 2,649 kB of archives.
After this operation, 7,904 kB of additional disk space will be used.
Ign:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
Ign:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
Err:3 http://security.ubuntu.com/ubuntu xenial-security/main amd64 gdb amd64 7.11.1-0ubuntu1~16.5
  Unable to connect to apt.cache.travis-ci.com:http:
Ign:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
Ign:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
Ign:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
Ign:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
Ign:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
Ign:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
Ign:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
Ign:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
Err:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace1 amd64 1.3.2-1
  Could not connect to apt.cache.travis-ci.com:80 (34.96.81.152), connection timed out
Err:2 http://archive.ubuntu.com/ubuntu xenial/main amd64 libbabeltrace-ctf1 amd64 1.3.2-1
  Unable to connect to apt.cache.travis-ci.com:http:
Fetched 2,526 kB in 30s (83.2 kB/s)
Fetched 2,526 kB in 30s (83.2 kB/s)
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/b/babeltrace/libbabeltrace1_1.3.2-1_amd64.deb  Could not connect to apt.cache.travis-ci.com:80 (34.96.81.152), connection timed out
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/b/babeltrace/libbabeltrace-ctf1_1.3.2-1_amd64.deb  Unable to connect to apt.cache.travis-ci.com:http:
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
travis_fold:start:apt-get.diagnostics
apt-get install failed
apt-get install failed
$ cat ${TRAVIS_HOME}/apt-get-update.log
Get:2 http://security.ubuntu.com/ubuntu xenial-security InRelease [109 kB]
Get:3 http://archive.ubuntu.com/ubuntu xenial-updates InRelease [109 kB]
Get:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease [107 kB]
Get:4 http://archive.ubuntu.com/ubuntu xenial-backports InRelease [107 kB]
Get:5 http://apt.postgresql.org/pub/repos/apt xenial-pgdg InRelease [51.5 kB]
Get:7 http://security.ubuntu.com/ubuntu xenial-security/restricted Sources [2,243 B]
Get:8 http://security.ubuntu.com/ubuntu xenial-security/universe Sources [131 kB]
Get:9 http://security.ubuntu.com/ubuntu xenial-security/multiverse Sources [3,517 B]
Get:10 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages [882 kB]
Get:10 http://security.ubuntu.com/ubuntu xenial-security/main amd64 Packages [882 kB]
Get:11 http://security.ubuntu.com/ubuntu xenial-security/main i386 Packages [722 kB]
Get:12 http://security.ubuntu.com/ubuntu xenial-security/main Translation-en [391 kB]
Get:13 http://security.ubuntu.com/ubuntu xenial-security/restricted amd64 Packages [12.7 kB]
Get:14 http://security.ubuntu.com/ubuntu xenial-security/restricted i386 Packages [12.7 kB]
Get:15 http://security.ubuntu.com/ubuntu xenial-security/restricted Translation-en [2,204 B]
Get:17 http://archive.ubuntu.com/ubuntu xenial/main Sources [1,103 kB]
Get:18 http://security.ubuntu.com/ubuntu xenial-security/universe i386 Packages [491 kB]
Get:19 http://archive.ubuntu.com/ubuntu xenial/restricted Sources [5,179 B]
Get:20 http://security.ubuntu.com/ubuntu xenial-security/universe Translation-en [243 kB]
Get:20 http://security.ubuntu.com/ubuntu xenial-security/universe Translation-en [243 kB]
Get:21 http://archive.ubuntu.com/ubuntu xenial/universe Sources [9,802 kB]
Get:22 http://security.ubuntu.com/ubuntu xenial-security/multiverse amd64 Packages [6,121 B]
Get:23 http://security.ubuntu.com/ubuntu xenial-security/multiverse i386 Packages [6,297 B]
Get:24 http://security.ubuntu.com/ubuntu xenial-security/multiverse Translation-en [2,699 B]
Get:26 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages [1,558 kB]
Get:26 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages [1,558 kB]
Get:27 http://apt.postgresql.org/pub/repos/apt xenial-pgdg/main amd64 Packages [206 kB]
Get:28 http://archive.ubuntu.com/ubuntu xenial/main i386 Packages [1,552 kB]
Get:29 http://apt.postgresql.org/pub/repos/apt xenial-pgdg/main i386 Packages [206 kB]
Get:30 http://archive.ubuntu.com/ubuntu xenial/main Translation-en [799 kB]
Get:32 http://archive.ubuntu.com/ubuntu xenial/restricted i386 Packages [14.5 kB]
Get:32 http://archive.ubuntu.com/ubuntu xenial/restricted i386 Packages [14.5 kB]
Get:33 http://archive.ubuntu.com/ubuntu xenial/restricted Translation-en [3,019 B]
Get:34 http://archive.ubuntu.com/ubuntu xenial/universe amd64 Packages [9,827 kB]
Get:35 http://archive.ubuntu.com/ubuntu xenial/universe i386 Packages [9,804 kB]
Get:36 http://archive.ubuntu.com/ubuntu xenial/universe Translation-en [6,256 kB]
Get:38 http://archive.ubuntu.com/ubuntu xenial/multiverse i386 Packages [172 kB]
Get:39 http://archive.ubuntu.com/ubuntu xenial/multiverse Translation-en [131 kB]
Get:40 http://archive.ubuntu.com/ubuntu xenial-updates/main Sources [427 kB]
Get:41 http://archive.ubuntu.com/ubuntu xenial-updates/restricted Sources [2,696 B]
Get:41 http://archive.ubuntu.com/ubuntu xenial-updates/restricted Sources [2,696 B]
Get:42 http://archive.ubuntu.com/ubuntu xenial-updates/universe Sources [324 kB]
Get:43 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse Sources [9,428 B]
Get:44 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages [1,265 kB]
Get:45 http://archive.ubuntu.com/ubuntu xenial-updates/main i386 Packages [1,078 kB]
Get:46 http://archive.ubuntu.com/ubuntu xenial-updates/main Translation-en [551 kB]
Get:47 http://archive.ubuntu.com/ubuntu xenial-updates/restricted amd64 Packages [13.1 kB]
Get:48 http://archive.ubuntu.com/ubuntu xenial-updates/restricted i386 Packages [13.1 kB]
Get:49 http://archive.ubuntu.com/ubuntu xenial-updates/restricted Translation-en [2,337 B]
Get:51 http://archive.ubuntu.com/ubuntu xenial-updates/universe i386 Packages [888 kB]
Get:52 http://archive.ubuntu.com/ubuntu xenial-updates/universe Translation-en [430 kB]
Get:53 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse amd64 Packages [19.1 kB]
Get:54 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse i386 Packages [17.9 kB]
Get:54 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse i386 Packages [17.9 kB]
Get:55 http://archive.ubuntu.com/ubuntu xenial-updates/multiverse Translation-en [8,978 B]
Get:56 http://archive.ubuntu.com/ubuntu xenial-backports/main Sources [5,073 B]
Get:57 http://archive.ubuntu.com/ubuntu xenial-backports/universe Sources [7,237 B]
Get:58 http://archive.ubuntu.com/ubuntu xenial-backports/main amd64 Packages [7,942 B]
Get:59 http://archive.ubuntu.com/ubuntu xenial-backports/main i386 Packages [7,942 B]
Get:60 http://archive.ubuntu.com/ubuntu xenial-backports/main Translation-en [4,571 B]
Get:61 http://archive.ubuntu.com/ubuntu xenial-backports/universe amd64 Packages [8,532 B]
Get:62 http://archive.ubuntu.com/ubuntu xenial-backports/universe i386 Packages [8,172 B]
Get:63 http://archive.ubuntu.com/ubuntu xenial-backports/universe Translation-en [4,275 B]
Reading package lists...
travis_fold:end:apt-get.diagnostics
travis_fold:end:apt-get.diagnostics
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install gdb" failed and exited with 100 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Zoxc Zoxc force-pushed the Zoxc:query-hir branch from d16a8f4 to d5fbdd2 Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.