Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jemalloc-sys to version 0.3.0 #59436

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Update jemalloc-sys to version 0.3.0 #59436

merged 2 commits into from
Mar 29, 2019

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented Mar 26, 2019 •
edited
Loading

This PR updates jemalloc-sys from 0.1.8 to 0.3.0.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2019
@Centril
Copy link
Contributor

Centril commented Mar 26, 2019

r? @alexcrichton

@rust-highfive

This comment has been minimized.

Sign in to view
@gnzlbg gnzlbg changed the title [WIP] Update jemalloc-sys to version 0.3.0 Update jemalloc-sys to version 0.3.0 Mar 26, 2019
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
travis_time:end:0ce03cd6:start=1553596305825421000,finish=1553596307117316000,duration=1291895000
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:02:54]       Memory: 8 GB
[00:02:54]       Boot ROM Version: VMW71.00V.7581552.B64.1801142334
[00:02:54]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:02:54]       SMC Version (system): 2.8f0
[00:02:54]       Serial Number (system): VMzqv7qsouG8
[00:02:54] 
[00:02:54] hw.ncpu: 4
[00:02:54] hw.byteorder: 1234
[00:02:54] hw.memsize: 8589934592
---
[02:52:03] travis_fold:end:stage2-test

[02:52:03] travis_time:end:stage2-test:start=1553607044430713000,finish=1553607045253496000,duration=822783000

The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@gnzlbg
Copy link
Contributor Author

gnzlbg commented Mar 26, 2019

Looks spurious (the raw logs suggests that everything passed), all other build jobs using jemalloc passed: https://travis-ci.com/rust-lang/rust/builds/105814811

@alexcrichton I think it makes sense to schedule a perf run before merging this.

@alexcrichton
Copy link
Member

@bors: try

@bors
Copy link
Contributor

bors commented Mar 26, 2019

⌛ Trying commit b73886d with merge 088c1067245ba3f1c5650596eae24d77c1c9ade3...

@bors
Copy link
Contributor

bors commented Mar 26, 2019

☀️ Try build successful - checks-travis
Build commit: 088c1067245ba3f1c5650596eae24d77c1c9ade3

@alexcrichton
Copy link
Member

@rust-timer build 088c1067245ba3f1c5650596eae24d77c1c9ade3

@rust-timer
Copy link
Collaborator

Success: Queued 088c1067245ba3f1c5650596eae24d77c1c9ade3 with parent 54479c6, comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 088c1067245ba3f1c5650596eae24d77c1c9ade3

@alexcrichton
Copy link
Member

Looks like basically minor amounts of noise across the board, thanks @gnzlbg!

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 26, 2019

📌 Commit b73886d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#59436 - gnzlbg:update_jemalloc, r=alexcrichton
ed73870 
Update jemalloc-sys to version 0.3.0

This PR updates jemalloc-sys from 0.1.8 to 0.3.0.
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#59436 - gnzlbg:update_jemalloc, r=alexcrichton
c22ed88 
Update jemalloc-sys to version 0.3.0

This PR updates jemalloc-sys from 0.1.8 to 0.3.0.
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Mar 28, 2019

Submodule updates => @bors p=1

@gnzlbg gnzlbg mentioned this pull request Mar 28, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019
@Centril
Rollup merge of rust-lang#59436 - gnzlbg:update_jemalloc, r=alexcrichton
8e0855b 
Update jemalloc-sys to version 0.3.0

This PR updates jemalloc-sys from 0.1.8 to 0.3.0.
@Centril Centril mentioned this pull request Mar 29, 2019
Merged
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of #59522 - Centril:rollup, r=Centril
d920dfc 
Rollup of 9 pull requests

Successful merges:

 - #59366 (Update books)
 - #59436 (Update jemalloc-sys to version 0.3.0)
 - #59454 (Update rustfmt to 1.2.0)
 - #59462 (Fix error in Rust 2018 + no_core environment)
 - #59467 (Better diagnostic for binary operation on BoxedValues)
 - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans)
 - #59480 (Update stdsimd)
 - #59486 (Visit `ImplItem` in `dead_code` lint)
 - #59510 (Rename `type_parameters` to `generics` and so on)

Failed merges:

 - #59516 (Update cargo)

r? @ghost
bors added a commit that referenced this pull request Mar 29, 2019
@bors
Auto merge of #59522 - Centril:rollup, r=Centril
e782d79 
Rollup of 9 pull requests

Successful merges:

 - #59366 (Update books)
 - #59436 (Update jemalloc-sys to version 0.3.0)
 - #59454 (Update rustfmt to 1.2.0)
 - #59462 (Fix error in Rust 2018 + no_core environment)
 - #59467 (Better diagnostic for binary operation on BoxedValues)
 - #59473 (Do not emit incorrect borrow suggestion involving macros and fix overlapping multiline spans)
 - #59480 (Update stdsimd)
 - #59486 (Visit `ImplItem` in `dead_code` lint)
 - #59510 (Rename `type_parameters` to `generics` and so on)

Failed merges:

 - #59516 (Update cargo)

r? @ghost
@bors bors merged commit b73886d into rust-lang:master Mar 29, 2019
@bors
Copy link
Contributor

bors commented Mar 29, 2019

⌛ Testing commit b73886d with merge e782d79...

@bors
Copy link
Contributor

bors commented Mar 29, 2019

☔ The latest upstream changes (presumably #59522) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gnzlbg @rust-highfive @Centril @alexcrichton @bors @rust-timer @nikomatsakis