[WIP] ELLIPSIS_INCLUSIVE_RANGE_PATTERNS -> Deny

[Centril]

Continuing on from #59482 and #59483 with the rust_2018_idioms group, we have ellipsis_inclusive_range_patterns to progress.

r? @oli-obk

[rust-highfive]

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:00980bcd:start=1553770370576068829,finish=1553770371562128940,duration=986060111
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:27:37]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:27:42]    Compiling compiler_builtins v0.1.5
[00:27:42]    Compiling cmake v0.1.33
[00:27:42]    Compiling backtrace-sys v0.1.27
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 3924 |             b'A'...b'Z' | b'a'...b'z' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42]      |
[00:27:42]      = note: #[deny(ellipsis_inclusive_range_patterns)] on by default
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 3924 |             b'A'...b'Z' | b'a'...b'z' => true,
[00:27:42]      |                               ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 3959 |             b'A'...b'Z' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 3994 |             b'a'...b'z' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4032 |             b'0'...b'9' | b'A'...b'Z' | b'a'...b'z' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4032 |             b'0'...b'9' | b'A'...b'Z' | b'a'...b'z' => true,
[00:27:42]      |                               ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4032 |             b'0'...b'9' | b'A'...b'Z' | b'a'...b'z' => true,
[00:27:42]      |                                             ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4067 |             b'0'...b'9' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4105 |             b'0'...b'9' | b'A'...b'F' | b'a'...b'f' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4105 |             b'0'...b'9' | b'A'...b'F' | b'a'...b'f' => true,
[00:27:42]      |                               ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4105 |             b'0'...b'9' | b'A'...b'F' | b'a'...b'f' => true,
[00:27:42]      |                                             ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4144 |             b'!'...b'/' | b':'...b'@' | b'['...b'`' | b'{'...b'~' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4144 |             b'!'...b'/' | b':'...b'@' | b'['...b'`' | b'{'...b'~' => true,
[00:27:42]      |                               ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4144 |             b'!'...b'/' | b':'...b'@' | b'['...b'`' | b'{'...b'~' => true,
[00:27:42]      |                                             ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4144 |             b'!'...b'/' | b':'...b'@' | b'['...b'`' | b'{'...b'~' => true,
[00:27:42]      |                                                           ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4179 |             b'!'...b'~' => true,
[00:27:42]      |                 ^^^ help: use `..=` for an inclusive range
[00:27:42] 
[00:27:42] error: `...` range patterns are deprecated
[00:27:42]      |
[00:27:42]      |
[00:27:42] 4268 |             b'\0'...b'\x1F' | b'\x7F' => true,
[00:27:42]      |                  ^^^ help: use `..=` for an inclusive range
[00:27:45]    Compiling std v0.0.0 (/checkout/src/libstd)
[00:27:45]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:27:46]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:27:46]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[Centril]

Justification: #28237 (comment)

[bors]

☔ The latest upstream changes (presumably #59684) made this pull request unmergeable. Please resolve the merge conflicts.

[Centril]

We discussed this on this weeks lang meeting; the general consensus was to crater and see how things fall out and move on from there.

[Dylan-DPC-zz]

ping from triage, closing this due to inactivity