Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stdsimd #59556

Merged
merged 1 commit into from
Apr 4, 2019
Merged

update stdsimd #59556

merged 1 commit into from
Apr 4, 2019

Conversation

RalfJung
Copy link
Member

Cc @gnzlbg

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2019
@gnzlbg
Copy link
Contributor

gnzlbg commented Apr 2, 2019

oh sorry, LGTM! This update should go smoothly since rust-lang/rust is tracking stdsimd very closely lately.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 3, 2019

So should I do r=gnzlbg then or how do you usually handle this?

@RalfJung
Copy link
Member Author

RalfJung commented Apr 4, 2019

Looks like there is precedence for that, so let's do that.

@bors r=gnzlbg

@bors
Copy link
Contributor

bors commented Apr 4, 2019

📌 Commit d8a6b63 has been approved by gnzlbg

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge of rust-lang#59556 - RalfJung:stdsimd, r=gnzlbg
c78055d 
update stdsimd

Cc @gnzlbg
@Centril Centril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge of rust-lang#59556 - RalfJung:stdsimd, r=gnzlbg
5fb8949 
update stdsimd

Cc @gnzlbg
@Centril Centril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge of rust-lang#59556 - RalfJung:stdsimd, r=gnzlbg
b3a6f8f 
update stdsimd

Cc @gnzlbg
@Centril Centril mentioned this pull request Apr 4, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 4, 2019
@Centril
Rollup merge of rust-lang#59556 - RalfJung:stdsimd, r=gnzlbg
9f8f891 
update stdsimd

Cc @gnzlbg
@Centril Centril mentioned this pull request Apr 4, 2019
Merged
bors added a commit that referenced this pull request Apr 4, 2019
@bors
Auto merge of #59695 - Centril:rollup-88qffc2, r=Centril
52980d0 
Rollup of 8 pull requests

Successful merges:

 - #59470 (Document std::fs::File close behavior ignoring errors)
 - #59555 (update miri)
 - #59556 (update stdsimd)
 - #59596 (Forward formatter settings to bounds of `Range<T>` in `fmt::Debug` impl)
 - #59639 (Never return uninhabited values at all)
 - #59671 (Make some of lexer's API private)
 - #59685 (Add description for -Os and -Oz in rustc.1)
 - #59686 (Temporarily disable stack probing for gnux32.)

Failed merges:

r? @ghost
@bors bors merged commit d8a6b63 into rust-lang:master Apr 4, 2019
@bors
Copy link
Contributor

bors commented Apr 4, 2019

⌛ Testing commit d8a6b63 with merge 52980d0...

@RalfJung RalfJung mentioned this pull request Apr 12, 2019
Merged
@bjorn3 bjorn3 mentioned this pull request Apr 13, 2019
Merged
@bjorn3
Copy link
Member

bjorn3 commented Apr 13, 2019

Why is bors testing this and #59671? It is already merged.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 13, 2019 •
edited
Loading

Uh... bors seems very confused.

@bors r- retry

Cc @rust-lang/infra
Bors says on https://buildbot2.rust-lang.org/homu/queue/rust that it is testing this one (and the other one in parallel?!?), but looking at https://travis-ci.com/rust-lang/rust/ it is not actually doing anything.
This is one of those PRs that was rolled up and then immediately next in the queue. So bors started building it and then aborted (?) because GH updated the PR status to "merged". But it seems bors didn't really drop it.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 13, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 13, 2019
@pietroalbini
Copy link
Member

Heh, weird things happen when bors is redeployed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@RalfJung @rust-highfive @gnzlbg @bors @bjorn3 @pietroalbini @nikomatsakis