Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable llvm/debug assertions on x86_64-mingw #59638

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

alexcrichton
Copy link
Member

Tracked at #59637 for re-enabling this commit disables assertions to
hopefully bring the runtime for this builder under control.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 2, 2019
@alexcrichton
Copy link
Member Author

r? @pietroalbini

@pietroalbini
Copy link
Member

Looking at a random build x86_64-msvc also takes more than 3 hours, and while it's average is lower it's still high. Do we also want to disable some assertions there?

Tracked at rust-lang#59637 for re-enabling this commit disables assertions to
hopefully bring the runtime for this builder under control.
@alexcrichton
Copy link
Member Author

Sure yeah, I've gone ahead and done it for the three currently slowest builders

@pietroalbini
Copy link
Member

@bors r+ p=100

@bors
Copy link
Contributor

bors commented Apr 2, 2019

📌 Commit 1334314 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2019
@bors
Copy link
Contributor

bors commented Apr 2, 2019

⌛ Testing commit 1334314 with merge 1f1cd56ba2360cce4368f54b604893ad92dd8f12...

@bors
Copy link
Contributor

bors commented Apr 2, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 2, 2019
@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:50:04] test string::test_str_truncate ... ok
[01:50:04] test string::test_str_truncate_invalid_len ... ok
[01:50:04] test string::test_str_truncate_split_codepoint ... ok
[01:50:04] test string::test_split_off_mid_char ... ok
[01:50:04] died due to signal 11
[01:50:04] 
[01:50:04] 
[01:50:04] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:50:04] expected success, got: exit code: 3
---
travis_time:end:30e7f201:start=1554240953811196039,finish=1554240953820050573,duration=8854534
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0104356e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:055567c5
travis_time:start:055567c5
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0870cc10
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member Author

@bors: retry

#55861

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2019
bors added a commit that referenced this pull request Apr 2, 2019
ci: Disable llvm/debug assertions on x86_64-mingw

Tracked at #59637 for re-enabling this commit disables assertions to
hopefully bring the runtime for this builder under control.
@bors
Copy link
Contributor

bors commented Apr 2, 2019

⌛ Testing commit 1334314 with merge 7641873...

@bors
Copy link
Contributor

bors commented Apr 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 7641873 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 3, 2019
@bors bors merged commit 1334314 into rust-lang:master Apr 3, 2019
@alexcrichton alexcrichton deleted the less-assertions branch April 5, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants