Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy: ensure lang features are sorted by since #60373

Merged
merged 9 commits into from
May 3, 2019
Merged

Tidy: ensure lang features are sorted by since #60373

merged 9 commits into from
May 3, 2019

Commits on May 2, 2019

  1. Make find_attr_val a little bit more precise 

    `find_attr_val(&line, "since")` returns `Some(", issue = ")` when
`line` is set to the following line:

```
[unstable(feature = "checked_duration_since", issue = "58402")]
```

Make `find_attr_val` use regex that is a little bit more
precise (requires `=` after key name).

It still does not handle all cases (e.g., extra leading chars in key
name, or escaped quotes in value), but is good enough for now.
    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    8b82f68 View commit details
    Browse the repository at this point in the history

  2. Assign group and parse since for Feature

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    b7f55ca View commit details
    Browse the repository at this point in the history

  3. Ensure language features in group are sorted by since

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    d5ba6d4 View commit details
    Browse the repository at this point in the history

  4. Address review comments

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    d54477e View commit details
    Browse the repository at this point in the history

  5. Make tidy::version::Version a [u32; 3]

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    90d3fa2 View commit details
    Browse the repository at this point in the history

  6. Group and sort feature_gate.rs

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    3b4fe7e View commit details
    Browse the repository at this point in the history

  7. Rework Version::parse to avoid extra allocations

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    c120fd8 View commit details
    Browse the repository at this point in the history

  8. Make in_feature_group a simple bool flag

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    4bcc828 View commit details
    Browse the repository at this point in the history

  9. Make tidy::version::Version copy

    @rasendubi
    rasendubi committed May 2, 2019
    Configuration menu
    Copy the full SHA
    201f14b View commit details
    Browse the repository at this point in the history