Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce sorting of accepted and removed features #60531

Merged
merged 3 commits into from
May 7, 2019
Merged

Enforce sorting of accepted and removed features #60531

merged 3 commits into from
May 7, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 4, 2019

Fixes #60361 with mechanism introduced in #60373.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 6, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2019

📌 Commit 639e452 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2019
@bors
Copy link
Contributor

bors commented May 7, 2019

⌛ Testing commit 639e452 with merge eeedd3a...

bors added a commit that referenced this pull request May 7, 2019
@bors
Auto merge of #60531 - Centril:sort-features, r=oli-obk
eeedd3a 
Enforce sorting of accepted and removed features

Fixes #60361 with mechanism introduced in #60373.

r? @oli-obk
@bors
Copy link
Contributor

bors commented May 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing eeedd3a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2019
@bors bors merged commit 639e452 into rust-lang:master May 7, 2019
@Centril Centril deleted the sort-features branch May 7, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tidy: Enforce that groups in declare_feature! are sorted by version number
4 participants
@Centril @rust-highfive @oli-obk @bors