Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update clippy from 2ed0b3bf to fc96aa03 #60538

Merged
merged 1 commit into from
May 4, 2019
Merged

submodules: update clippy from 2ed0b3bf to fc96aa03 #60538

merged 1 commit into from
May 4, 2019

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented May 4, 2019 •
edited
Loading

Changes:

Rustup to rustc 1.36.0-nightly (13fde05b1 2019-05-03)
Fix link in into_iter_on_array documentation
remove function body from "too many args" span
check closure arguments before use it
format code
fix suggestion for search_is_some
fix suggestion for search_is_some naively
change |&x| to |x| in stderr file
cargo fmt
useless_let_if_seq handle interior mutability

Fixes #60534

@matthiaskrgr
submodules: update clippy from 2ed0b3b to fc96aa0
9bd6a7a 
Changes:
````
Rustup to rustc 1.36.0-nightly (13fde05 2019-05-03)
Fix link in into_iter_on_array documentation
remove function body from "too many args" span
check closure arguments before use it
format code
fix suggestion for search_is_some
fix suggestion for search_is_some naively
change |&x| to |x| in stderr file
cargo fmt
useless_let_if_seq handle interior mutability
````
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2019
@matthiaskrgr
Copy link
Member Author

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned alexcrichton May 4, 2019
@eddyb
Copy link
Member

eddyb commented May 4, 2019

@bors r+

@bors
Copy link
Contributor

bors commented May 4, 2019

📌 Commit 9bd6a7a has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2019
@Xanewok
Copy link
Member

Xanewok commented May 4, 2019

@bors p=2

@bors
Copy link
Contributor

bors commented May 4, 2019

⌛ Testing commit 9bd6a7a with merge 8dd4aae...

bors added a commit that referenced this pull request May 4, 2019
@bors
Auto merge of #60538 - matthiaskrgr:submodule_upd, r=eddyb
8dd4aae 
submodules: update clippy from 2ed0b3b to fc96aa0

Changes:
````
Rustup to rustc 1.36.0-nightly (13fde05 2019-05-03)
Fix link in into_iter_on_array documentation
remove function body from "too many args" span
check closure arguments before use it
format code
fix suggestion for search_is_some
fix suggestion for search_is_some naively
change |&x| to |x| in stderr file
cargo fmt
useless_let_if_seq handle interior mutability
````
Fixes #60534
@bors
Copy link
Contributor

bors commented May 4, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 8dd4aae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 4, 2019
@bors bors merged commit 9bd6a7a into rust-lang:master May 4, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #60538!

Tested on commit 8dd4aae.
Direct link to PR: #60538

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 4, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#60538!
1bb0b25 
Tested on commit rust-lang/rust@8dd4aae.
Direct link to PR: <rust-lang/rust#60538>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-fail (cc @Xanewok, @rust-lang/infra).
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch May 8, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#60462
7 participants
@matthiaskrgr @rust-highfive @eddyb @bors @Xanewok @alexcrichton @oli-obk