Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for building raw slices to libcore #60667

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@oli-obk
Copy link
Contributor

commented May 9, 2019

implement #36925

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0aac4648:start=1557402614815030543,finish=1557402709621061353,duration=94806030810
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:20:40] 
[01:20:40] running 143 tests
[01:20:42] i..iii.....iii..iiii.....i......................i..i.................i.....i..........ii..i.i..i.ii. 100/143
[01:20:44] test result: ok. 113 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:20:44] 
[01:20:44]  finished in 4.653
[01:20:44] travis_fold:end:test_codegen
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:20:46] 
[01:20:46] running 9 tests
[01:20:46] iiiiiiiii
[01:20:46] 
[01:20:46]  finished in 0.150
[01:20:46] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:21:02] 
[01:21:02] running 122 tests
[01:21:27] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:21:32] .i.i......iii.i.....ii
[01:21:32] 
[01:21:32]  finished in 29.882
[01:21:32] travis_fold:end:test_debuginfo

---
[01:31:51] 
[01:31:51] To learn more, run the command again with --verbose.
[01:31:51] 
[01:31:51] 
[01:31:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
[01:31:51] 
[01:31:51] 
[01:31:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:31:51] Build completed unsuccessfully in 0:22:52
[01:31:51] Build completed unsuccessfully in 0:22:52
[01:31:51] make: *** [check] Error 1
[01:31:51] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:06db6ef0
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Thu May  9 13:23:50 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk oli-obk force-pushed the oli-obk:raw_from_raw_parts branch from 412b3b1 to f5236b7 May 9, 2019

Show resolved Hide resolved src/libcore/ptr.rs Outdated
@petertodd

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

Show resolved Hide resolved src/libcore/ptr.rs Outdated
Show resolved Hide resolved src/libcore/ptr.rs Outdated
Show resolved Hide resolved src/libcore/ptr.rs Outdated
Show resolved Hide resolved src/libcore/ptr.rs Outdated

@oli-obk oli-obk force-pushed the oli-obk:raw_from_raw_parts branch from 7979709 to adaa377 May 24, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

☔️ The latest upstream changes (presumably #61274) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Show resolved Hide resolved .gitignore Outdated
Show resolved Hide resolved src/libcore/ptr.rs Outdated
@sfackler

This comment has been minimized.

Copy link
Member

commented May 30, 2019

LGTM other than the one nit.

@oli-obk oli-obk force-pushed the oli-obk:raw_from_raw_parts branch from adaa377 to 5b73c70 Jun 19, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0f045a1a:start=1560928500740750172,finish=1560928501881683377,duration=1140933205
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:04:45]    Compiling cc v1.0.35
[00:04:45]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:04:45]    Compiling libc v0.2.54
[00:04:45]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:04:45] error[E0584]: file for module `ptr` found at both ptr.rs and ptr/mod.rs
[00:04:45]     |
[00:04:45] 176 | pub mod ptr;
[00:04:45]     |         ^^^
[00:04:45]     |
[00:04:45]     |
[00:04:45]     = help: delete or rename one of them to remove the ambiguity
[00:04:45] error: aborting due to previous error
[00:04:45] 
[00:04:45] error: Could not compile `core`.
[00:04:45] warning: build failed, waiting for other jobs to finish...

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk oli-obk force-pushed the oli-obk:raw_from_raw_parts branch from 5b73c70 to 8b21b07 Jun 19, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@bors r=sfackler

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

📌 Commit 8b21b07 has been approved by sfackler

Centril added a commit to Centril/rust that referenced this pull request Jun 19, 2019

Rollup merge of rust-lang#60667 - oli-obk:raw_from_raw_parts, r=sfackler
 Add functions for building raw slices to libcore

implement rust-lang#36925

bors added a commit that referenced this pull request Jun 19, 2019

Auto merge of #61957 - Centril:rollup-ljlj6vt, r=Centril
Rollup of 3 pull requests

Successful merges:

 - #60667 ( Add functions for building raw slices to libcore )
 - #61547 (Support `cfg` and `cfg_attr` on generic parameters)
 - #61940 (Make Place::ty iterate)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request Jun 19, 2019

Rollup merge of rust-lang#60667 - oli-obk:raw_from_raw_parts, r=sfackler
 Add functions for building raw slices to libcore

implement rust-lang#36925

bors added a commit that referenced this pull request Jun 19, 2019

Auto merge of #61962 - Centril:rollup-y6sg1zw, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #60667 ( Add functions for building raw slices to libcore )
 - #61547 (Support `cfg` and `cfg_attr` on generic parameters)
 - #61861 (Update rustfmt and rls)
 - #61940 (Make Place::ty iterate)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request Jun 19, 2019

Auto merge of #61962 - Centril:rollup-y6sg1zw, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #60667 ( Add functions for building raw slices to libcore )
 - #61547 (Support `cfg` and `cfg_attr` on generic parameters)
 - #61861 (Update rustfmt and rls)
 - #61940 (Make Place::ty iterate)

Failed merges:

r? @ghost

@bors bors merged commit 8b21b07 into rust-lang:master Jun 19, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
pr Build #20190619.10 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.