add impl_trait_in_bindings to INCOMPLETE_FEATURES #60770

Pulkit07 · 2019-05-12T22:04:49Z

impl_trait_in_bindings is not yet complete and can lead to compiler crashes.

Fixes #60764.

rust-highfive · 2019-05-12T22:04:53Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

Centril · 2019-05-12T22:42:02Z

r? @Centril

@bors rollup

r=me with green travis.

rust-highfive · 2019-05-12T23:19:55Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:10ef82a4:start=1557698748577390019,finish=1557698749338352377,duration=760962358
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:11:12] .................................................................................................... 1400/5524
[01:11:15] .................................................................................................... 1500/5524
[01:11:17] .................................................................................................... 1600/5524
[01:11:21] ...........................i........................................................................ 1700/5524
[01:11:24] .........................................................................FF......................... 1800/5524
[01:11:32] .................................................................................................... 2000/5524
[01:11:35] ......................................................................i............................. 2100/5524
[01:11:39] .................................................................................................... 2200/5524
[01:11:43] .................................................................................................... 2300/5524
---
[01:13:48] failures:
[01:13:48] 
[01:13:48] ---- [ui] ui/impl-trait/bindings.rs stdout ----
[01:13:48] 
[01:13:48] error: /checkout/src/test/ui/impl-trait/bindings.rs:1: unexpected warning: '1:12: 1:34: the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash'
[01:13:48] error: 1 unexpected errors found, 0 expected errors not found
[01:13:48] status: exit code: 1
[01:13:48] status: exit code: 1
[01:13:48] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/bindings.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/bindings" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/bindings/auxiliary" "-A" "unused"
[01:13:48]     Error {
[01:13:48]         line_num: 1,
[01:13:48]         kind: Some(
[01:13:48]             Warning,
[01:13:48]             Warning,
[01:13:48]         ),
[01:13:48]         msg: "1:12: 1:34: the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash",
[01:13:48] ]
[01:13:48] 
[01:13:48] thread '[ui] ui/impl-trait/bindings.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1405:13
[01:13:48] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:13:48] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:13:48] 
[01:13:48] ---- [ui] ui/impl-trait/bindings-opaque.rs stdout ----
[01:13:48] 
[01:13:48] error: /checkout/src/test/ui/impl-trait/bindings-opaque.rs:1: unexpected warning: '1:12: 1:34: the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash'
[01:13:48] error: 1 unexpected errors found, 0 expected errors not found
[01:13:48] status: exit code: 1
[01:13:48] status: exit code: 1
[01:13:48] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/impl-trait/bindings-opaque.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/bindings-opaque" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/impl-trait/bindings-opaque/auxiliary" "-A" "unused"
[01:13:48]     Error {
[01:13:48]         line_num: 1,
[01:13:48]         kind: Some(
[01:13:48]             Warning,
[01:13:48]             Warning,
[01:13:48]         ),
[01:13:48]         msg: "1:12: 1:34: the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash",
[01:13:48] ]
[01:13:48] 
[01:13:48] thread '[ui] ui/impl-trait/bindings-opaque.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1405:13
[01:13:48] 
---
[01:13:48] 
[01:13:48] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:512:22
[01:13:48] 
[01:13:48] 
[01:13:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:13:48] 
[01:13:48] 
[01:13:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:13:48] Build completed unsuccessfully in 0:04:45
[01:13:48] Build completed unsuccessfully in 0:04:45
[01:13:48] make: *** [check] Error 1
[01:13:48] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1ec61fa4
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun May 12 23:19:50 UTC 2019
---
travis_time:end:247a5d37:start=1557703191514048869,finish=1557703191518750707,duration=4701838
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2c6252b9
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1db4fed1
travis_time:start:1db4fed1
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2a3d9bd8
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2019-05-12T23:40:18Z

You'll need to add:

//~^ WARN the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash

under any #![feature(impl_trait_in_bindings)] line in the tests.

bors · 2019-05-13T03:25:52Z

☔ The latest upstream changes (presumably #60630) made this pull request unmergeable. Please resolve the merge conflicts.

varkor · 2019-05-13T12:34:49Z

--bless updates the test output files, but you need to update the test .rs files too with those comments, so the errors/warnings match the output.

Pulkit07 · 2019-05-13T12:41:45Z

--bless updates the test output files, but you need to update the test .rs files too with those comments, so the errors/warnings match the output.

You are very fast. I commented and later realized that and deleted the comment. Thanks!

rust-highfive · 2019-05-13T15:16:07Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1c6cd95c:start=1557755714240176083,finish=1557755715210255905,duration=970079822
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[01:14:55] .................................................................................................... 600/2960
[01:15:10] .................................................................................................... 700/2960
[01:15:22] .................................................................................................... 800/2960
[01:15:31] .................................................................................................... 900/2960
[01:15:46] .......................................F............................................................ 1000/2960
[01:16:09] .................................................................................................... 1200/2960
[01:16:19] .................................................................................................... 1300/2960
[01:16:31] ...........................ii....................................................................... 1400/2960
[01:16:43] .................................................................................................... 1500/2960
---
[01:20:10] .................................................................................................... 2800/2960
[01:20:20] .................................................................................................... 2900/2960
g output.
[01:20:30] status: exit code: 0
[01:20:30] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/run-pass/impl-trait-in-bindings.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/impl-trait-in-bindings/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass/impl-trait-in-bindings/auxiliary"
[01:20:30] ------------------------------------------
[01:20:30] 
[01:20:30] ------------------------------------------
[01:20:30] stderr:
[01:20:30] stderr:
[01:20:30] ------------------------------------------
[01:20:30] warning: the feature `impl_trait_in_bindings` is incomplete and may cause the compiler to crash
[01:20:30]    |
[01:20:30] LL | #![feature(impl_trait_in_bindings)]
[01:20:30]    |            ^^^^^^^^^^^^^^^^^^^^^^
[01:20:30] 
---
[01:20:30] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:512:22
[01:20:30] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:20:30] 
[01:20:30] 
[01:20:30] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-pass" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-pass" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-pass" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:20:30] 
[01:20:30] 
[01:20:30] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:20:30] Build completed unsuccessfully in 0:11:27
[01:20:30] Build completed unsuccessfully in 0:11:27
[01:20:30] Makefile:48: recipe for target 'check' failed
[01:20:30] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0e6a085e
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon May 13 15:15:59 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

impl_trait_in_bindings is not yet complete and can lead to compiler crashes. Fixes rust-lang#60764.

Centril · 2019-05-13T18:20:04Z

@bors r+ rollup

bors · 2019-05-13T18:20:05Z

📌 Commit ea956e3 has been approved by Centril

bors · 2019-05-13T18:20:06Z

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

add impl_trait_in_bindings to INCOMPLETE_FEATURES impl_trait_in_bindings is not yet complete and can lead to compiler crashes. Fixes rust-lang#60764.

@ghost

Rollup of 5 pull requests Successful merges: - #60176 (Explain error when yielding a reference to a local variable) - #60201 (coretest: Downgrade deny to warn) - #60562 (Add #[doc(hidden)] attribute on compiler generated module.) - #60710 (Use `delay_span_bug` for error cases when checking `AnonConst` parent) - #60770 (add impl_trait_in_bindings to INCOMPLETE_FEATURES) Failed merges: r? @ghost

rust-highfive assigned eddyb May 12, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2019

rust-highfive assigned Centril and unassigned eddyb May 12, 2019

Pulkit07 force-pushed the issue60764 branch from 64a72cd to 68b7784 Compare May 13, 2019 13:54

add impl_trait_in_bindings to INCOMPLETE_FEATURES

ea956e3

impl_trait_in_bindings is not yet complete and can lead to compiler crashes. Fixes rust-lang#60764.

Pulkit07 force-pushed the issue60764 branch from 68b7784 to ea956e3 Compare May 13, 2019 15:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2019

Centril mentioned this pull request May 13, 2019

Rollup of 5 pull requests #60794

Merged

bors merged commit ea956e3 into rust-lang:master May 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add impl_trait_in_bindings to INCOMPLETE_FEATURES #60770

add impl_trait_in_bindings to INCOMPLETE_FEATURES #60770

Pulkit07 commented May 12, 2019

rust-highfive commented May 12, 2019

Centril commented May 12, 2019

rust-highfive commented May 12, 2019

varkor commented May 12, 2019

bors commented May 13, 2019

varkor commented May 13, 2019

Pulkit07 commented May 13, 2019

rust-highfive commented May 13, 2019

Centril commented May 13, 2019

bors commented May 13, 2019

bors commented May 13, 2019

add impl_trait_in_bindings to INCOMPLETE_FEATURES #60770

add impl_trait_in_bindings to INCOMPLETE_FEATURES #60770

Conversation

Pulkit07 commented May 12, 2019

rust-highfive commented May 12, 2019

Centril commented May 12, 2019

rust-highfive commented May 12, 2019

varkor commented May 12, 2019

bors commented May 13, 2019

varkor commented May 13, 2019

Pulkit07 commented May 13, 2019

rust-highfive commented May 13, 2019

Centril commented May 13, 2019

bors commented May 13, 2019

bors commented May 13, 2019