Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse alternative incorrect uses of await and recover #60873

Merged
merged 10 commits into from
May 17, 2019
Merged

Parse alternative incorrect uses of await and recover #60873

merged 10 commits into from
May 17, 2019
+690 −288

Commits on May 16, 2019

  1. Parse alternative incorrect uses of await and recover

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    d763faf View commit details
    Browse the repository at this point in the history

  2. Split parser logic to its own method

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    ee02661 View commit details
    Browse the repository at this point in the history

  3. Simplify span usage for incorrect await

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    01c6689 View commit details
    Browse the repository at this point in the history

  4. tidy fix

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    91c36c4 View commit details
    Browse the repository at this point in the history

  5. Point at enclosing fn/closure when it's not async

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    c616605 View commit details
    Browse the repository at this point in the history

  6. readd match await test case

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    0183a57 View commit details
    Browse the repository at this point in the history

  7. Review comments 

    - Change wording of suggestion
- Move recovery logic to `diagnostics.rs`
- Reduce ammount of code duplication
    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    b9d6fe3 View commit details
    Browse the repository at this point in the history

  8. Fix span for await macro call

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    27a2881 View commit details
    Browse the repository at this point in the history

  9. Move some parser recovery methods to diagnostics

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    4117c6d View commit details
    Browse the repository at this point in the history

  10. review comments

    @estebank
    estebank committed May 16, 2019
    Configuration menu
    Copy the full SHA
    c084d0e View commit details
    Browse the repository at this point in the history