Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc_errors: Remove unused annotation style `OldSchoolNoteText` #61073

Merged
merged 1 commit into from May 23, 2019

Conversation

@phansch
Copy link
Member

commented May 23, 2019

I could not find any references to it and the snippet module does not
seem to be exported publicly, so I think it can be safely removed.

This was originally removed in 17bd76a and I'm not sure why it is still there.

librustc_errors: Remove unused annotation style `OldSchoolNoteText`
I could not find any references to it and the `snippet` module does not
seem to be exported publicly, so I think it can be safely removed.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@matthewjasper

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

@bors r+ rollup=always

@bors

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

📌 Commit 5ed4237 has been approved by matthewjasper

Centril added a commit to Centril/rust that referenced this pull request May 23, 2019
Rollup merge of rust-lang#61073 - phansch:remove_unused_annotation_st…
…yle, r=matthewjasper

librustc_errors: Remove unused annotation style `OldSchoolNoteText`

I could not find any references to it and the `snippet` module does not
seem to be exported publicly, so I think it can be safely removed.

This was originally removed in 17bd76a and I'm not sure why it is still there.
bors added a commit that referenced this pull request May 23, 2019
Auto merge of #61075 - Centril:rollup-1ugmcqu, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60981 (Bump compiler-builtins to 0.1.15)
 - #61014 (Make -Zemit-artifact-notifications also emit the artifact type)
 - #61043 (Disable LLVM/debug assertions in gnu-full-bootstrap)
 - #61046 (Fix ICE with inconsistent macro matchers)
 - #61055 (Solaris CI: Build with dilos2 stable)
 - #61057 (Revert "Add implementations of last in terms of next_back on a bunch of DoubleEndedIterators.")
 - #61073 (librustc_errors: Remove unused annotation style `OldSchoolNoteText`)

Failed merges:

r? @ghost

@bors bors merged commit 5ed4237 into rust-lang:master May 23, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@phansch phansch deleted the phansch:remove_unused_annotation_style branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.