Rollup of 5 pull requests #61153
Closed
Rollup of 5 pull requests #61153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an easy-to-overlook warning otherwise.
…ng-based run-make tests to use PGO.
This function is hot for `keccak`.
Most involving `Symbol::intern` on string literals.
Because this function is hot. Also remove the dead `ty_option` function.
The commit should have changed comments as well.
At the time of writting, it passes the tidy and check tool.
Revisions asked by eddyb :
- Renamed of all the occurences of {visit/super}_mir
- Renamed test structures `CachedMir` to `Cached`
Fixing the missing import on `AggregateKind`
It's just a waste of memory. This also gets rid of the special case for "".
Changes the type `mir::Mir` into `mir::Body` Fixes part 1 of rust-lang#60229 (previously attempted in rust-lang#60242). I stumbled upon the issue and it seems that the previous attempt at solving it was not merged. This is a second try more up-to-date. The commit should have changed comments as well. At the time of writting, it passes the tidy and check tool.
…ning, r=petrochenkov Avoid more symbol interning r? @petrochenkov
…lexcrichton PGO - Add a smoketest for combining PGO with cross-language LTO. This PR - Adds a test making sure that PGO can be combined with cross-language LTO. - Does a little cleanup on how the `pgo-use` flag is handled internally. - Makes the compiler error if the `pgo-use` file given to `rustc` doesn't actually exist. LLVM only gives a warning and then just doesn't do PGO. Clang, on the other hand, does give an error in this case. - Makes the build system also build `compiler-rt` when building LLDB. This way the Clang compiler that we get from building LLDB can perform PGO, which is something that the new test case wants to do. CI compile times shouldn't be affected too much.
…henkov Don't arena-allocate static symbols. It's just a waste of memory. This also gets rid of the special case for "". r? @petrochenkov
Ship profiler with windows-gnu Fixes rust-lang#49409 I don't know if we can enable it for testing, windows-gnu jobs are already taking too long: rust-lang#59637. r? @michaelwoerister P.S. I have tested only x86_64 build.
|
@bors r+ p=5 rollup=never |
|
📌 Commit c907f03 has been approved by |
bors
added
the
S-waiting-on-bors
|
That's a lot of rollup PRs 🎢 |
|
Yep 🚀 |
|
Unfortunately I have to build LLVM locally for all of them, a bummer. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 25, 2019
Rollup of 5 pull requests Successful merges: - rust-lang#60928 (Changes the type `mir::Mir` into `mir::Body`) - rust-lang#61035 (Avoid more symbol interning) - rust-lang#61036 (PGO - Add a smoketest for combining PGO with cross-language LTO.) - rust-lang#61077 (Don't arena-allocate static symbols.) - rust-lang#61080 (Ship profiler with windows-gnu) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #60441) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
mir::Mirintomir::Body#60928 (Changes the typemir::Mirintomir::Body)Failed merges:
r? @ghost