Only look for main at the crate level
#6119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't have anything to do with resolve and the logic will likely get more involved in the future, after rust-lang#4433
|
OK, @ILyoan I think this is fixed for Android. Can you re-review? |
|
@ILyoan +1 |
|
Failed on two compile-fail test cases.
expecting other error messages, but got 'main function not found' otherwise it's good. |
I don't understand what this logic is doing
bors
added a commit
that referenced
this pull request
May 8, 2013
r? @ILyoan This pulls all the logic for discovering the crate entry point into a new pass (out of resolve and typeck), then changes it so that main is only looked for at the crate level (`#[main]` can still be used anywhere). I don't understand the special android logic here and worry that I may have broken it.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 20, 2020
Add a case to `lint_search_is_some` to handle searching strings Fixes: rust-lang#6010 This adds a lint which recommends using `contains()` instead of `find()` followed by `is_some()` on strings as suggested in rust-lang#6010. This was added as an additional case to https://github.com/rust-lang/rust-clippy/blob/5af88e3c2d8cc4fb74a0e455381669930ee3a31a/clippy_lints/src/methods/mod.rs#L3037 I would really appreciate any comments/suggestions for my code! changelog: Added case to `lint_search_is_some` to handle searching strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ILyoan
This pulls all the logic for discovering the crate entry point into a new pass (out of resolve and typeck), then changes it so that main is only looked for at the crate level (
#[main]can still be used anywhere).I don't understand the special android logic here and worry that I may have broken it.