Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of special const intrinsic query in favour of `const_eval` #61626

Open
wants to merge 8 commits into
base: master
from

Conversation

@oli-obk
Copy link
Contributor

commented Jun 7, 2019

r? @eddyb

@eddyb

eddyb approved these changes Jun 10, 2019

Copy link
Member

left a comment

r=me with comment added (or moving more intrinsics)

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

☔️ The latest upstream changes (presumably #61722) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk oli-obk force-pushed the oli-obk:const_eval_intrinsics branch from 34daa8f to 26c486f Jun 19, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

I ported the rest of the zero arg intrinsics and thus also deduplicated their implementation between const eval and codegen

@oli-obk oli-obk requested a review from eddyb Jun 19, 2019

@eddyb

eddyb approved these changes Jun 20, 2019

Copy link
Member

left a comment

r=me

tcx.const_eval_raw(key).and_then(|val| {
validate_and_turn_into_const(tcx, val, key)
})
}

fn eval_intrinsic<'tcx>(

This comment has been minimized.

Copy link
@eddyb

eddyb Jun 20, 2019

Member

Can you rename this to eval_nulary_intrinsic?

@mark-i-m mark-i-m referenced this pull request Jun 21, 2019

Merged

Debugging support in rustc #316

6 of 6 tasks complete
@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

@bors r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

📌 Commit f361410 has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

⌛️ Testing commit f361410 with merge 43e46ab...

bors added a commit that referenced this pull request Jun 21, 2019

Auto merge of #61626 - oli-obk:const_eval_intrinsics, r=eddyb
Get rid of special const intrinsic query in favour of `const_eval`

r? @eddyb

@bors bors referenced this pull request Jun 21, 2019

Merged

More NodeId pruning #61984

@bors

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

💔 Test failed - checks-travis

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

The job dist-i586-gnu-i586-i686-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:53:20] 
[00:53:20] ---- [ui] ui/issues/issue-44415.rs stdout ----
[00:53:20] diff of stderr:
[00:53:20] 
[00:53:20] 10 LL |     bytes: [u8; unsafe { intrinsics::size_of::<Foo>() }],
[00:53:20] 11    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:53:20] 12 note: ...which requires const-evaluating + checking `std::intrinsics::size_of`...
[00:53:20] -   --> $SRC_DIR/libcore/intrinsics.rs:LL:COL
[00:53:20] -    |
[00:53:20] - LL |     pub fn size_of<T>() -> usize;
[00:53:20] -    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:53:20] 17 note: ...which requires const-evaluating + checking `std::intrinsics::size_of`...
[00:53:20] -   --> $SRC_DIR/libcore/intrinsics.rs:LL:COL
[00:53:20] -    |
[00:53:20] - LL |     pub fn size_of<T>() -> usize;
[00:53:20] -    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:53:20] 22    = note: ...which requires computing layout of `Foo`...
[00:53:20] 23    = note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All, def_id: None }, value: [u8; _] }`...
[00:53:20] 24 note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}#0`...
[00:53:20] 
[00:53:20] The actual stderr differed from the expected stderr.
[00:53:20] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-44415/issue-44415.stderr
[00:53:20] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-44415/issue-44415.stderr
[00:53:20] To update references, rerun the tests and pass the `--bless` flag
[00:53:20] To only update this specific test, also pass `--test-args issues/issue-44415.rs`
[00:53:20] error: 1 errors occurred comparing output.
[00:53:20] status: exit code: 1
[00:53:20] status: exit code: 1
[00:53:20] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-44415.rs" "-Zthreads=1" "--target=i586-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-44415" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/i586-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=cc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-44415/auxiliary" "-A" "unused"
[00:53:20] ------------------------------------------
[00:53:20] 
[00:53:20] ------------------------------------------
[00:53:20] stderr:
[00:53:20] stderr:
[00:53:20] ------------------------------------------
[00:53:20] error[E0391]: cycle detected when const-evaluating + checking `Foo::bytes::{{constant}}#0`
[00:53:20]    |
[00:53:20]    |
[00:53:20] LL |     bytes: [u8; unsafe { intrinsics::size_of::<Foo>() }],
[00:53:20]    |
[00:53:20]    |
[00:53:20] note: ...which requires const-evaluating `Foo::bytes::{{constant}}#0`...
[00:53:20]    |
[00:53:20]    |
[00:53:20] LL |     bytes: [u8; unsafe { intrinsics::size_of::<Foo>() }],
[00:53:20]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:53:20] note: ...which requires const-evaluating + checking `std::intrinsics::size_of`...
[00:53:20] note: ...which requires const-evaluating + checking `std::intrinsics::size_of`...
[00:53:20]    = note: ...which requires computing layout of `Foo`...
[00:53:20]    = note: ...which requires normalizing `ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: All, def_id: None }, value: [u8; _] }`...
[00:53:20] note: ...which requires const-evaluating + checking `Foo::bytes::{{constant}}#0`...
[00:53:20]    |
[00:53:20]    |
[00:53:20] LL |     bytes: [u8; unsafe { intrinsics::size_of::<Foo>() }],
[00:53:20]    |                 ^^^^^^
[00:53:20]    = note: ...which again requires const-evaluating + checking `Foo::bytes::{{constant}}#0`, completing the cycle
[00:53:20] note: cycle used when processing `Foo`
[00:53:20]    |
[00:53:20] LL | struct Foo {
[00:53:20]    | ^^^^^^^^^^
[00:53:20] 
---
[00:53:20] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[00:53:20] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[00:53:20] 
[00:53:20] 
[00:53:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i586-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-i586-unknown-linux-gnu" "--mode" "ui" "--target" "i586-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--linker" "cc" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/i586-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0-rust-1.37.0-nightly\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[00:53:20] 
[00:53:20] 
[00:53:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target i586-unknown-linux-gnu,i686-unknown-linux-musl
[00:53:20] Build completed unsuccessfully in 0:49:51
---
travis_time:end:03bb7ef0:start=1561112131572283512,finish=1561112131578122609,duration=5839097
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:18e70f51
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:28e5457c
travis_time:start:28e5457c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0375be80
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk oli-obk force-pushed the oli-obk:const_eval_intrinsics branch from f361410 to e214d29 Jun 21, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

Uh, even after a rebase I can't repro the failure locally even though it totally looks related. Not sure what is going on. Are there any flags (like debug or so) that can cause query backtraces to differ?

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2019

The CI failue is for i586-unknown-linux-gnu, maybe that's related? Though I don't see how

@mati865

This comment was marked as outdated.

Copy link
Contributor

commented Jun 21, 2019

It's one of the fastest jobs, it often fails first.

@mati865

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

Nevermind, builds other than dist-i586-gnu-i586-i686-musl are passing on Azure: https://dev.azure.com/rust-lang/rust/_build/results?buildId=1214

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

☔️ The latest upstream changes (presumably #62355) made this pull request unmergeable. Please resolve the merge conflicts.

),
other => bug!("`{}` is not a zero arg intrinsic", other),
}
}

This comment has been minimized.

Copy link
@RalfJung

RalfJung Jul 16, 2019

Member

I am not very happy about having this code buried somewhere in const_eval.rs. That file is already very messy, but at least it is almost exclusively "glue code" right now.

A new file in librustc_mir/interpret/ might be a better choice?

This comment has been minimized.

Copy link
@eddyb

eddyb Jul 16, 2019

Member

Isn't there already a file dedicated to intrinsics?

@oli-obk oli-obk force-pushed the oli-obk:const_eval_intrinsics branch from e214d29 to ffd0335 Jul 18, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

☔️ The latest upstream changes (presumably #62902) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@oli-obk Maybe I misunderstood? Or just changed my mind. I considered this whenever I brought up that I think nullary const fns should always be promotable, because they're basically constants.
(And we can check them in a stricter way, too)

@edmilsonefs

This comment has been minimized.

Copy link

commented Jul 30, 2019

Hey! This is a ping from triage, we would like to know if you @oli-obk could give us a few more minutes to update here by fixing the conflicting files so we can move forward.

Thanks.

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Rebased

@rustbot modify labels to -S-waiting-on-author, +S-waiting-on-review

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

☔️ The latest upstream changes (presumably #63214) made this pull request unmergeable. Please resolve the merge conflicts.

@ProgrammaticNajel

This comment has been minimized.

Copy link

commented Aug 9, 2019

Ping from triage. @oli-obk please resolve the conflicting files. Thanks

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@oli-obk oli-obk force-pushed the oli-obk:const_eval_intrinsics branch from 765c0c4 to 102048c Aug 11, 2019

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 11, 2019

Rebased and opened #63130 to track making all zero arg const fn calls computed via the const_eval query.

cc @Centril this makes zero arg const fn intrinsics equivalent to constants (except that const fns can be generic and are computed lazily).

Show resolved Hide resolved src/librustc_mir/const_eval.rs
Show resolved Hide resolved src/librustc_mir/interpret/intrinsics.rs Outdated
Show resolved Hide resolved src/librustc_mir/interpret/intrinsics.rs Outdated
Show resolved Hide resolved src/librustc_mir/interpret/intrinsics/type_name.rs Outdated
Show resolved Hide resolved src/librustc_mir/interpret/mod.rs Outdated
@Centril

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

cc @Centril this makes zero arg const fns equivalent to constants (except that const fns can be generic and are computed lazily).

@oli-obk Does that have any user observable implications?

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Aug 11, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-11T15:38:28.4621752Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-11T15:38:28.4803235Z ##[command]git config gc.auto 0
2019-08-11T15:38:28.4882879Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-11T15:38:28.4933395Z ##[command]git config --get-all http.proxy
2019-08-11T15:38:28.5057339Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/61626/merge:refs/remotes/pull/61626/merge
---
2019-08-11T15:39:02.0851449Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-11T15:39:02.0851693Z 
2019-08-11T15:39:02.0852253Z   git checkout -b <new-branch-name>
2019-08-11T15:39:02.0852491Z 
2019-08-11T15:39:02.0852676Z HEAD is now at 642f8797a Merge a44a72ef37bcc7aa9f78bea0503b211681fa552b into 2b78e10ac1454d2d4190c575f6ece03f484ac398
2019-08-11T15:39:02.1005782Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-11T15:39:02.1009532Z ==============================================================================
2019-08-11T15:39:02.1009608Z Task         : Bash
2019-08-11T15:39:02.1009654Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-11T16:36:17.6145994Z .................................................................................................... 1300/8871
2019-08-11T16:36:23.6685562Z .................................................................................................... 1400/8871
2019-08-11T16:36:29.5502371Z .................................................................................................... 1500/8871
2019-08-11T16:36:39.4917449Z ....................................................................................i............... 1600/8871
2019-08-11T16:36:46.6112077Z i................................................................................................... 1700/8871
2019-08-11T16:36:52.8625463Z ...........................................................................iiiii.................... 1800/8871
2019-08-11T16:37:13.3120944Z .................................................................................................... 2000/8871
2019-08-11T16:37:15.4930144Z .................................................................................................... 2100/8871
2019-08-11T16:37:17.9529233Z .................................................................................................... 2200/8871
2019-08-11T16:37:25.1611313Z .................................................................................................... 2300/8871
---
2019-08-11T16:41:04.7165984Z .................................................................................................... 5300/8871
2019-08-11T16:41:11.4115710Z ......i............................................................................................. 5400/8871
2019-08-11T16:41:16.4117267Z .................................................................................................... 5500/8871
2019-08-11T16:41:28.0097165Z .................................................................................................... 5600/8871
2019-08-11T16:41:41.1629624Z .ii...i..ii...........i............................................................................. 5700/8871
2019-08-11T16:41:55.7834253Z .................................................................................................... 5900/8871
2019-08-11T16:42:00.1071705Z .................................................................................................... 6000/8871
2019-08-11T16:42:00.1071705Z .................................................................................................... 6000/8871
2019-08-11T16:42:13.4028133Z ..i..ii............................................................................................. 6100/8871
2019-08-11T16:42:30.8934397Z .............................................i...................................................... 6300/8871
2019-08-11T16:42:32.8590221Z .................................................................................................... 6400/8871
2019-08-11T16:42:35.1812422Z .................i.................................................................................. 6500/8871
2019-08-11T16:42:39.3208422Z .................................................................................................... 6600/8871
---
2019-08-11T16:46:21.5702973Z failures:
2019-08-11T16:46:21.5703035Z 
2019-08-11T16:46:21.5703577Z ---- [compile-fail] compile-fail/consts/issue-55878.rs stdout ----
2019-08-11T16:46:21.5703800Z 
2019-08-11T16:46:21.5704840Z error: Error: expected failure status (Some(1)) but received status Some(101).
2019-08-11T16:46:21.5704888Z status: exit code: 101
2019-08-11T16:46:21.5706067Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/compile-fail/consts/issue-55878.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/consts/issue-55878" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/consts/issue-55878/auxiliary" "-A" "unused"
2019-08-11T16:46:21.5706994Z ------------------------------------------
2019-08-11T16:46:21.5707032Z 
2019-08-11T16:46:21.5707197Z ------------------------------------------
2019-08-11T16:46:21.5707254Z stderr:
2019-08-11T16:46:21.5707254Z stderr:
2019-08-11T16:46:21.5707411Z ------------------------------------------
2019-08-11T16:46:21.5708623Z thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: SizeOverflow([u8; 18446744073709551615])', src/libcore/result.rs:1084:5
2019-08-11T16:46:21.5708765Z 
2019-08-11T16:46:21.5708798Z error: internal compiler error: unexpected panic
2019-08-11T16:46:21.5708820Z 
2019-08-11T16:46:21.5708871Z note: the compiler unexpectedly panicked. this is a bug.
2019-08-11T16:46:21.5708871Z note: the compiler unexpectedly panicked. this is a bug.
2019-08-11T16:46:21.5708893Z 
2019-08-11T16:46:21.5709296Z note: we would appreciate a bug report: ***/blob/master/CONTRIBUTING.md#bug-reports
2019-08-11T16:46:21.5709535Z note: rustc 1.38.0-dev running on x86_64-unknown-linux-gnu
2019-08-11T16:46:21.5709559Z 
2019-08-11T16:46:21.5709559Z 
2019-08-11T16:46:21.5709760Z note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
2019-08-11T16:46:21.5709827Z 
2019-08-11T16:46:21.5709985Z ------------------------------------------
2019-08-11T16:46:21.5710008Z 
2019-08-11T16:46:21.5710045Z 
---
2019-08-11T16:46:21.5711881Z 
2019-08-11T16:46:21.5712140Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-08-11T16:46:21.5713834Z 
2019-08-11T16:46:21.5713884Z 
2019-08-11T16:46:21.5715488Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/compile-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "compile-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-08-11T16:46:21.5715720Z 
2019-08-11T16:46:21.5715742Z 
2019-08-11T16:46:21.5721453Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-11T16:46:21.5721571Z Build completed unsuccessfully in 1:01:18
2019-08-11T16:46:21.5721571Z Build completed unsuccessfully in 1:01:18
2019-08-11T16:46:22.3546838Z ##[error]Bash exited with code '1'.
2019-08-11T16:46:22.3587975Z ##[section]Starting: Checkout
2019-08-11T16:46:22.3589450Z ==============================================================================
2019-08-11T16:46:22.3589496Z Task         : Get sources
2019-08-11T16:46:22.3589553Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@JohnCSimon

This comment has been minimized.

Copy link

commented Aug 17, 2019

Ping from triage
@Centril @oli-obk what is the status of this? It has sat idle for a week.

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 17, 2019

@rustbot modify labels to -S-waiting-on-author, +S-waiting-on-review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.