is_fp and is_floating_point do the same thing, remove the former #61688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
Jun 9, 2019
is_fp and is_floating_point do the same thing, remove the former also consistently mark all these `is_*` methods for inlining
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 59c2273 |
|
Success: Queued 59c2273 with parent 07c3967, comparison URL. |
|
Finished benchmarking try commit 59c2273, comparison URL. |
|
Looks like no change? |
|
Yeah; just noise... |
|
@bors r+ |
|
📌 Commit 5b54a78 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 11, 2019
is_fp and is_floating_point do the same thing, remove the former also consistently mark all these `is_*` methods for inlining
|
@bors r- conflict. |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #61673) made this pull request unmergeable. Please resolve the merge conflicts. |
also consistently mark all these is_* methods for inlining
RalfJung
force-pushed
the
is-floating-point
branch
from
5b54a78
to
87d5fe0
Compare
|
Rebased locally (without conflicts). @bors r= cramertj rollup |
|
📌 Commit 87d5fe0 has been approved by `` |
bors
added
S-waiting-on-bors
|
@bors r=cramertj rollup |
|
📌 Commit 87d5fe0 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 12, 2019
is_fp and is_floating_point do the same thing, remove the former also consistently mark all these `is_*` methods for inlining
bors
added a commit
that referenced
this pull request
Jun 12, 2019
Rollup of 9 pull requests Successful merges: - #60187 (Generator optimization: Overlap locals that never have storage live at the same time) - #61348 (Implement Clone::clone_from for Option and Result) - #61568 (Use Symbol, Span in libfmt_macros) - #61632 (ci: Collect CPU usage statistics on Azure) - #61654 (use pattern matching for slices destructuring) - #61671 (implement nth_back for Range(Inclusive)) - #61688 (is_fp and is_floating_point do the same thing, remove the former) - #61705 (Pass cflags rather than cxxflags to LLVM as CMAKE_C_FLAGS) - #61734 (Migrate rust-by-example to MdBook2) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also consistently mark all these
is_*methods for inlining