Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: Update clippy from 5a11ed7b to c5d1ecd4 #62052

Closed
wants to merge 1 commit into from
Closed

submodules: Update clippy from 5a11ed7b to c5d1ecd4 #62052

wants to merge 1 commit into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 22, 2019 •
edited
Loading

Changes:

% git shortlog --no-merges 5a11ed7b92cc4cf40a4568a8fc1ff54b198c333b..
Daniele D'Orazio (4):
      make needless_return work with void functions
      update tests and fix lints in clippy
      more idiomatic code
      cargo fmt

Jeremy Stucki (1):
      Remove needless lifetimes

Lzu Tao (1):
      Fix fallout cause NodeId pruning

Matthias Krüger (1):
      readme: update

flip1995 (1):
      Remove another unnecessary lifetime

r? @oli-obk

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Jun 22, 2019

Looks like Oliver is busy, r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned oli-obk Jun 22, 2019
@Centril
Copy link
Contributor

Centril commented Jun 22, 2019

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned Centril Jun 22, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2019

Ping @oli-obk for a rollup.

@oli-obk
Copy link
Contributor

oli-obk commented Jun 23, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 23, 2019

📌 Commit fb0b43c has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 23, 2019
@Centril
Rollup merge of rust-lang#62052 - lzutao:clippy-update, r=oli-obk
f8e1e5c 
submodules: Update clippy from 5a11ed7 to c5d1ecd

Changes:
```console
% git shortlog --no-merges 5a11ed7..
Daniele D'Orazio (4):
      make needless_return work with void functions
      update tests and fix lints in clippy
      more idiomatic code
      cargo fmt

Jeremy Stucki (1):
      Remove needless lifetimes

Lzu Tao (1):
      Fix fallout cause NodeId pruning

Matthias Krüger (1):
      readme: update

flip1995 (1):
      Remove another unnecessary lifetime
```

r? @oli-obk
@Centril Centril mentioned this pull request Jun 23, 2019
Closed
bors added a commit that referenced this pull request Jun 23, 2019
@bors
Auto merge of #62080 - Centril:rollup-1wmgoy8, r=Centril
14ff2f5 
Rollup of 5 pull requests

Successful merges:

 - #61778 (compiletest: Introduce `// {check,build,run}-pass` pass modes)
 - #62037 (Speed up tidy)
 - #62052 (submodules: Update clippy from 5a11ed7 to c5d1ecd)
 - #62070 (Run rustfmt on some libsyntax files)
 - #62075 (Remove `ast::Guard`)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jun 23, 2019

⌛ Testing commit fb0b43c with merge ffd8464c402744e03e39ab30b303027c6a535a19...

@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2019

Closing because the build failed after Let chain PR #60861 .

@tesuji tesuji closed this Jun 23, 2019
@tesuji tesuji deleted the clippy-update branch June 23, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tesuji @rust-highfive @Centril @oli-obk @bors @Manishearth