Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove io::Result from syntax::print #62099

Merged
merged 6 commits into from
Jul 5, 2019
Merged

Remove io::Result from syntax::print #62099

merged 6 commits into from
Jul 5, 2019

Commits on Jun 29, 2019

  1. Privatize a bunch of methods

    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    1 Configuration menu
    Copy the full SHA
    e2d7df5 View commit details
    Browse the repository at this point in the history

  2. Delete now-unused methods

    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    209bde1 View commit details
    Browse the repository at this point in the history

  3. Replace pretty-printer Box<dyn Write> with &mut String

    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    1aff8af View commit details
    Browse the repository at this point in the history

  4. Remove io::Result from syntax::print 

    Since we're now writing directly to the vector, there's no need to
thread results through the whole printing infrastructure
    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    da5c835 View commit details
    Browse the repository at this point in the history

  5. Remove unused import

    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    ff27756 View commit details
    Browse the repository at this point in the history

  6. Inline rust_printer

    @Mark-Simulacrum
    Mark-Simulacrum committed Jun 29, 2019
    Configuration menu
    Copy the full SHA
    d26c4b7 View commit details
    Browse the repository at this point in the history