Improve -Ztime-passes #62110
Merged
Improve -Ztime-passes #62110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
454167c
to
27e3b06
Compare
Zoxc
reviewed
Jun 25, 2019
Zoxc
reviewed
Jun 25, 2019
Zoxc
reviewed
Jun 25, 2019
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
27e3b06
to
f05bd80
Compare
|
@Zoxc: new code is up. It addresses some of your comments, but not all, as per the discussions above. I think it's a clear improvement over the status quo, see what you think. |
|
@Zoxc: what do you think about the latest code? |
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
f05bd80
to
2b749f1
Compare
|
@Zoxc: I updated the code to use the |
Zoxc
reviewed
Jul 1, 2019
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
2b749f1
to
7f1671e
Compare
Zoxc
reviewed
Jul 2, 2019
Zoxc
reviewed
Jul 2, 2019
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
7f1671e
to
718a7c7
Compare
|
☔ The latest upstream changes (presumably #61775) made this pull request unmergeable. Please resolve the merge conflicts. |
…s` output. Because it pollutes the output with hundreds or thousands of uninteresting lines for which the time duration is always(?) 0.000s.
This is useful for getting the total compilation time at the end. To do this, the patch changes `print_time_passes_entry` to not increment the depth, which means that `print_time_passes_entry_internal` is no longer needed.
nnethercote
force-pushed
the
improve-Ztime-passes
branch
from
718a7c7
to
87b103d
Compare
|
@Zoxc: I have rebased. As far as I can tell, I have addressed all your concerns and answered all your questions. I think it's ready to land. |
|
@bors r+ I think we could probably just remove the indentation support. It's broken for LLVM and for the parallel compiler anyway. |
|
📌 Commit 87b103d has been approved by |
bors
added
S-waiting-on-bors
|
The indentation is crucial to understand which passes are sub-passes. I understand it's broken for the back-end, but even then it's still highly useful for the other passes. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 5, 2019
…=Zoxc Improve -Ztime-passes Two improvements that make `-Ztime-passes` more useful. r? @Zoxc
bors
added a commit
that referenced
this pull request
Jul 5, 2019
Rollup of 13 pull requests Successful merges: - #61545 (Implement another internal lints) - #62110 (Improve -Ztime-passes) - #62133 (Feature gate `rustc` attributes harder) - #62158 (Add MemoryExtra in InterpretCx constructor params) - #62168 (The (almost) culmination of HirIdification) - #62193 (Create async version of the dynamic-drop test) - #62369 (Remove `compile-pass` from compiletest) - #62380 (rustc_target: avoid negative register counts in the SysV x86_64 ABI.) - #62381 (Fix a typo in Write::write_vectored docs) - #62390 (Update README.md) - #62396 (remove Scalar::is_null_ptr) - #62406 (Lint on invalid values passed to x.py --warnings) - #62414 (Remove last use of mem::uninitialized in SGX) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements that make
-Ztime-passesmore useful.r? @Zoxc