Remove pub from core::{unicode,cmath,stackwalk,rt}

[alexcrichton]

I just removed pub mod from core.rc and then got everything to compile again. One thing I'm worried about is an import like this:

use a;
use a::b;

mod a {
  pub type b = int;
}
mod b {
  use a;    // bad
  use a::b; // good
}

I'm not sure if use a::b being valid is a bug or intended behavior (same question about use a). If it's intended behavior, then I got around these modules not being public by only importing the specific members that are necessary. Otherwise that probably needs an open issue.

[catamorphism]

I think use a::b shouldn't be allowed if a is private, regardless of whether b is public.

[alexcrichton]

If you can't use anything out of a non-pub mod, then what's the point of having one?

[alexcrichton]

cc #6199

[brson]

@alexcrichton siblings can access items in private mods

mod a { fn foo() { } }
// I can access foo
a::foo()

[brson]

I r+'d because I want those modules to be private, but I do think this is exploiting a resolve bug.

I think that absolute path resolution always assumes that private mods are inaccessible, even when the path is stated in a module that should have access to the path. e.g.

priv mod a { pub fn b() }
priv mod c {
    use a::b; // a is private so resolve thinks we can't access it, even though `c` is a sibling of `a`
}

Relative paths do work

priv mod a { pub fn b() }
priv mod c {
    use super::a::b;
}

imo this is bogus, and visibility should be interpreted the same way for either absolute or relative paths.

[alexcrichton]

So just out of curiosity, let's say that there's a private module m.

• This means that within m, all members (not sub-modules) can access any private/public member of m.
• All child modules of m (and their children) cannot access private members of m, but they can access public members?
• All siblings of the module m can access all the public members of m
• Nothing else can access any member of m

Are those true? Additionally, is there a section in the manual or some documentation explaining all this? If not, I'd be willing to take a stab at writing something up (in addition to looking into the resolve bugs if they exist).

[alexcrichton]

I opened a subsequent issue to deal with the resolve bugs (cc'd previously)