Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend `#[must_use]` to nested structures #62262

Open
wants to merge 12 commits into
base: master
from

Conversation

@varkor
Copy link
Member

commented Jul 1, 2019

Extends the #[must_use] lint to apply when #[must_use] types are nested within structs (or one-variant enums), making the lint much more generally useful. This is in line with #61100 extending the lint to tuples.

Fixes #39524.

cc @rust-lang/lang and @rust-lang/compiler for discussion in case this is a controversial change. In particular, we might want to consider allowing annotations on fields containing #[must_use] types in user-defined types (e.g. #[allow(unused_must_use)]) to opt out of this behaviour, if there are cases where we this this is likely to have frequent false positives.

(This is based on top of #62235.)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.
// We ignore ADTs with more than one variant for simplicity and to avoid
// false positives.
// Unions are also ignored (though in theory, we could lint if every field of
// a union was `#[must_use]`).

This comment has been minimized.

Copy link
@Centril

Centril Jul 1, 2019

Member

This should probably go into a separate method and the comments above can become doc comments...

Show resolved Hide resolved src/librustc_lint/unused.rs
@estebank

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

I'm not available for the next couple of days due to personal reasons. I would appreciate it if someone else could take over review.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

I don't think the review is in any rush - this definitely need lang-team sign off (and maybe libs?); I feel like we've discussed this previously and concluded that we shouldn't do it, IIRC because it expands it far enough that it feels like it "always" works which isn't actually the case. I could be projecting my own thoughts on the matter though.

@Centril

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

I don't think the review is in any rush - this definitely need lang-team sign off (and maybe libs?);

I nominated this for the lang team. The libs team doesn't deal with compiler lints.


I personally feel that the false-positive cases are edge cases that are rare enough that they don't outweigh the big benefit this PR brings.

We could however tweak this a bit to look for a Drop implementations for the ADT and then bail on the structural logic tho that might be too subtle. An opt-out would also be decent.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

I disagree a little bit about the libs team bit here -- it seems like this lint is predominantly used for libraries, not language features/things, and so their opinion matters more. At the very least, they should be notified (cc @rust-lang/libs).

Show resolved Hide resolved src/libstd/panicking.rs Outdated
Show resolved Hide resolved src/librustc_lint/unused.rs Outdated
// false positives.
// Unions are also ignored (though in theory, we could lint if every field of
// a union was `#[must_use]`).
if def.variants.len() == 1 && !def.is_union() {

This comment has been minimized.

Copy link
@eddyb

eddyb Jul 1, 2019

Member

If there are any variants that are #[must_use], the whole enum probably should be too (but you'd need to prevent infinite recursion somehow).

This comment has been minimized.

Copy link
@eddyb

eddyb Jul 1, 2019

Member

Maybe we should switch to a query, like the sized_requirements_for_adt or whatever that's called?

This comment has been minimized.

Copy link
@varkor

varkor Jul 22, 2019

Author Member

I was thinking of warning if there are any #[must_use] variants, but I thought it could get quite noisy with false positives. If rust-lang/rfcs#2593 or similar was merged, then we could do this with fewer false positives.

@Nemo157

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Would it make sense to do a crater run of this to see how useful the warnings it produces in real code are?

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Discussed briefly in @rust-lang/lang -- we agree a crater run would be the logical next step before making any further decisions. Can we set this to deny by default and do a run?

@estebank

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned estebank Jul 12, 2019

@varkor varkor force-pushed the varkor:must_use-adt-components-ii branch from 4ea0b40 to 84ae8df Jul 22, 2019

@varkor

This comment was marked as outdated.

Copy link
Member Author

commented Jul 22, 2019

@bors try for crater run

@bors

This comment was marked as outdated.

Copy link
Contributor

commented Jul 22, 2019

⌛️ Trying commit 84ae8df with merge b8ff8c0...

bors added a commit that referenced this pull request Jul 22, 2019

Auto merge of #62262 - varkor:must_use-adt-components-ii, r=<try>
Extend `#[must_use]` to nested structures

Extends the `#[must_use]` lint to apply when `#[must_use]` types are nested within `struct`s (or one-variant `enum`s), making the lint much more generally useful. This is in line with #61100 extending the lint to tuples.

Fixes #39524.

cc @rust-lang/lang and @rust-lang/compiler for discussion in case this is a controversial change. In particular, we might want to consider allowing annotations on fields containing `#[must_use]` types in user-defined types (e.g. `#[allow(unused_must_use)]`) to opt out of this behaviour, if there are cases where we this this is likely to have frequent false positives.

(This is based on top of #62235.)
@bors

This comment was marked as outdated.

Copy link
Contributor

commented Jul 22, 2019

☔️ The latest upstream changes (presumably #62873) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors referenced this pull request Jul 22, 2019

Merged

[beta] Rollup backports #62866

@Centril Centril closed this Jul 22, 2019

@Centril Centril reopened this Jul 22, 2019

@bors

This comment was marked as resolved.

Copy link
Contributor

commented Jul 27, 2019

☔️ The latest upstream changes (presumably #63029) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors removed the S-waiting-on-bors label Jul 27, 2019

@varkor varkor force-pushed the varkor:must_use-adt-components-ii branch from 3cf7b26 to 57957a6 Jul 28, 2019

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-28T23:20:48.4960993Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-28T23:20:48.5178587Z ##[command]git config gc.auto 0
2019-07-28T23:20:48.5263657Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-28T23:20:48.5314840Z ##[command]git config --get-all http.proxy
2019-07-28T23:20:48.5465827Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62262/merge:refs/remotes/pull/62262/merge
---
2019-07-28T23:21:22.9782127Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-28T23:21:22.9784610Z 
2019-07-28T23:21:22.9786474Z   git checkout -b <new-branch-name>
2019-07-28T23:21:22.9787878Z 
2019-07-28T23:21:22.9788756Z HEAD is now at a8cccd968 Merge 57957a66b409058982044f1ff5b80ff31aad02ea into 4560cb830fce63fcffdc4558f4281aaac6a3a1ba
2019-07-28T23:21:23.0060056Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-28T23:21:23.0063631Z ==============================================================================
2019-07-28T23:21:23.0063810Z Task         : Bash
2019-07-28T23:21:23.0063857Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T00:24:34.6905876Z .................................................................................................... 1400/8803
2019-07-29T00:24:40.8308414Z .................................................................................................... 1500/8803
2019-07-29T00:24:53.8555322Z ................................................................i...............i................... 1600/8803
2019-07-29T00:25:01.6529829Z .................................................................................................... 1700/8803
2019-07-29T00:25:17.0770896Z ..................................................iiiii............................................. 1800/8803
2019-07-29T00:25:28.6193452Z .................................................................................................... 2000/8803
2019-07-29T00:25:31.2868718Z .................................................................................................... 2100/8803
2019-07-29T00:25:35.3883692Z .................................................................................................... 2200/8803
2019-07-29T00:25:42.1509504Z .................................................................................................... 2300/8803
---
2019-07-29T00:29:36.0013668Z .................................................................................................... 5200/8803
2019-07-29T00:29:47.1905327Z .................................................................................................... 5300/8803
2019-07-29T00:29:55.1505717Z ..i................................................................................................. 5400/8803
2019-07-29T00:30:00.4995222Z .................................................................................................... 5500/8803
2019-07-29T00:30:13.0243088Z ................................................................................................ii.. 5600/8803
2019-07-29T00:30:28.0760063Z .i..ii...........i.................................................................................. 5700/8803
2019-07-29T00:30:46.7449720Z .................................................................................................... 5900/8803
2019-07-29T00:30:51.6122777Z ................................................................................................i..i 6000/8803
2019-07-29T00:31:06.3441645Z i................................................................................................... 6100/8803
2019-07-29T00:31:23.3903617Z .................................................................................................... 6200/8803
---
2019-07-29T00:36:25.3917038Z  finished in 23.309
2019-07-29T00:36:25.4102520Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T00:36:25.5767274Z 
2019-07-29T00:36:25.5767471Z running 146 tests
2019-07-29T00:36:29.0004546Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-29T00:36:30.9210903Z iii..............i.........iii.i......ii......
2019-07-29T00:36:30.9214287Z 
2019-07-29T00:36:30.9214555Z  finished in 5.511
2019-07-29T00:36:30.9437409Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T00:36:31.1174461Z 
---
2019-07-29T00:36:33.3272003Z  finished in 2.383
2019-07-29T00:36:33.3479307Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T00:36:33.5191809Z 
2019-07-29T00:36:33.5194677Z running 9 tests
2019-07-29T00:36:33.5195905Z iiiiiiiii
2019-07-29T00:36:33.5198597Z 
2019-07-29T00:36:33.5198848Z  finished in 0.171
2019-07-29T00:36:33.5392953Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T00:36:33.7058881Z 
2019-07-29T00:36:33.7058881Z 
2019-07-29T00:36:33.7059039Z running 104 tests
2019-07-29T00:36:51.6777784Z .....F.............................................................................................. 100/104
2019-07-29T00:36:52.2918583Z ..F.
2019-07-29T00:36:52.2921024Z failures:
2019-07-29T00:36:52.2921086Z 
2019-07-29T00:36:52.2922031Z ---- [incremental] incremental/change_crate_order/main.rs stdout ----
2019-07-29T00:36:52.2922083Z 
2019-07-29T00:36:52.2922334Z error in revision `rpass1`: compilation failed!
2019-07-29T00:36:52.2922444Z status: exit code: 1
2019-07-29T00:36:52.2923671Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/change_crate_order/main.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "rpass1" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/main.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/change_crate_order/main/auxiliary"
2019-07-29T00:36:52.2924528Z ------------------------------------------
2019-07-29T00:36:52.2924854Z 
2019-07-29T00:36:52.2925425Z ------------------------------------------
2019-07-29T00:36:52.2925609Z stderr:
2019-07-29T00:36:52.2925609Z stderr:
2019-07-29T00:36:52.2925929Z ------------------------------------------
2019-07-29T00:36:52.2926114Z error: unused arithmetic operation that must be used
2019-07-29T00:36:52.2926433Z   --> /checkout/src/test/incremental/change_crate_order/main.rs:23:5
2019-07-29T00:36:52.2926653Z    |
2019-07-29T00:36:52.2926725Z LL |     A + B;
2019-07-29T00:36:52.2926805Z    |     ^^^^^
2019-07-29T00:36:52.2926845Z    |
2019-07-29T00:36:52.2926887Z    = note: `#[deny(unused_must_use)]` on by default
2019-07-29T00:36:52.2927085Z error: aborting due to previous error
2019-07-29T00:36:52.2927138Z 
2019-07-29T00:36:52.2927162Z 
2019-07-29T00:36:52.2927575Z ------------------------------------------
2019-07-29T00:36:52.2927575Z ------------------------------------------
2019-07-29T00:36:52.2927626Z 
2019-07-29T00:36:52.2927788Z 
2019-07-29T00:36:52.2928110Z ---- [incremental] incremental/warnings-reemitted.rs stdout ----
2019-07-29T00:36:52.2928143Z 
2019-07-29T00:36:52.2928830Z error in revision `cfail1`: test compilation failed although it shouldn't!
2019-07-29T00:36:52.2929031Z status: exit code: 1
2019-07-29T00:36:52.2930461Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/incremental/warnings-reemitted.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "cfail1" "-C" "incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/warnings-reemitted/warnings-reemitted.inc" "-Z" "incremental-verify-ich" "-Z" "incremental-queries" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/warnings-reemitted" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Coverflow-checks=on" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental/warnings-reemitted/auxiliary"
2019-07-29T00:36:52.2931145Z ------------------------------------------
2019-07-29T00:36:52.2931181Z 
2019-07-29T00:36:52.2931441Z ------------------------------------------
2019-07-29T00:36:52.2931488Z stderr:
2019-07-29T00:36:52.2931488Z stderr:
2019-07-29T00:36:52.2931927Z ------------------------------------------
2019-07-29T00:36:52.2932145Z error: unused arithmetic operation that must be used
2019-07-29T00:36:52.2932484Z   --> /checkout/src/test/incremental/warnings-reemitted.rs:9:5
2019-07-29T00:36:52.2932687Z    |
2019-07-29T00:36:52.2933166Z LL |     255u8 + 1; //~ WARNING this expression will panic at run-time
2019-07-29T00:36:52.2933505Z    |
2019-07-29T00:36:52.2933505Z    |
2019-07-29T00:36:52.2933561Z    = note: `#[deny(unused_must_use)]` on by default
2019-07-29T00:36:52.2933665Z error: aborting due to previous error
2019-07-29T00:36:52.2933690Z 
2019-07-29T00:36:52.2933856Z 
2019-07-29T00:36:52.2934183Z ------------------------------------------
---
2019-07-29T00:36:52.2936204Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-29T00:36:52.2936258Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-29T00:36:52.2936441Z 
2019-07-29T00:36:52.2936500Z 
2019-07-29T00:36:52.2937884Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/incremental" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/incremental" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "incremental" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-29T00:36:52.2938298Z 
2019-07-29T00:36:52.2938325Z 
2019-07-29T00:36:52.2947912Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-29T00:36:52.2948102Z Build completed unsuccessfully in 1:09:11
2019-07-29T00:36:52.2948102Z Build completed unsuccessfully in 1:09:11
2019-07-29T00:36:55.7766558Z ##[error]Bash exited with code '1'.
2019-07-29T00:36:55.7809331Z ##[section]Starting: Checkout
2019-07-29T00:36:55.7811213Z ==============================================================================
2019-07-29T00:36:55.7811289Z Task         : Get sources
2019-07-29T00:36:55.7811342Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-29T20:18:22.4036312Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-29T20:18:22.4222682Z ##[command]git config gc.auto 0
2019-07-29T20:18:22.4294318Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-29T20:18:22.4378262Z ##[command]git config --get-all http.proxy
2019-07-29T20:18:22.4483939Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62262/merge:refs/remotes/pull/62262/merge
---
2019-07-29T20:18:56.9483347Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-29T20:18:56.9483681Z 
2019-07-29T20:18:56.9484267Z   git checkout -b <new-branch-name>
2019-07-29T20:18:56.9484663Z 
2019-07-29T20:18:56.9484980Z HEAD is now at 9747c2722 Merge ec5180415e31fa717eacbe0332a0eea3ab96ca18 into 04b88a9eba8abbac87eddcb2998beea09589c2c9
2019-07-29T20:18:56.9725698Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-29T20:18:56.9728528Z ==============================================================================
2019-07-29T20:18:56.9728598Z Task         : Bash
2019-07-29T20:18:56.9728646Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T21:21:21.5872903Z .................................................................................................... 1400/8805
2019-07-29T21:21:27.5370511Z .................................................................................................... 1500/8805
2019-07-29T21:21:40.3771280Z ................................................................i...............i................... 1600/8805
2019-07-29T21:21:48.4108607Z .................................................................................................... 1700/8805
2019-07-29T21:22:03.9721469Z ..................................................iiiii............................................. 1800/8805
2019-07-29T21:22:15.7315812Z .................................................................................................... 2000/8805
2019-07-29T21:22:18.4287512Z .................................................................................................... 2100/8805
2019-07-29T21:22:22.6103008Z .................................................................................................... 2200/8805
2019-07-29T21:22:29.6555911Z .................................................................................................... 2300/8805
---
2019-07-29T21:26:18.3325567Z .................................................................................................... 5200/8805
2019-07-29T21:26:29.1957156Z .................................................................................................... 5300/8805
2019-07-29T21:26:36.8008965Z ...i................................................................................................ 5400/8805
2019-07-29T21:26:42.2402803Z .................................................................................................... 5500/8805
2019-07-29T21:26:54.8587789Z .................................................................................................ii. 5600/8805
2019-07-29T21:27:09.8982822Z ..i..ii...........i................................................................................. 5700/8805
2019-07-29T21:27:24.6168243Z .................................................................................................... 5900/8805
2019-07-29T21:27:29.4971113Z .................................................................................................i.. 6000/8805
2019-07-29T21:27:44.0860731Z ii.................................................................................................. 6100/8805
2019-07-29T21:28:00.6629754Z .................................................................................................... 6200/8805
---
2019-07-29T21:32:59.1562772Z  finished in 23.391
2019-07-29T21:32:59.1741699Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:32:59.3626850Z 
2019-07-29T21:32:59.3627678Z running 146 tests
2019-07-29T21:33:02.7082567Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-29T21:33:04.5843467Z iii..............i.........iii.i......ii......
2019-07-29T21:33:04.5848209Z 
2019-07-29T21:33:04.5853579Z  finished in 5.411
2019-07-29T21:33:04.6039682Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:33:04.7628304Z 
---
2019-07-29T21:33:06.8131249Z  finished in 2.208
2019-07-29T21:33:06.8316893Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:33:06.9892380Z 
2019-07-29T21:33:06.9892747Z running 9 tests
2019-07-29T21:33:06.9893775Z iiiiiiiii
2019-07-29T21:33:06.9894192Z 
2019-07-29T21:33:06.9894250Z  finished in 0.157
2019-07-29T21:33:07.0090072Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:33:07.1711997Z 
---
2019-07-29T21:33:25.7987079Z  finished in 18.788
2019-07-29T21:33:25.8176784Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:33:25.9863045Z 
2019-07-29T21:33:25.9863843Z running 122 tests
2019-07-29T21:33:50.5940493Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-29T21:33:55.3756879Z .i.i......iii.i.....ii
2019-07-29T21:33:55.3757371Z 
2019-07-29T21:33:55.3757447Z  finished in 29.557
2019-07-29T21:33:55.3767654Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T21:33:55.3768021Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-29T21:41:35.0326622Z ---- [pretty] pretty/block-disambig.rs stdout ----
2019-07-29T21:41:35.0326915Z 
2019-07-29T21:41:35.0328148Z error: pretty-printed source does not typecheck
2019-07-29T21:41:35.0328593Z status: exit code: 1
2019-07-29T21:41:35.0330170Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-" "-Zno-codegen" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty/block-disambig/block-disambig.pretty-out" "--target=x86_64-unknown-linux-gnu" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty/block-disambig/auxiliary.pretty" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib"
2019-07-29T21:41:35.0331275Z ------------------------------------------
2019-07-29T21:41:35.0332409Z 
2019-07-29T21:41:35.0332940Z ------------------------------------------
2019-07-29T21:41:35.0333134Z stderr:
2019-07-29T21:41:35.0333134Z stderr:
2019-07-29T21:41:35.0333491Z ------------------------------------------
2019-07-29T21:41:35.0333688Z warning: function is never used: `test1`
2019-07-29T21:41:35.0334419Z   --> <anon>:10:1
2019-07-29T21:41:35.0334631Z    |
2019-07-29T21:41:35.0334788Z 10 | fn test1() { let val = &0; { } *val; }
2019-07-29T21:41:35.0336179Z    |
2019-07-29T21:41:35.0336320Z    = note: `#[warn(dead_code)]` on by default
2019-07-29T21:41:35.0336428Z 
2019-07-29T21:41:35.0336547Z warning: function is never used: `test2`
2019-07-29T21:41:35.0336547Z warning: function is never used: `test2`
2019-07-29T21:41:35.0336925Z   --> <anon>:12:1
2019-07-29T21:41:35.0337092Z    |
2019-07-29T21:41:35.0337416Z 12 | fn test2() -> isize { let val = &0; { } *val }
2019-07-29T21:41:35.0337699Z 
2019-07-29T21:41:35.0337699Z 
2019-07-29T21:41:35.0337817Z warning: field is never used: `eax`
2019-07-29T21:41:35.0338123Z   --> <anon>:16:5
2019-07-29T21:41:35.0338279Z    |
2019-07-29T21:41:35.0338393Z 16 |     eax: isize,
2019-07-29T21:41:35.0338624Z 
2019-07-29T21:41:35.0338741Z warning: function is never used: `test3`
2019-07-29T21:41:35.0338741Z warning: function is never used: `test3`
2019-07-29T21:41:35.0339028Z   --> <anon>:19:1
2019-07-29T21:41:35.0339341Z 19 | fn test3() {
2019-07-29T21:41:35.0339452Z    | ^^^^^^^^^^
2019-07-29T21:41:35.0339572Z 
2019-07-29T21:41:35.0339705Z warning: function is never used: `test4`
2019-07-29T21:41:35.0339705Z warning: function is never used: `test4`
2019-07-29T21:41:35.0339996Z   --> <anon>:25:1
2019-07-29T21:41:35.0340166Z    |
2019-07-29T21:41:35.0340505Z 25 | fn test4() -> bool { let regs = &true; if true { } *regs || false }
2019-07-29T21:41:35.0340799Z 
2019-07-29T21:41:35.0340915Z warning: function is never used: `test5`
2019-07-29T21:41:35.0340915Z warning: function is never used: `test5`
2019-07-29T21:41:35.0341204Z   --> <anon>:27:1
2019-07-29T21:41:35.0341373Z    |
2019-07-29T21:41:35.0342032Z 27 | fn test5() -> (isize, isize) { { } (0, 1) }
2019-07-29T21:41:35.0342871Z 
2019-07-29T21:41:35.0343003Z warning: function is never used: `test6`
2019-07-29T21:41:35.0343003Z warning: function is never used: `test6`
2019-07-29T21:41:35.0343392Z   --> <anon>:29:1
2019-07-29T21:41:35.0343589Z    |
2019-07-29T21:41:35.0343968Z 29 | fn test6() -> bool { { } (true || false) && true }
2019-07-29T21:41:35.0344293Z 
2019-07-29T21:41:35.0344425Z warning: function is never used: `test7`
2019-07-29T21:41:35.0344425Z warning: function is never used: `test7`
2019-07-29T21:41:35.0344752Z   --> <anon>:31:1
2019-07-29T21:41:35.0345380Z 31 | fn test7() -> usize {
2019-07-29T21:41:35.0345533Z    | ^^^^^^^^^^^^^^^^^^^
2019-07-29T21:41:35.0345653Z 
2019-07-29T21:41:35.0345768Z warning: function is never used: `test8`
2019-07-29T21:41:35.0345768Z warning: function is never used: `test8`
2019-07-29T21:41:35.0346052Z   --> <anon>:37:1
2019-07-29T21:41:35.0346220Z    |
2019-07-29T21:41:35.0346511Z 37 | fn test8() -> isize {
2019-07-29T21:41:35.0346902Z 
2019-07-29T21:41:35.0347075Z warning: function is never used: `test9`
2019-07-29T21:41:35.0347075Z warning: function is never used: `test9`
2019-07-29T21:41:35.0347423Z   --> <anon>:43:1
2019-07-29T21:41:35.0348272Z 43 | fn test9() {
2019-07-29T21:41:35.0348311Z    | ^^^^^^^^^^
2019-07-29T21:41:35.0348360Z 
2019-07-29T21:41:35.0348432Z warning: function is never used: `test10`
2019-07-29T21:41:35.0348432Z warning: function is never used: `test10`
2019-07-29T21:41:35.0348719Z   --> <anon>:49:1
2019-07-29T21:41:35.0348758Z    |
2019-07-29T21:41:35.0349147Z 49 | fn test10() -> isize {
2019-07-29T21:41:35.0349680Z 
2019-07-29T21:41:35.0349730Z warning: function is never used: `test11`
2019-07-29T21:41:35.0349730Z warning: function is never used: `test11`
2019-07-29T21:41:35.0349969Z   --> <anon>:55:1
2019-07-29T21:41:35.0350022Z    |
2019-07-29T21:41:35.0350229Z 55 | fn test11() -> Vec<isize> { if true { } vec![1 , 2] }
2019-07-29T21:41:35.0350298Z 
2019-07-29T21:41:35.0350350Z error: unused unary operation that must be used
2019-07-29T21:41:35.0350350Z error: unused unary operation that must be used
2019-07-29T21:41:35.0350520Z   --> <anon>:10:32
2019-07-29T21:41:35.0350559Z    |
2019-07-29T21:41:35.0350611Z 10 | fn test1() { let val = &0; { } *val; }
2019-07-29T21:41:35.0350689Z    |
2019-07-29T21:41:35.0350689Z    |
2019-07-29T21:41:35.0350728Z    = note: `#[deny(unused_must_use)]` on by default
2019-07-29T21:41:35.0350992Z error: aborting due to previous error
2019-07-29T21:41:35.0351022Z 
2019-07-29T21:41:35.0351044Z 
2019-07-29T21:41:35.0351285Z ------------------------------------------
2019-07-29T21:41:35.0351285Z ------------------------------------------
2019-07-29T21:41:35.0351314Z 
2019-07-29T21:41:35.0351338Z 
2019-07-29T21:41:35.0351534Z ---- [pretty] pretty/unary-op-disambig.rs stdout ----
2019-07-29T21:41:35.0351561Z 
2019-07-29T21:41:35.0352220Z error: pretty-printed source does not typecheck
2019-07-29T21:41:35.0352279Z status: exit code: 1
2019-07-29T21:41:35.0353053Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "-" "-Zno-codegen" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty/unary-op-disambig/unary-op-disambig.pretty-out" "--target=x86_64-unknown-linux-gnu" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty/unary-op-disambig/auxiliary.pretty" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib"
2019-07-29T21:41:35.0353392Z ------------------------------------------
2019-07-29T21:41:35.0353446Z 
2019-07-29T21:41:35.0353668Z ------------------------------------------
2019-07-29T21:41:35.0353713Z stderr:
2019-07-29T21:41:35.0353713Z stderr:
2019-07-29T21:41:35.0353936Z ------------------------------------------
2019-07-29T21:41:35.0353984Z warning: function is never used: `f`
2019-07-29T21:41:35.0354173Z  --> <anon>:5:1
2019-07-29T21:41:35.0354275Z 5 | fn f() { }
2019-07-29T21:41:35.0354318Z   | ^^^^^^
2019-07-29T21:41:35.0354357Z   |
2019-07-29T21:41:35.0354417Z   = note: `#[warn(dead_code)]` on by default
2019-07-29T21:41:35.0354417Z   = note: `#[warn(dead_code)]` on by default
2019-07-29T21:41:35.0354447Z 
2019-07-29T21:41:35.0354491Z warning: function is never used: `block_semi`
2019-07-29T21:41:35.0354683Z  --> <anon>:7:1
2019-07-29T21:41:35.0354740Z   |
2019-07-29T21:41:35.0354954Z 7 | fn block_semi() -> isize { { f() }; -1 }
2019-07-29T21:41:35.0355046Z 
2019-07-29T21:41:35.0355046Z 
2019-07-29T21:41:35.0355275Z warning: function is never used: `block_nosemi`
2019-07-29T21:41:35.0355554Z  --> <anon>:9:1
2019-07-29T21:41:35.0355592Z   |
2019-07-29T21:41:35.0355796Z 9 | fn block_nosemi() -> isize { ({ 0 }) - 1 }
2019-07-29T21:41:35.0355862Z 
2019-07-29T21:41:35.0355862Z 
2019-07-29T21:41:35.0355900Z warning: function is never used: `if_semi`
2019-07-29T21:41:35.0356080Z   --> <anon>:11:1
2019-07-29T21:41:35.0356118Z    |
2019-07-29T21:41:35.0356321Z 11 | fn if_semi() -> isize { if true { f() } else { f() }; -1 }
2019-07-29T21:41:35.0356409Z 
2019-07-29T21:41:35.0356409Z 
2019-07-29T21:41:35.0356447Z warning: function is never used: `if_nosemi`
2019-07-29T21:41:35.0356630Z   --> <anon>:13:1
2019-07-29T21:41:35.0356670Z    |
2019-07-29T21:41:35.0356874Z 13 | fn if_nosemi() -> isize { (if true { 0 } else { 0 }) - 1 }
2019-07-29T21:41:35.0356964Z 
2019-07-29T21:41:35.0356964Z 
2019-07-29T21:41:35.0357009Z warning: function is never used: `alt_semi`
2019-07-29T21:41:35.0357179Z   --> <anon>:15:1
2019-07-29T21:41:35.0357215Z    |
2019-07-29T21:41:35.0357445Z 15 | fn alt_semi() -> isize { match true { true => { f() } _ => { } }; -1 }
2019-07-29T21:41:35.0357514Z 
2019-07-29T21:41:35.0357514Z 
2019-07-29T21:41:35.0357566Z warning: function is never used: `alt_no_semi`
2019-07-29T21:41:35.0357732Z   --> <anon>:17:1
2019-07-29T21:41:35.0357769Z    |
2019-07-29T21:41:35.0357989Z 17 | fn alt_no_semi() -> isize { (match true { true => { 0 } _ => { 1 } }) - 1 }
2019-07-29T21:41:35.0358071Z 
2019-07-29T21:41:35.0358071Z 
2019-07-29T21:41:35.0358109Z warning: function is never used: `stmt`
2019-07-29T21:41:35.0358290Z   --> <anon>:19:1
2019-07-29T21:41:35.0358327Z    |
2019-07-29T21:41:35.0358505Z 19 | fn stmt() { { f() }; -1; }
2019-07-29T21:41:35.0358581Z 
2019-07-29T21:41:35.0358711Z error: unused unary operation that must be used
2019-07-29T21:41:35.0358711Z error: unused unary operation that must be used
2019-07-29T21:41:35.0358964Z   --> <anon>:19:22
2019-07-29T21:41:35.0359020Z    |
2019-07-29T21:41:35.0359197Z 19 | fn stmt() { { f() }; -1; }
2019-07-29T21:41:35.0359273Z    |
2019-07-29T21:41:35.0359273Z    |
2019-07-29T21:41:35.0359326Z    = note: `#[deny(unused_must_use)]` on by default
2019-07-29T21:41:35.0359390Z error: aborting due to previous error
2019-07-29T21:41:35.0359415Z 
2019-07-29T21:41:35.0359451Z 
2019-07-29T21:41:35.0359637Z ------------------------------------------
---
2019-07-29T21:41:35.0361337Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-29T21:41:35.0361522Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-29T21:41:35.0369348Z 
2019-07-29T21:41:35.0369411Z 
2019-07-29T21:41:35.0371111Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/pretty" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/pretty" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "pretty" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-29T21:41:35.0371574Z 
2019-07-29T21:41:35.0371620Z 
2019-07-29T21:41:35.0375924Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-29T21:41:35.0376006Z Build completed unsuccessfully in 1:16:15
2019-07-29T21:41:35.0376006Z Build completed unsuccessfully in 1:16:15
2019-07-29T21:41:37.4348457Z ##[error]Bash exited with code '1'.
2019-07-29T21:41:37.4383808Z ##[section]Starting: Checkout
2019-07-29T21:41:37.4386276Z ==============================================================================
2019-07-29T21:41:37.4386336Z Task         : Get sources
2019-07-29T21:41:37.4386404Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 29, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-29T22:05:28.8568196Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-29T22:05:28.8733502Z ##[command]git config gc.auto 0
2019-07-29T22:05:28.8813933Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-29T22:05:28.8864557Z ##[command]git config --get-all http.proxy
2019-07-29T22:05:28.9011007Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62262/merge:refs/remotes/pull/62262/merge
---
2019-07-29T22:06:01.9822227Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-29T22:06:01.9822373Z 
2019-07-29T22:06:01.9823117Z   git checkout -b <new-branch-name>
2019-07-29T22:06:01.9823362Z 
2019-07-29T22:06:01.9823537Z HEAD is now at 8d1700318 Merge 1e07ca195ab5398ec7fcba74d0eba192b92d244b into 04b88a9eba8abbac87eddcb2998beea09589c2c9
2019-07-29T22:06:01.9963580Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-29T22:06:01.9966618Z ==============================================================================
2019-07-29T22:06:01.9966678Z Task         : Bash
2019-07-29T22:06:01.9966725Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T23:07:26.9541033Z .................................................................................................... 1400/8805
2019-07-29T23:07:32.9442840Z .................................................................................................... 1500/8805
2019-07-29T23:07:45.7600010Z ................................................................i...............i................... 1600/8805
2019-07-29T23:07:53.6084866Z .................................................................................................... 1700/8805
2019-07-29T23:08:08.6163159Z ..................................................iiiii............................................. 1800/8805
2019-07-29T23:08:20.0073967Z .................................................................................................... 2000/8805
2019-07-29T23:08:22.6004768Z .................................................................................................... 2100/8805
2019-07-29T23:08:26.5797640Z .................................................................................................... 2200/8805
2019-07-29T23:08:33.2672388Z .................................................................................................... 2300/8805
---
2019-07-29T23:12:20.4739777Z .................................................................................................... 5200/8805
2019-07-29T23:12:31.2811088Z .................................................................................................... 5300/8805
2019-07-29T23:12:38.6645908Z ...i................................................................................................ 5400/8805
2019-07-29T23:12:44.1422744Z .................................................................................................... 5500/8805
2019-07-29T23:12:56.3112273Z .................................................................................................ii. 5600/8805
2019-07-29T23:13:10.8895380Z ..i..ii...........i................................................................................. 5700/8805
2019-07-29T23:13:28.7216246Z .................................................................................................... 5900/8805
2019-07-29T23:13:33.4337663Z .................................................................................................i.. 6000/8805
2019-07-29T23:13:47.7579199Z ii.................................................................................................. 6100/8805
2019-07-29T23:14:04.1147807Z .................................................................................................... 6200/8805
---
2019-07-29T23:18:54.3084288Z  finished in 21.239
2019-07-29T23:18:54.3258882Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:18:54.4924133Z 
2019-07-29T23:18:54.4924306Z running 146 tests
2019-07-29T23:18:57.7372405Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-29T23:18:59.5706537Z iii..............i.........iii.i......ii......
2019-07-29T23:18:59.5707876Z 
2019-07-29T23:18:59.5711521Z  finished in 5.245
2019-07-29T23:18:59.5880011Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:18:59.7481648Z 
---
2019-07-29T23:19:01.8171664Z  finished in 2.228
2019-07-29T23:19:01.8352326Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:19:01.9948165Z 
2019-07-29T23:19:01.9949475Z running 9 tests
2019-07-29T23:19:01.9951056Z iiiiiiiii
2019-07-29T23:19:01.9951419Z 
2019-07-29T23:19:01.9960311Z  finished in 0.159
2019-07-29T23:19:02.0128177Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:19:02.1738322Z 
---
2019-07-29T23:19:20.3704714Z  finished in 18.357
2019-07-29T23:19:20.3883423Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:19:20.5595745Z 
2019-07-29T23:19:20.5595928Z running 122 tests
2019-07-29T23:19:44.3862863Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-29T23:19:48.9689685Z .i.i......iii.i.....ii
2019-07-29T23:19:48.9691123Z 
2019-07-29T23:19:48.9694218Z  finished in 28.581
2019-07-29T23:19:48.9702011Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-29T23:19:48.9702916Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-29T23:30:03.6386671Z    |
2019-07-29T23:30:03.6387295Z 80 | #![feature(const_generics)]
2019-07-29T23:30:03.6387871Z    |            ^^^^^^^^^^^^^^
2019-07-29T23:30:03.6388302Z 
2019-07-29T23:30:12.8873947Z error: unused `std::iter::Cloned` in field `replace_with` that must be used
2019-07-29T23:30:12.8880124Z     |
2019-07-29T23:30:12.8880124Z     |
2019-07-29T23:30:12.8880718Z 586 |     v.splice(2..4, a.iter().cloned());
2019-07-29T23:30:12.8881896Z     |
2019-07-29T23:30:12.8881896Z     |
2019-07-29T23:30:12.8882465Z     = note: `#[deny(unused_must_use)]` on by default
2019-07-29T23:30:12.8883001Z     = note: iterators are lazy and do nothing unless consumed
2019-07-29T23:30:12.8883236Z 
2019-07-29T23:30:12.8883846Z error: unused `std::iter::Cloned` in field `replace_with` that must be used
2019-07-29T23:30:12.8885288Z     |
2019-07-29T23:30:12.8885288Z     |
2019-07-29T23:30:12.8885861Z 609 |     v.splice(5..6, a.iter().cloned());
2019-07-29T23:30:12.8886906Z     |
2019-07-29T23:30:12.8886906Z     |
2019-07-29T23:30:12.8887460Z     = note: iterators are lazy and do nothing unless consumed
2019-07-29T23:30:12.8887707Z 
2019-07-29T23:30:12.8888409Z error: unused `std::iter::Cloned` in field `replace_with` that must be used
2019-07-29T23:30:12.8889393Z     |
2019-07-29T23:30:12.8889393Z     |
2019-07-29T23:30:12.8889907Z 617 |     v.splice(5..=5, a.iter().cloned());
2019-07-29T23:30:12.8890894Z     |
2019-07-29T23:30:12.8890894Z     |
2019-07-29T23:30:12.8891403Z     = note: iterators are lazy and do nothing unless consumed
2019-07-29T23:30:12.9670986Z error: aborting due to 3 previous errors
2019-07-29T23:30:12.9672903Z 
2019-07-29T23:30:13.0760363Z error: Could not compile `alloc`.
2019-07-29T23:30:13.0778720Z warning: build failed, waiting for other jobs to finish...
2019-07-29T23:30:13.0778720Z warning: build failed, waiting for other jobs to finish...
2019-07-29T23:30:15.5098576Z error: build failed
2019-07-29T23:30:15.5110623Z 
2019-07-29T23:30:15.5115335Z 
2019-07-29T23:30:15.5116415Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--" "--quiet"
2019-07-29T23:30:15.5116619Z 
2019-07-29T23:30:15.5116657Z 
2019-07-29T23:30:15.5125237Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-29T23:30:15.5125323Z Build completed unsuccessfully in 1:17:41
2019-07-29T23:30:15.5125323Z Build completed unsuccessfully in 1:17:41
2019-07-29T23:30:16.6668456Z ##[error]Bash exited with code '1'.
2019-07-29T23:30:16.6723746Z ##[section]Starting: Checkout
2019-07-29T23:30:16.6725859Z ==============================================================================
2019-07-29T23:30:16.6726067Z Task         : Get sources
2019-07-29T23:30:16.6726114Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

commented Jul 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-29T23:45:34.8249790Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-29T23:45:34.8452726Z ##[command]git config gc.auto 0
2019-07-29T23:45:34.8536125Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-29T23:45:34.8598633Z ##[command]git config --get-all http.proxy
2019-07-29T23:45:34.8744769Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62262/merge:refs/remotes/pull/62262/merge
---
2019-07-29T23:46:09.3956951Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-29T23:46:09.3958680Z 
2019-07-29T23:46:09.3960210Z   git checkout -b <new-branch-name>
2019-07-29T23:46:09.3961513Z 
2019-07-29T23:46:09.3965003Z HEAD is now at 0c61cf98f Merge 7593104f1809c267a0a935b0f87fb28574c64f90 into 04b88a9eba8abbac87eddcb2998beea09589c2c9
2019-07-29T23:46:09.4088292Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-29T23:46:09.4091282Z ==============================================================================
2019-07-29T23:46:09.4091349Z Task         : Bash
2019-07-29T23:46:09.4091401Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-30T00:48:52.8588477Z .................................................................................................... 1400/8805
2019-07-30T00:48:58.9863780Z .................................................................................................... 1500/8805
2019-07-30T00:49:11.9986619Z ................................................................i...............i................... 1600/8805
2019-07-30T00:49:20.0006923Z .................................................................................................... 1700/8805
2019-07-30T00:49:35.8729348Z ..................................................iiiii............................................. 1800/8805
2019-07-30T00:49:46.9621185Z .................................................................................................... 2000/8805
2019-07-30T00:49:49.6384310Z .................................................................................................... 2100/8805
2019-07-30T00:49:53.8131264Z .................................................................................................... 2200/8805
2019-07-30T00:50:00.5849477Z .................................................................................................... 2300/8805
---
2019-07-30T00:53:55.8095601Z .................................................................................................... 5200/8805
2019-07-30T00:54:06.8078116Z .................................................................................................... 5300/8805
2019-07-30T00:54:14.6374680Z ...i................................................................................................ 5400/8805
2019-07-30T00:54:20.3244468Z .................................................................................................... 5500/8805
2019-07-30T00:54:32.8814051Z .................................................................................................ii. 5600/8805
2019-07-30T00:54:48.0424428Z ..i..ii...........i................................................................................. 5700/8805
2019-07-30T00:55:03.2601349Z .................................................................................................... 5900/8805
2019-07-30T00:55:08.2436566Z .................................................................................................i.. 6000/8805
2019-07-30T00:55:23.1005197Z ii.................................................................................................. 6100/8805
2019-07-30T00:55:39.9732684Z .................................................................................................... 6200/8805
---
2019-07-30T01:00:42.8346577Z  finished in 23.721
2019-07-30T01:00:42.8546599Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:00:43.0228231Z 
2019-07-30T01:00:43.0229258Z running 146 tests
2019-07-30T01:00:46.5632920Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-30T01:00:48.4985647Z iii..............i.........iii.i......ii......
2019-07-30T01:00:48.4986170Z 
2019-07-30T01:00:48.4986247Z  finished in 5.643
2019-07-30T01:00:48.5178658Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:00:48.6820759Z 
---
2019-07-30T01:00:50.7895980Z  finished in 2.271
2019-07-30T01:00:50.8107056Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:00:50.9710801Z 
2019-07-30T01:00:50.9712555Z running 9 tests
2019-07-30T01:00:50.9717877Z iiiiiiiii
2019-07-30T01:00:50.9720752Z 
2019-07-30T01:00:50.9721863Z  finished in 0.160
2019-07-30T01:00:50.9907056Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:00:51.1665389Z 
---
2019-07-30T01:01:10.2232706Z  finished in 19.232
2019-07-30T01:01:10.2446490Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:01:10.4196595Z 
2019-07-30T01:01:10.4196804Z running 122 tests
2019-07-30T01:01:35.7912911Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-30T01:01:40.7703432Z .i.i......iii.i.....ii
2019-07-30T01:01:40.7704176Z 
2019-07-30T01:01:40.7711742Z  finished in 30.527
2019-07-30T01:01:40.7720395Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:01:40.7720770Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-30T01:16:20.9986418Z 
2019-07-30T01:16:20.9991870Z    Doc-tests core
2019-07-30T01:16:25.3217896Z 
2019-07-30T01:16:25.3218740Z running 2379 tests
2019-07-30T01:16:38.3131508Z ......iiiii......................................................................................... 100/2379
2019-07-30T01:16:51.1093009Z .........................................................................ii......................... 200/2379
2019-07-30T01:17:22.2387433Z .................................................................................................... 400/2379
2019-07-30T01:17:22.2387433Z .................................................................................................... 400/2379
2019-07-30T01:17:34.0111113Z ..............................i..i.................iiii............................................. 500/2379
2019-07-30T01:17:59.3097351Z .................................................................................................... 700/2379
2019-07-30T01:18:11.7609997Z .................................................................................................... 800/2379
2019-07-30T01:18:24.4739785Z .................................................................................................... 900/2379
2019-07-30T01:18:36.9433892Z .................................................................................................... 1000/2379
---
2019-07-30T01:23:52.2969593Z .................................................................................................... 500/756
2019-07-30T01:23:52.3182257Z .............thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.3196188Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.3204096Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.3243378Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.5558844Z ...........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.5583224Z ....thread '.<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', .src/libcore/result.rs.:1084:5
2019-07-30T01:23:52.5598950Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libcore/result.rs:1084:5
2019-07-30T01:23:52.5696768Z ...................... 600/756
2019-07-30T01:23:54.5954082Z ....................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:629:13
2019-07-30T01:23:54.5954534Z thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:584:13
---
2019-07-30T01:24:04.0959215Z 
2019-07-30T01:24:04.0960222Z running 989 tests
2019-07-30T01:24:28.7378295Z i................................................................................................... 100/989
2019-07-30T01:24:42.4688836Z .................................................................................................... 200/989
2019-07-30T01:24:51.5890944Z .................iii......i......i...i......i....................................................... 300/989
2019-07-30T01:24:56.6224049Z .................................................................................................... 400/989
2019-07-30T01:25:05.0493078Z ................................i..i.................................ii............................. 500/989
2019-07-30T01:25:20.6597535Z .................................................................................................... 700/989
2019-07-30T01:25:20.6597535Z .................................................................................................... 700/989
2019-07-30T01:25:29.6183456Z ...............iiii................................................................................. 800/989
2019-07-30T01:25:44.7821968Z .................................................................................................... 900/989
2019-07-30T01:25:52.6947655Z .....................................iiii................................................
2019-07-30T01:25:52.6948595Z 
2019-07-30T01:25:52.7160815Z  finished in 250.265
2019-07-30T01:25:52.7178186Z Testing unwind stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:25:52.9115192Z     Finished release [optimized] target(s) in 0.19s
---
2019-07-30T01:46:25.0148330Z  finished in 35.257
2019-07-30T01:46:25.0485654Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T01:46:25.2167316Z 
2019-07-30T01:46:25.2168137Z running 199 tests
2019-07-30T01:47:02.7419012Z ....................i...ii................................................................i......... 100/199
2019-07-30T01:47:48.6024493Z ..............................iiii.......i..........iiii.iiiFF..................................i..
2019-07-30T01:47:48.6025732Z 
2019-07-30T01:47:48.6026261Z ---- [run-make] run-make-fulldeps/save-analysis stdout ----
2019-07-30T01:47:48.6026313Z 
2019-07-30T01:47:48.6026595Z error: make failed
2019-07-30T01:47:48.6026595Z error: make failed
2019-07-30T01:47:48.6026673Z status: exit code: 2
2019-07-30T01:47:48.6026754Z command: "make"
2019-07-30T01:47:48.6026813Z stdout:
2019-07-30T01:47:48.6027134Z ------------------------------------------
2019-07-30T01:47:48.6028322Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis/save-analysis:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis/save-analysis -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis/save-analysis  krate2.rs
2019-07-30T01:47:48.6028843Z Makefile:4: recipe for target 'krate2' failed
2019-07-30T01:47:48.6029410Z ------------------------------------------
2019-07-30T01:47:48.6029628Z stderr:
2019-07-30T01:47:48.6029931Z ------------------------------------------
2019-07-30T01:47:48.6030120Z error: unused `std::result::Result` that must be used
2019-07-30T01:47:48.6030120Z error: unused `std::result::Result` that must be used
2019-07-30T01:47:48.6030420Z  --> krate2.rs:7:5
2019-07-30T01:47:48.6030604Z   |
2019-07-30T01:47:48.6030803Z 7 |     std::io::stdout().write_all(b"hello world!\n");
2019-07-30T01:47:48.6030934Z   |
2019-07-30T01:47:48.6030934Z   |
2019-07-30T01:47:48.6031000Z   = note: `#[deny(unused_must_use)]` on by default
2019-07-30T01:47:48.6031086Z   = note: this `Result` may be an `Err` variant, which should be handled
2019-07-30T01:47:48.6031207Z error: aborting due to previous error
2019-07-30T01:47:48.6031269Z 
2019-07-30T01:47:48.6031269Z 
2019-07-30T01:47:48.6031328Z make: *** [krate2] Error 1
2019-07-30T01:47:48.6031682Z ------------------------------------------
2019-07-30T01:47:48.6031737Z 
2019-07-30T01:47:48.6031761Z 
2019-07-30T01:47:48.6031990Z ---- [run-make] run-make-fulldeps/save-analysis-fail stdout ----
2019-07-30T01:47:48.6031990Z ---- [run-make] run-make-fulldeps/save-analysis-fail stdout ----
2019-07-30T01:47:48.6032141Z 
2019-07-30T01:47:48.6032200Z error: make failed
2019-07-30T01:47:48.6032241Z status: exit code: 2
2019-07-30T01:47:48.6032282Z command: "make"
2019-07-30T01:47:48.6032340Z stdout:
2019-07-30T01:47:48.6032770Z ------------------------------------------
2019-07-30T01:47:48.6033739Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis-fail/save-analysis-fail:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis-fail/save-analysis-fail -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/save-analysis-fail/save-analysis-fail  krate2.rs
2019-07-30T01:47:48.6034234Z Makefile:4: recipe for target 'krate2' failed
2019-07-30T01:47:48.6034729Z ------------------------------------------
2019-07-30T01:47:48.6034777Z stderr:
2019-07-30T01:47:48.6035187Z ------------------------------------------
2019-07-30T01:47:48.6035499Z error: unused `std::result::Result` that must be used
2019-07-30T01:47:48.6035499Z error: unused `std::result::Result` that must be used
2019-07-30T01:47:48.6035766Z  --> krate2.rs:7:5
2019-07-30T01:47:48.6035828Z   |
2019-07-30T01:47:48.6036005Z 7 |     std::io::stdout().write_all(b"hello world!\n");
2019-07-30T01:47:48.6036404Z   |
2019-07-30T01:47:48.6036404Z   |
2019-07-30T01:47:48.6036476Z   = note: `#[deny(unused_must_use)]` on by default
2019-07-30T01:47:48.6036524Z   = note: this `Result` may be an `Err` variant, which should be handled
2019-07-30T01:47:48.6036738Z error: aborting due to previous error
2019-07-30T01:47:48.6036798Z 
2019-07-30T01:47:48.6036798Z 
2019-07-30T01:47:48.6036876Z make: *** [krate2] Error 1
2019-07-30T01:47:48.6037396Z ------------------------------------------
2019-07-30T01:47:48.6037431Z 
2019-07-30T01:47:48.6037604Z 
2019-07-30T01:47:48.6037758Z 
---
2019-07-30T01:47:48.6039728Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:533:22
2019-07-30T01:47:48.6039935Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-30T01:47:48.6040058Z 
2019-07-30T01:47:48.6040087Z 
2019-07-30T01:47:48.6045643Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--llvm-cxxflags" "-I/usr/lib/llvm-6.0/include -std=c++0x -fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG  -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-6.0/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-30T01:47:48.6047790Z 
2019-07-30T01:47:48.6058730Z 
2019-07-30T01:47:48.6058835Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-30T01:47:48.6058972Z Build completed unsuccessfully in 1:55:22
2019-07-30T01:47:48.6058972Z Build completed unsuccessfully in 1:55:22
2019-07-30T01:47:50.0425868Z ##[error]Bash exited with code '1'.
2019-07-30T01:47:50.0467418Z ##[section]Starting: Checkout
2019-07-30T01:47:50.0469777Z ==============================================================================
2019-07-30T01:47:50.0469843Z Task         : Get sources
2019-07-30T01:47:50.0469898Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2019

@bors try

@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

⌛️ Trying commit a9d2a6c with merge 5410d60...

bors added a commit that referenced this pull request Jul 30, 2019

Auto merge of #62262 - varkor:must_use-adt-components-ii, r=<try>
Extend `#[must_use]` to nested structures

Extends the `#[must_use]` lint to apply when `#[must_use]` types are nested within `struct`s (or one-variant `enum`s), making the lint much more generally useful. This is in line with #61100 extending the lint to tuples.

Fixes #39524.

cc @rust-lang/lang and @rust-lang/compiler for discussion in case this is a controversial change. In particular, we might want to consider allowing annotations on fields containing `#[must_use]` types in user-defined types (e.g. `#[allow(unused_must_use)]`) to opt out of this behaviour, if there are cases where we this this is likely to have frequent false positives.

(This is based on top of #62235.)
@bors

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

💔 Test failed - checks-azure

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2019

The job dist-x86_64-linux of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-30T16:17:16.9533491Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-30T16:17:16.9533568Z 
2019-07-30T16:17:16.9533896Z   git checkout -b <new-branch-name>
2019-07-30T16:17:16.9533946Z 
2019-07-30T16:17:16.9534276Z HEAD is now at 5410d604c Auto merge of #62262 - varkor:must_use-adt-components-ii, r=<try>
2019-07-30T16:17:16.9700722Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-30T16:17:16.9703993Z ==============================================================================
2019-07-30T16:17:16.9704093Z Task         : Bash
2019-07-30T16:17:16.9704189Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-30T18:29:31.5913943Z [RUSTC-TIMING] git2 test:false 10.693
2019-07-30T18:29:31.5926304Z    Compiling git2-curl v0.10.0
2019-07-30T18:29:32.8267108Z [RUSTC-TIMING] git2_curl test:false 1.229
2019-07-30T18:29:32.8287130Z    Compiling cargo v0.39.0 (/checkout/src/tools/cargo)
2019-07-30T18:29:47.6411104Z error: unused boxed boxed `std::ops::FnMut` trait object in field `socket` that must be used
2019-07-30T18:29:47.6412159Z   --> src/tools/cargo/src/cargo/ops/cargo_package.rs:47:9
2019-07-30T18:29:47.6412920Z    |
2019-07-30T18:29:47.6414103Z 47 |         ops::resolve_ws(ws)?;
2019-07-30T18:29:47.6415556Z    |
2019-07-30T18:29:47.6415556Z    |
2019-07-30T18:29:47.6416276Z    = note: `#[deny(unused_must_use)]` on by default
2019-07-30T18:29:47.6417036Z    = note: closures are lazy and do nothing unless called
2019-07-30T18:29:47.6417372Z 
2019-07-30T18:29:47.6418075Z error: unused boxed boxed `std::ops::FnMut` trait object in field `timer` that must be used
2019-07-30T18:29:47.6418823Z   --> src/tools/cargo/src/cargo/ops/cargo_package.rs:47:9
2019-07-30T18:29:47.6419464Z    |
2019-07-30T18:29:47.6420180Z 47 |         ops::resolve_ws(ws)?;
2019-07-30T18:29:47.6421643Z    |
2019-07-30T18:29:47.6421643Z    |
2019-07-30T18:29:47.6422328Z    = note: closures are lazy and do nothing unless called
2019-07-30T18:29:47.8385643Z error: aborting due to 2 previous errors
2019-07-30T18:29:47.8386359Z 
2019-07-30T18:29:47.9596612Z [RUSTC-TIMING] cargo test:false 15.125
2019-07-30T18:29:47.9687460Z error: Could not compile `cargo`.
2019-07-30T18:29:47.9687460Z error: Could not compile `cargo`.
2019-07-30T18:29:47.9687550Z 
2019-07-30T18:29:47.9687926Z To learn more, run the command again with --verbose.
2019-07-30T18:29:47.9713139Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
2019-07-30T18:29:47.9713464Z expected success, got: exit code: 101
2019-07-30T18:29:47.9734975Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
2019-07-30T18:29:47.9735141Z Build completed unsuccessfully in 2:05:09
2019-07-30T18:29:48.7617013Z ##[error]Bash exited with code '1'.
2019-07-30T18:29:48.7650450Z ##[section]Starting: Upload CPU usage statistics
2019-07-30T18:29:48.7659062Z ==============================================================================
2019-07-30T18:29:48.7659156Z Task         : Bash
2019-07-30T18:29:48.7659243Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril removed the I-nominated label Aug 1, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

☔️ The latest upstream changes (presumably #59369) made this pull request unmergeable. Please resolve the merge conflicts.

@gagan0723

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Ping from triage, @varkor any update on this?

Some tests are failing and this PR has merge conflicts that needs to be resolved.

@varkor

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

I'm meaning to get back to this, but it may take me a couple of weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.