-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 16 pull requests #62294
Rollup of 16 pull requests #62294
Commits on Jun 16, 2019
-
in which the
non_ascii_idents
lint appears (RFC 2457)RFC 2457 declares: "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default."
Configuration menu - View commit details
-
Copy full SHA for 0ae61d8 - Browse repository at this point
Copy the full SHA 0ae61d8View commit details
Commits on Jun 24, 2019
-
Configuration menu - View commit details
-
Copy full SHA for bb26e07 - Browse repository at this point
Copy the full SHA bb26e07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0533f12 - Browse repository at this point
Copy the full SHA 0533f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a4573f - Browse repository at this point
Copy the full SHA 8a4573fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4159b27 - Browse repository at this point
Copy the full SHA 4159b27View commit details
Commits on Jun 25, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a68afc5 - Browse repository at this point
Copy the full SHA a68afc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3e1bf9 - Browse repository at this point
Copy the full SHA d3e1bf9View commit details
Commits on Jun 26, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 7262e64 - Browse repository at this point
Copy the full SHA 7262e64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a8a552 - Browse repository at this point
Copy the full SHA 4a8a552View commit details -
Add RequiresStorage pass to decide which locals to save in generators
This avoids reserving storage in generators for locals that are moved out of (and not re-initialized) prior to yield points.
Configuration menu - View commit details
-
Copy full SHA for 9969417 - Browse repository at this point
Copy the full SHA 9969417View commit details -
Configuration menu - View commit details
-
Copy full SHA for c932518 - Browse repository at this point
Copy the full SHA c932518View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8465daf - Browse repository at this point
Copy the full SHA 8465dafView commit details
Commits on Jun 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b2aeb0f - Browse repository at this point
Copy the full SHA b2aeb0fView commit details -
std: Move a process test out of libstd
This commit moves a test out of libstd which is causing deadlocks on musl on CI. Looks like the recent update in musl versions brings in some internal updates to musl which makes `setgid` and `setuid` invalid to call after a `fork` in a multithreaded program. The issue seen here is that the child thread was attempting to grab a lock held by a nonexistent thread, meaning that the child process simply deadlocked causing the whole test to deadlock. This commit moves the test to its own file with no threads which should work.
Configuration menu - View commit details
-
Copy full SHA for 2a37582 - Browse repository at this point
Copy the full SHA 2a37582View commit details
Commits on Jun 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a0e5fcf - Browse repository at this point
Copy the full SHA a0e5fcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9527565 - Browse repository at this point
Copy the full SHA 9527565View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11b09e7 - Browse repository at this point
Copy the full SHA 11b09e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for aee1357 - Browse repository at this point
Copy the full SHA aee1357View commit details
Commits on Jun 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d8ed2e7 - Browse repository at this point
Copy the full SHA d8ed2e7View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e2d7df5 - Browse repository at this point
Copy the full SHA e2d7df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 209bde1 - Browse repository at this point
Copy the full SHA 209bde1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aff8af - Browse repository at this point
Copy the full SHA 1aff8afView commit details -
Remove io::Result from syntax::print
Since we're now writing directly to the vector, there's no need to thread results through the whole printing infrastructure
Configuration menu - View commit details
-
Copy full SHA for da5c835 - Browse repository at this point
Copy the full SHA da5c835View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff27756 - Browse repository at this point
Copy the full SHA ff27756View commit details -
Configuration menu - View commit details
-
Copy full SHA for d26c4b7 - Browse repository at this point
Copy the full SHA d26c4b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d4c642 - Browse repository at this point
Copy the full SHA 6d4c642View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb9f5b - Browse repository at this point
Copy the full SHA dfb9f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e83728 - Browse repository at this point
Copy the full SHA 3e83728View commit details
Commits on Jun 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 9e2714a - Browse repository at this point
Copy the full SHA 9e2714aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ffb643 - Browse repository at this point
Copy the full SHA 0ffb643View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4e7eb2 - Browse repository at this point
Copy the full SHA e4e7eb2View commit details
Commits on Jul 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for ac4e109 - Browse repository at this point
Copy the full SHA ac4e109View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e184ec - Browse repository at this point
Copy the full SHA 4e184ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01d8121 - Browse repository at this point
Copy the full SHA 01d8121View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3dda49 - Browse repository at this point
Copy the full SHA a3dda49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69e8a77 - Browse repository at this point
Copy the full SHA 69e8a77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 856b427 - Browse repository at this point
Copy the full SHA 856b427View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1552d8d - Browse repository at this point
Copy the full SHA 1552d8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c2d6b - Browse repository at this point
Copy the full SHA 17c2d6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bee0fb - Browse repository at this point
Copy the full SHA 0bee0fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f6aa7 - Browse repository at this point
Copy the full SHA 37f6aa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c221b3 - Browse repository at this point
Copy the full SHA 4c221b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e5f6c7 - Browse repository at this point
Copy the full SHA 7e5f6c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25a9206 - Browse repository at this point
Copy the full SHA 25a9206View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6374cf - Browse repository at this point
Copy the full SHA c6374cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 734d31a - Browse repository at this point
Copy the full SHA 734d31aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a68e2c7 - Browse repository at this point
Copy the full SHA a68e2c7View commit details
Commits on Jul 2, 2019
-
Rollup merge of rust-lang#61871 - Zoxc:no-lift-branch, r=eddyb
Don't use lift to detect local types This overlaps with rust-lang#61392. r? @eddyb
Configuration menu - View commit details
-
Copy full SHA for e58fbbb - Browse repository at this point
Copy the full SHA e58fbbbView commit details -
Rollup merge of rust-lang#61883 - zackmdavis:non_ascii_idents_lint, r…
…=Manishearth `non_ascii_idents` lint (part of RFC 2457) RFC 2457 [declares](https://github.com/rust-lang/rfcs/blob/121bbeff500c3274cea22c7e0ca176274d592646/text/2457-non-ascii-idents.md): "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default." (Part of rust-lang#55467.) r? @Manishearth
Configuration menu - View commit details
-
Copy full SHA for af4b62b - Browse repository at this point
Copy the full SHA af4b62bView commit details -
Rollup merge of rust-lang#61922 - tmandry:moar-generator-optimization…
…, r=matthewjasper Don't store locals that have been moved from in generators This avoids reserving storage in generators for locals that are moved out of (and not re-initialized) prior to yield points. Fixes rust-lang#59123. This adds a new dataflow analysis, `RequiresStorage`, to determine whether the storage of a local can be destroyed without being observed by the program. The rules are: 1. StorageLive(x) => mark x live 2. StorageDead(x) => mark x dead 3. If a local is moved from, _and has never had its address taken_, mark it dead 4. If (any part of) a local is initialized, mark it live' This is used to determine whether to save a local in the generator object at all, as well as which locals can be overlapped in the generator layout. Here's the size in bytes of all testcases included in the change, before and after the change: async fn test |Size before |Size after -----------------|------------|---------- single | 1028 | 1028 single_with_noop | 2056 | 1032 joined | 5132 | 3084 joined_with_noop | 8208 | 3084 generator test |Size before |Size after ----------------------------|------------|---------- move_before_yield | 1028 | 1028 move_before_yield_with_noop | 2056 | 1032 overlap_move_points | 3080 | 2056 ## Future work Note that there is a possible extension to this optimization, which modifies rule 3 to read: "If a local is moved from, _**and either has never had its address taken, or is Freeze and has never been mutably borrowed**_, mark it dead." This was discussed at length in rust-lang#59123 and then rust-lang#61849. Because this would cause some behavior to be UB which was not UB before, it's a step that needs to be taken carefully. A more immediate priority for me is inlining `std::mem::size_of_val(&x)` so it becomes apparent that the address of `x` is not taken. This way, using `size_of_val` to look at the size of your inner futures does not affect the size of your outer future. cc @cramertj @eddyb @Matthias247 @nikomatsakis @RalfJung @Zoxc
Configuration menu - View commit details
-
Copy full SHA for 2a2d71f - Browse repository at this point
Copy the full SHA 2a2d71fView commit details -
Rollup merge of rust-lang#61995 - eddyb:hir-sep-ptr, r=petrochenkov
rustc: use a separate copy of P for HIR than for AST. Note: this currently includes/is based on top of rust-lang#61987. Like rust-lang#61968, but goes one step further and uses a separate `P<...>` for the HIR, with no `Clone`, or the ability to mutate after allocation. There is still `into_inner`/`into_iter`, but they're only exposed for `hir::lowering`, and they would take more work to untangle. r? @petrochenkov cc @rust-lang/compiler
Configuration menu - View commit details
-
Copy full SHA for e3204bc - Browse repository at this point
Copy the full SHA e3204bcView commit details -
Rollup merge of rust-lang#62026 - mati865:deps, r=alexcrichton
Final nail in `rand 0.4` coffin Closes rust-lang#57724
Configuration menu - View commit details
-
Copy full SHA for e988c42 - Browse repository at this point
Copy the full SHA e988c42View commit details -
Rollup merge of rust-lang#62039 - jeremystucki:needless_lifetimes, r=…
…eddyb Remove needless lifetimes (rustc)
Configuration menu - View commit details
-
Copy full SHA for 1381760 - Browse repository at this point
Copy the full SHA 1381760View commit details -
Rollup merge of rust-lang#62099 - Mark-Simulacrum:syntax-print-clean-…
…2, r=eddyb Remove io::Result from syntax::print Since we're now writing directly to the vector, there's no need to thread results through the whole printing infrastructure
Configuration menu - View commit details
-
Copy full SHA for 77124e3 - Browse repository at this point
Copy the full SHA 77124e3View commit details -
Rollup merge of rust-lang#62103 - RalfJung:debug-assert, r=alexcrichton
Add debug assertions to write_bytes and copy* Looks like @nitnelave went MIA in rust-lang#58783, so I am re-submitting their PR, tweaked just a bit. I took care to preserve commit authorship. Cc rust-lang#53871
Configuration menu - View commit details
-
Copy full SHA for 7982092 - Browse repository at this point
Copy the full SHA 7982092View commit details -
Rollup merge of rust-lang#62133 - petrochenkov:norustc, r=eddyb
Feature gate `rustc` attributes harder Fixes rust-lang#62116
Configuration menu - View commit details
-
Copy full SHA for 62b38c1 - Browse repository at this point
Copy the full SHA 62b38c1View commit details -
Rollup merge of rust-lang#62161 - GuillaumeGomez:add-missing-tryfrom-…
…links, r=docs Add missing links for TryFrom docs r? @rust-lang/docs
Configuration menu - View commit details
-
Copy full SHA for b9d4b3b - Browse repository at this point
Copy the full SHA b9d4b3bView commit details -
Rollup merge of rust-lang#62177 - Centril:move-some-compile-fail-test…
…s, r=petrochenkov Move some tests in src/test/compile-fail -> src/test/ui This is a subset of rust-lang#62113. Hopefully everything here sticks, but if it doesn't I'll remove tests until it does. r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for 42d0eb5 - Browse repository at this point
Copy the full SHA 42d0eb5View commit details -
Rollup merge of rust-lang#62183 - alexcrichton:fix-tests, r=nikomatsakis
std: Move a process test out of libstd This commit moves a test out of libstd which is causing deadlocks on musl on CI. Looks like the recent update in musl versions brings in some internal updates to musl which makes `setgid` and `setuid` invalid to call after a `fork` in a multithreaded program. The issue seen here is that the child thread was attempting to grab a lock held by a nonexistent thread, meaning that the child process simply deadlocked causing the whole test to deadlock. This commit moves the test to its own file with no threads which should work.
Configuration menu - View commit details
-
Copy full SHA for 99d52f7 - Browse repository at this point
Copy the full SHA 99d52f7View commit details -
Rollup merge of rust-lang#62186 - GuillaumeGomez:add-missing-type-lin…
…ks-into, r=docs Add missing type urls in Into trait r? @rust-lang/docs
Configuration menu - View commit details
-
Copy full SHA for 179ed23 - Browse repository at this point
Copy the full SHA 179ed23View commit details -
Rollup merge of rust-lang#62196 - cramertj:vec-leak, r=centril,withou…
…tboats Add Vec::leak
Configuration menu - View commit details
-
Copy full SHA for 91376ec - Browse repository at this point
Copy the full SHA 91376ecView commit details -
Rollup merge of rust-lang#62199 - cclauss:patch-1, r=nikomatsakis
import gdb for explicit access to gdb.current_objfile()
Configuration menu - View commit details
-
Copy full SHA for eef6248 - Browse repository at this point
Copy the full SHA eef6248View commit details -
Rollup merge of rust-lang#62244 - topecongiro:rustfmt-1.3.1, r=alexcr…
…ichton Update rustfmt to 1.3.1 [Changelog](https://github.com/rust-lang/rustfmt/blob/master/CHANGELOG.md#131-2019-06-30).
Configuration menu - View commit details
-
Copy full SHA for fddcb19 - Browse repository at this point
Copy the full SHA fddcb19View commit details