Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option::expect_none(msg) and unwrap_none() #62596

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Add Option::expect_none(msg) and unwrap_none() #62596

merged 3 commits into from
Jul 17, 2019

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 11, 2019

These are Option analogues to Result::expect_err and unwrap_err.

@cuviper
Add Option::expect_none(msg) and unwrap_none()
5a7e730 
These are `Option` analogues to `Result::expect_err` and `unwrap_err`.
@rust-highfive
Copy link
Collaborator

r? @rkruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2019
@cuviper
Copy link
Member Author

cuviper commented Jul 11, 2019

See also: https://internals.rust-lang.org/t/adding-option-expect-none/10481

@cuviper cuviper mentioned this pull request Jul 11, 2019
Merged
sfackler
sfackler reviewed Jul 11, 2019
View reviewed changes
src/libcore/option.rs Outdated Show resolved Hide resolved
scottmcm
scottmcm reviewed Jul 11, 2019
View reviewed changes
src/libcore/option.rs Outdated Show resolved Hide resolved
@cuviper cuviper mentioned this pull request Jul 12, 2019
Closed
3 tasks
@hanna-kruppe
Copy link
Contributor

Code LGTM. I'm always unsure about policy wrt small unstable library addition, should there be some sign-off from T-libs too?

@cuviper
Copy link
Member Author

cuviper commented Jul 15, 2019

I'm always unsure about policy wrt small unstable library addition, should there be some sign-off from T-libs too?

I think it's laid back until stabilization, but we can ping @rust-lang/libs...

@alexcrichton
Copy link
Member

Yes we are generally pretty lax so long as 2 people (author/reviewer) think it should go in libstd it can land as unstable, and then we have stricter requirements for stabilizing. This seems like it still falls in that bucket at least to me.

@hanna-kruppe
Copy link
Contributor

Cool, thanks for clarifying!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2019

📌 Commit 74c8d98 has been approved by rkruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2019
@bors
Copy link
Contributor

bors commented Jul 17, 2019

⌛ Testing commit 74c8d98 with merge d56128d...

bors added a commit that referenced this pull request Jul 17, 2019
@bors
Auto merge of #62596 - cuviper:expect_none, r=rkruppe
d56128d 
Add Option::expect_none(msg) and unwrap_none()

These are `Option` analogues to `Result::expect_err` and `unwrap_err`.
@bors
Copy link
Contributor

bors commented Jul 17, 2019

☀️ Test successful - checks-azure
Approved by: rkruppe
Pushing d56128d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2019
@bors bors merged commit 74c8d98 into rust-lang:master Jul 17, 2019
@bryanburgers-bot
Copy link

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors mentioned this pull request Jul 17, 2019
Merged
@cramertj cramertj mentioned this pull request Aug 13, 2019
Merged
@cuviper cuviper deleted the expect_none branch April 3, 2020 18:40
@cuviper cuviper mentioned this pull request Jun 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@sfackler sfackler sfackler left review comments

@scottmcm scottmcm scottmcm left review comments

Assignees

@hanna-kruppe hanna-kruppe

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cuviper @rust-highfive @hanna-kruppe @alexcrichton @bors @bryanburgers-bot @Centril @sfackler @scottmcm