Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for -Zlower-128bit-ops #62801

Merged
merged 3 commits into from Jul 26, 2019

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jul 19, 2019

It is broken and unused

cc #58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton

It is broken and unused
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-19T14:05:54.7199428Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-19T14:05:54.7365637Z ##[command]git config gc.auto 0
2019-07-19T14:05:54.7420297Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-19T14:05:54.7468863Z ##[command]git config --get-all http.proxy
2019-07-19T14:05:54.7596240Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62801/merge:refs/remotes/pull/62801/merge
---
2019-07-19T14:06:28.5853267Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-19T14:06:28.5853363Z 
2019-07-19T14:06:28.5853599Z   git checkout -b <new-branch-name>
2019-07-19T14:06:28.5853629Z 
2019-07-19T14:06:28.5853679Z HEAD is now at e91545633 Merge 3427a14bdf19437c455e54af704e0250ea8aa79b into f9477a77c52af8d3dea361b3f4ac3e60653aa529
2019-07-19T14:06:28.5990759Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-19T14:06:28.5993678Z ==============================================================================
2019-07-19T14:06:28.5993740Z Task         : Bash
2019-07-19T14:06:28.5993808Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-19T14:36:47.8877949Z    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
2019-07-19T14:36:48.5330715Z    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
2019-07-19T14:36:49.1847875Z    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
2019-07-19T14:36:50.0408171Z    Compiling rustc-std-workspace-core v1.0.0 (/checkout/src/tools/rustc-std-workspace-core)
2019-07-19T14:36:50.1960617Z error[E0522]: definition of an unknown language item: `i128_add`
2019-07-19T14:36:50.1968023Z    |
2019-07-19T14:36:50.1973258Z 94 | |     (
2019-07-19T14:36:50.1973258Z 94 | |     (
2019-07-19T14:36:50.1975464Z    | |_______________________^ definition of unknown language item `i128_add`
2019-07-19T14:36:50.1980111Z ...
2019-07-19T14:36:50.2023937Z 291|           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2025094Z 
2019-07-19T14:36:50.2025094Z 
2019-07-19T14:36:50.2025458Z error[E0522]: definition of an unknown language item: `i128_addo`
2019-07-19T14:36:50.2026005Z    |
2019-07-19T14:36:50.2026005Z    |
2019-07-19T14:36:50.2026337Z 98 | |             $($body:tt)*
2019-07-19T14:36:50.2026688Z    | |________________________^ definition of unknown language item `i128_addo`
2019-07-19T14:36:50.2027985Z ...
2019-07-19T14:36:50.2028268Z 291|           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2028593Z 
2019-07-19T14:36:50.2028593Z 
2019-07-19T14:36:50.2028854Z error[E0522]: definition of an unknown language item: `u128_add`
2019-07-19T14:36:50.2029319Z     |
2019-07-19T14:36:50.2029598Z 104 | |         intrinsics! {
2019-07-19T14:36:50.2029598Z 104 | |         intrinsics! {
2019-07-19T14:36:50.2030029Z     | |_______________________^ definition of unknown language item `u128_add`
2019-07-19T14:36:50.2030273Z ...
2019-07-19T14:36:50.2030560Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2030898Z 
2019-07-19T14:36:50.2030898Z 
2019-07-19T14:36:50.2031136Z error[E0522]: definition of an unknown language item: `u128_addo`
2019-07-19T14:36:50.2031621Z     |
2019-07-19T14:36:50.2031875Z 108 | |             }
2019-07-19T14:36:50.2031875Z 108 | |             }
2019-07-19T14:36:50.2032177Z     | |________________________^ definition of unknown language item `u128_addo`
2019-07-19T14:36:50.2032379Z ...
2019-07-19T14:36:50.2032662Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2032995Z 
2019-07-19T14:36:50.2032995Z 
2019-07-19T14:36:50.2033884Z error[E0522]: definition of an unknown language item: `i128_sub`
2019-07-19T14:36:50.2034472Z     |
2019-07-19T14:36:50.2034472Z     |
2019-07-19T14:36:50.2034785Z 115 | |                 $($body)*
2019-07-19T14:36:50.2035128Z     | |_______________________^ definition of unknown language item `i128_sub`
2019-07-19T14:36:50.2035488Z ...
2019-07-19T14:36:50.2035814Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2036183Z 
2019-07-19T14:36:50.2036183Z 
2019-07-19T14:36:50.2036452Z error[E0522]: definition of an unknown language item: `i128_subo`
2019-07-19T14:36:50.2037678Z     |
2019-07-19T14:36:50.2037678Z     |
2019-07-19T14:36:50.2037988Z 119 | |         intrinsics!($($rest)*);
2019-07-19T14:36:50.2038327Z     | |________________________^ definition of unknown language item `i128_subo`
2019-07-19T14:36:50.2038563Z ...
2019-07-19T14:36:50.2038885Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2039252Z 
2019-07-19T14:36:50.2039252Z 
2019-07-19T14:36:50.2039519Z error[E0522]: definition of an unknown language item: `u128_sub`
2019-07-19T14:36:50.2040179Z     |
2019-07-19T14:36:50.2040481Z 125 | |         #[unadjusted_on_win64]
2019-07-19T14:36:50.2040481Z 125 | |         #[unadjusted_on_win64]
2019-07-19T14:36:50.2040832Z     | |_______________________^ definition of unknown language item `u128_sub`
2019-07-19T14:36:50.2041217Z ...
2019-07-19T14:36:50.2041850Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2042172Z 
2019-07-19T14:36:50.2042172Z 
2019-07-19T14:36:50.2042415Z error[E0522]: definition of an unknown language item: `u128_subo`
2019-07-19T14:36:50.2043259Z     |
2019-07-19T14:36:50.2043850Z 129 | |         }
2019-07-19T14:36:50.2043850Z 129 | |         }
2019-07-19T14:36:50.2044191Z     | |________________________^ definition of unknown language item `u128_subo`
2019-07-19T14:36:50.2044421Z ...
2019-07-19T14:36:50.2044740Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2045114Z 
2019-07-19T14:36:50.2045114Z 
2019-07-19T14:36:50.2045388Z error[E0522]: definition of an unknown language item: `i128_mul`
2019-07-19T14:36:50.2046064Z     |
2019-07-19T14:36:50.2046064Z     |
2019-07-19T14:36:50.2046366Z 113 | |             $(#[$($attr)*])*
2019-07-19T14:36:50.2046703Z     | |_______________________^ definition of unknown language item `i128_mul`
2019-07-19T14:36:50.2047122Z ...
2019-07-19T14:36:50.2047401Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2047736Z 
2019-07-19T14:36:50.2047736Z 
2019-07-19T14:36:50.2047974Z error[E0522]: definition of an unknown language item: `i128_mulo`
2019-07-19T14:36:50.2048473Z     |
2019-07-19T14:36:50.2048716Z 117 | |         }
2019-07-19T14:36:50.2048716Z 117 | |         }
2019-07-19T14:36:50.2049010Z     | |________________________^ definition of unknown language item `i128_mulo`
2019-07-19T14:36:50.2049212Z ...
2019-07-19T14:36:50.2049552Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2049904Z 
2019-07-19T14:36:50.2049904Z 
2019-07-19T14:36:50.2050141Z error[E0522]: definition of an unknown language item: `u128_mul`
2019-07-19T14:36:50.2050635Z     |
2019-07-19T14:36:50.2050635Z     |
2019-07-19T14:36:50.2050895Z 123 | |     // win64 for some methods.
2019-07-19T14:36:50.2051204Z     | |_______________________^ definition of unknown language item `u128_mul`
2019-07-19T14:36:50.2051388Z ...
2019-07-19T14:36:50.2051673Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2052004Z 
2019-07-19T14:36:50.2052004Z 
2019-07-19T14:36:50.2052240Z error[E0522]: definition of an unknown language item: `u128_mulo`
2019-07-19T14:36:50.2052727Z     |
2019-07-19T14:36:50.2052727Z     |
2019-07-19T14:36:50.2053044Z 127 | |         pub extern $abi:tt fn $name:ident( $($argname:ident:  $ty:ty),* ) -> $ret:ty {
2019-07-19T14:36:50.2053780Z     | |________________________^ definition of unknown language item `u128_mulo`
2019-07-19T14:36:50.2054006Z ...
2019-07-19T14:36:50.2054327Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2054829Z 
2019-07-19T14:36:50.2054829Z 
2019-07-19T14:36:50.2055100Z error[E0522]: definition of an unknown language item: `i128_div`
2019-07-19T14:36:50.2055658Z     |
2019-07-19T14:36:50.2055950Z 104 | |         intrinsics! {
2019-07-19T14:36:50.2055950Z 104 | |         intrinsics! {
2019-07-19T14:36:50.2056315Z     | |_______________________^ definition of unknown language item `i128_div`
2019-07-19T14:36:50.2056528Z ...
2019-07-19T14:36:50.2057005Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2057500Z 
2019-07-19T14:36:50.2057500Z 
2019-07-19T14:36:50.2057725Z error[E0522]: definition of an unknown language item: `i128_rem`
2019-07-19T14:36:50.2058194Z     |
2019-07-19T14:36:50.2058496Z 108 | |             }
2019-07-19T14:36:50.2058496Z 108 | |             }
2019-07-19T14:36:50.2070269Z     | |_______________________^ definition of unknown language item `i128_rem`
2019-07-19T14:36:50.2070527Z ...
2019-07-19T14:36:50.2071025Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2071528Z 
2019-07-19T14:36:50.2071528Z 
2019-07-19T14:36:50.2071763Z error[E0522]: definition of an unknown language item: `i128_shl`
2019-07-19T14:36:50.2072260Z     |
2019-07-19T14:36:50.2072508Z 109 | |         }
2019-07-19T14:36:50.2072508Z 109 | |         }
2019-07-19T14:36:50.2072981Z     | |_______________________^ definition of unknown language item `i128_shl`
2019-07-19T14:36:50.2073626Z ...
2019-07-19T14:36:50.2073959Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2074334Z 
2019-07-19T14:36:50.2074334Z 
2019-07-19T14:36:50.2074601Z error[E0522]: definition of an unknown language item: `i128_shlo`
2019-07-19T14:36:50.2075171Z     |
2019-07-19T14:36:50.2075171Z     |
2019-07-19T14:36:50.2075472Z 113 | |             $(#[$($attr)*])*
2019-07-19T14:36:50.2076064Z     | |________________________^ definition of unknown language item `i128_shlo`
2019-07-19T14:36:50.2076278Z ...
2019-07-19T14:36:50.2078194Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2078586Z 
2019-07-19T14:36:50.2078586Z 
2019-07-19T14:36:50.2078812Z error[E0522]: definition of an unknown language item: `u128_shl`
2019-07-19T14:36:50.2079465Z     |
2019-07-19T14:36:50.2079746Z 117 | |         }
2019-07-19T14:36:50.2079746Z 117 | |         }
2019-07-19T14:36:50.2080064Z     | |_______________________^ definition of unknown language item `u128_shl`
2019-07-19T14:36:50.2080239Z ...
2019-07-19T14:36:50.2080512Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2080831Z 
2019-07-19T14:36:50.2080831Z 
2019-07-19T14:36:50.2081196Z error[E0522]: definition of an unknown language item: `u128_shlo`
2019-07-19T14:36:50.2081718Z     |
2019-07-19T14:36:50.2081946Z 121 | |
2019-07-19T14:36:50.2081946Z 121 | |
2019-07-19T14:36:50.2082252Z     | |________________________^ definition of unknown language item `u128_shlo`
2019-07-19T14:36:50.2082429Z ...
2019-07-19T14:36:50.2082699Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2083030Z 
2019-07-19T14:36:50.2083030Z 
2019-07-19T14:36:50.2083258Z error[E0522]: definition of an unknown language item: `i128_shr`
2019-07-19T14:36:50.2084244Z     |
2019-07-19T14:36:50.2084244Z     |
2019-07-19T14:36:50.2084550Z 126 | |         $(#[$($attr:tt)*])*
2019-07-19T14:36:50.2084917Z     | |_______________________^ definition of unknown language item `i128_shr`
2019-07-19T14:36:50.2085125Z ...
2019-07-19T14:36:50.2085462Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2085834Z 
2019-07-19T14:36:50.2085834Z 
2019-07-19T14:36:50.2086106Z error[E0522]: definition of an unknown language item: `i128_shro`
2019-07-19T14:36:50.2086806Z     |
2019-07-19T14:36:50.2087300Z 130 | |
2019-07-19T14:36:50.2087300Z 130 | |
2019-07-19T14:36:50.2088087Z     | |________________________^ definition of unknown language item `i128_shro`
2019-07-19T14:36:50.2088444Z ...
2019-07-19T14:36:50.2088768Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2089102Z 
2019-07-19T14:36:50.2089102Z 
2019-07-19T14:36:50.2089351Z error[E0522]: definition of an unknown language item: `u128_shr`
2019-07-19T14:36:50.2089879Z     |
2019-07-19T14:36:50.2090472Z 134 | |         intrinsics! {
2019-07-19T14:36:50.2090472Z 134 | |         intrinsics! {
2019-07-19T14:36:50.2090946Z     | |_______________________^ definition of unknown language item `u128_shr`
2019-07-19T14:36:50.2091123Z ...
2019-07-19T14:36:50.2091499Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2091844Z 
2019-07-19T14:36:50.2091844Z 
2019-07-19T14:36:50.2092158Z error[E0522]: definition of an unknown language item: `u128_shro`
2019-07-19T14:36:50.2092613Z     |
2019-07-19T14:36:50.2092869Z 138 | |             }
2019-07-19T14:36:50.2092869Z 138 | |             }
2019-07-19T14:36:50.2093155Z     | |________________________^ definition of unknown language item `u128_shro`
2019-07-19T14:36:50.2093335Z ...
2019-07-19T14:36:50.2094205Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2094576Z 
2019-07-19T14:36:50.2094576Z 
2019-07-19T14:36:50.2094863Z error[E0522]: definition of an unknown language item: `u128_div`
2019-07-19T14:36:50.2095399Z     |
2019-07-19T14:36:50.2095702Z 273 | |         }
2019-07-19T14:36:50.2095702Z 273 | |         }
2019-07-19T14:36:50.2096046Z     | |_______________________^ definition of unknown language item `u128_div`
2019-07-19T14:36:50.2096255Z ...
2019-07-19T14:36:50.2096594Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2097223Z 
2019-07-19T14:36:50.2097223Z 
2019-07-19T14:36:50.2097464Z error[E0522]: definition of an unknown language item: `u128_rem`
2019-07-19T14:36:50.2097901Z     |
2019-07-19T14:36:50.2097901Z     |
2019-07-19T14:36:50.2098170Z 277 | |         fn from(i: u128) -> U64x2 {
2019-07-19T14:36:50.2098455Z     | |_______________________^ definition of unknown language item `u128_rem`
2019-07-19T14:36:50.2098624Z ...
2019-07-19T14:36:50.2099111Z 291 |           #[cfg_attr(not(any(stage0, feature = "no-lang-items")), lang = $lang)]
2019-07-19T14:36:50.2102961Z 
2019-07-19T14:36:51.0142387Z error: aborting due to 24 previous errors
2019-07-19T14:36:51.0142487Z 
2019-07-19T14:36:51.0142763Z For more information about this error, try `rustc --explain E0522`.
2019-07-19T14:36:51.0142763Z For more information about this error, try `rustc --explain E0522`.
2019-07-19T14:36:51.0216630Z error: Could not compile `compiler_builtins`.
2019-07-19T14:36:51.0217351Z warning: build failed, waiting for other jobs to finish...
2019-07-19T14:36:51.6614015Z error: build failed
2019-07-19T14:36:51.6633144Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
2019-07-19T14:36:51.6633818Z expected success, got: exit code: 101
2019-07-19T14:36:51.6640551Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-19T14:36:51.6640829Z Build completed unsuccessfully in 0:23:58
2019-07-19T14:36:54.4394124Z ##[error]Bash exited with code '1'.
2019-07-19T14:36:54.4461615Z ##[section]Starting: Checkout
2019-07-19T14:36:54.4463854Z ==============================================================================
2019-07-19T14:36:54.4463921Z Task         : Get sources
2019-07-19T14:36:54.4463972Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

r=me with the included compiler-builtins update now!

@scottmcm
Copy link
Member

As the author of this code, I'm glad to see it being removed 😎

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 20, 2019

Done

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-20T09:27:52.2616228Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-20T09:27:52.2797885Z ##[command]git config gc.auto 0
2019-07-20T09:27:52.2878649Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-20T09:27:52.2937885Z ##[command]git config --get-all http.proxy
2019-07-20T09:27:52.3084272Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62801/merge:refs/remotes/pull/62801/merge
---
2019-07-20T09:28:25.9494649Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-20T09:28:25.9494672Z 
2019-07-20T09:28:25.9508854Z   git checkout -b <new-branch-name>
2019-07-20T09:28:25.9510464Z 
2019-07-20T09:28:25.9511706Z HEAD is now at a1e06aedb Merge e8a1e73ff5fa0b2a085aa23d013c536c4e7c9675 into e9d22273283dce210b26362aa0dcc3fc10bf7e81
2019-07-20T09:28:25.9647511Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-20T09:28:25.9650407Z ==============================================================================
2019-07-20T09:28:25.9650469Z Task         : Bash
2019-07-20T09:28:25.9650537Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-20T10:28:12.4379954Z .................................................................................................... 200/5839
2019-07-20T10:28:16.7285853Z .................................................................................................... 300/5839
2019-07-20T10:28:20.4567043Z .................................................................................................... 400/5839
2019-07-20T10:28:24.1997746Z .................................................................................................... 500/5839
2019-07-20T10:28:27.9653548Z ........................................................................i........................... 600/5839
2019-07-20T10:28:36.7963774Z .................................................................................................... 800/5839
2019-07-20T10:28:42.3632147Z .................................................................................................... 900/5839
2019-07-20T10:28:47.2506742Z ...................................................................................................i 1000/5839
2019-07-20T10:28:47.2506742Z ...................................................................................................i 1000/5839
2019-07-20T10:28:52.5897070Z ...........i........................................................................................ 1100/5839
2019-07-20T10:28:56.4273515Z .............................iiiii.................................................................. 1200/5839
2019-07-20T10:29:02.2329511Z .................................................................................................... 1400/5839
2019-07-20T10:29:05.0882316Z .................................................................................................... 1500/5839
2019-07-20T10:29:08.9653333Z .................................................................................................... 1600/5839
2019-07-20T10:29:11.6370487Z .................................................................................................... 1700/5839
2019-07-20T10:29:11.6370487Z .................................................................................................... 1700/5839
2019-07-20T10:29:15.3069664Z ...................................................................i................................ 1800/5839
2019-07-20T10:29:23.8784356Z .................................................................................................... 2000/5839
2019-07-20T10:29:28.1390058Z .................................................................................................... 2100/5839
2019-07-20T10:29:31.8173897Z .................................................................................................... 2200/5839
2019-07-20T10:29:31.8173897Z .................................................................................................... 2200/5839
2019-07-20T10:29:35.5155024Z ..................................................i................................................. 2300/5839
2019-07-20T10:29:44.9128037Z .................................................................................................... 2500/5839
2019-07-20T10:29:48.9853696Z .................................................................................................... 2600/5839
2019-07-20T10:29:53.9569479Z .................................................................................................... 2700/5839
2019-07-20T10:29:57.8718803Z .................................................................................................... 2800/5839
2019-07-20T10:29:57.8718803Z .................................................................................................... 2800/5839
2019-07-20T10:30:02.1735798Z .................................................................................................... 2900/5839
2019-07-20T10:30:07.3925747Z .................................................................................................... 3000/5839
2019-07-20T10:30:11.8929429Z .................................................................................................... 3100/5839
2019-07-20T10:30:17.0774966Z .................................................................................................... 3200/5839
2019-07-20T10:30:20.7030704Z .................................................................................................... 3300/5839
2019-07-20T10:30:24.5507314Z .................................................................................................... 3400/5839
2019-07-20T10:30:29.6747871Z .................................................................................................... 3500/5839
2019-07-20T10:30:33.2957479Z ................i................................................................................... 3600/5839
2019-07-20T10:30:37.2889165Z ..........................................................................................ii...i..ii 3700/5839
2019-07-20T10:30:46.0827180Z .................................................................................................... 3900/5839
2019-07-20T10:30:49.5488432Z .................................................................................................... 4000/5839
2019-07-20T10:30:49.5488432Z .................................................................................................... 4000/5839
2019-07-20T10:30:53.0956839Z ....ii.............................................................................................. 4100/5839
2019-07-20T10:30:55.0428071Z .........................i.......................................................................... 4200/5839
2019-07-20T10:30:56.9412346Z ...........................................................................................i........ 4300/5839
2019-07-20T10:31:04.1665207Z .................................................................................................... 4500/5839
2019-07-20T10:31:21.2394017Z .................................................................................................... 4600/5839
2019-07-20T10:31:24.6895375Z .................................................................................................... 4700/5839
2019-07-20T10:31:28.4133427Z .................................................................................................... 4800/5839
---
2019-07-20T10:32:02.9038990Z .................................................................................................... 5400/5839
2019-07-20T10:32:07.0338699Z .................................................................................................... 5500/5839
2019-07-20T10:32:11.3220541Z .................................................................................................... 5600/5839
2019-07-20T10:32:14.5710948Z .................................................................................................... 5700/5839
2019-07-20T10:32:17.5819558Z ...............................................................................i.................... 5800/5839
2019-07-20T10:32:19.0713556Z test result: ok. 5818 passed; 0 failed; 21 ignored; 0 measured; 0 filtered out
2019-07-20T10:32:19.0714016Z 
2019-07-20T10:32:19.0777154Z  finished in 262.897
2019-07-20T10:32:19.0953160Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T10:32:19.0953160Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-20T10:32:19.3304976Z 
2019-07-20T10:32:19.3306173Z running 2906 tests
2019-07-20T10:32:34.6332872Z .................................................................................................... 100/2906
2019-07-20T10:32:50.5014294Z ............................................................................i....................... 200/2906
2019-07-20T10:33:15.5828125Z .................................................................................................... 400/2906
2019-07-20T10:33:27.5727402Z .................................................................................................... 500/2906
2019-07-20T10:33:42.3818374Z .................................................................................................... 600/2906
2019-07-20T10:34:04.2361209Z .................................................................................................... 700/2906
2019-07-20T10:34:04.2361209Z .................................................................................................... 700/2906
2019-07-20T10:34:18.1969764Z .................................................................................................... 800/2906
2019-07-20T10:34:29.3730407Z .................................................................................................... 900/2906
2019-07-20T10:34:48.0199558Z .................................................................................................... 1000/2906
2019-07-20T10:35:02.4594528Z .................................................................................................... 1100/2906
2019-07-20T10:35:13.6522326Z .................................................................................................... 1200/2906
2019-07-20T10:35:26.0808294Z .................................................................................................... 1300/2906
2019-07-20T10:35:42.4226276Z ........ii.......................................................................................... 1400/2906
2019-07-20T10:35:55.3312533Z .................................................................................................... 1500/2906
2019-07-20T10:36:08.0919368Z ............................................................i.......i............................... 1600/2906
2019-07-20T10:36:40.9618142Z .................................................................................................... 1800/2906
2019-07-20T10:36:40.9618142Z .................................................................................................... 1800/2906
2019-07-20T10:36:56.4901335Z ............................................................................................i....... 1900/2906
2019-07-20T10:37:16.7655849Z ................................................................i................................... 2000/2906
2019-07-20T10:38:00.7475113Z .................................................................................................... 2200/2906
2019-07-20T10:38:15.3717739Z ...................................................................................................i 2300/2906
2019-07-20T10:38:34.4249742Z i................................................................................................... 2400/2906
2019-07-20T10:38:48.1611330Z .................................................................................................... 2500/2906
---
2019-07-20T10:40:55.1635812Z ---- [mir-opt] mir-opt/lower_128bit_debug_test.rs stdout ----
2019-07-20T10:40:55.1636099Z 
2019-07-20T10:40:55.1636375Z error: compilation failed!
2019-07-20T10:40:55.1636601Z status: exit code: 1
2019-07-20T10:40:55.1638074Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/mir-opt/lower_128bit_debug_test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zdump-mir=all" "-Zmir-opt-level=3" "-Zdump-mir-exclude-pass-number" "-Zdump-mir-dir=/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_debug_test" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_debug_test/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "lower_128bit_ops=yes" "-C" "debug_assertions=yes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_debug_test/auxiliary"
2019-07-20T10:40:55.1642910Z ------------------------------------------
2019-07-20T10:40:55.1642998Z 
2019-07-20T10:40:55.1643265Z ------------------------------------------
2019-07-20T10:40:55.1643305Z stderr:
2019-07-20T10:40:55.1643305Z stderr:
2019-07-20T10:40:55.1643467Z ------------------------------------------
2019-07-20T10:40:55.1643506Z error: unknown debugging option: `lower_128bit_ops`
2019-07-20T10:40:55.1643565Z 
2019-07-20T10:40:55.1643727Z ------------------------------------------
2019-07-20T10:40:55.1643749Z 
2019-07-20T10:40:55.1643768Z 
2019-07-20T10:40:55.1643768Z 
2019-07-20T10:40:55.1644160Z ---- [mir-opt] mir-opt/lower_128bit_test.rs stdout ----
2019-07-20T10:40:55.1644189Z 
2019-07-20T10:40:55.1644224Z error: compilation failed!
2019-07-20T10:40:55.1644915Z status: exit code: 1
2019-07-20T10:40:55.1645855Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/mir-opt/lower_128bit_test.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zdump-mir=all" "-Zmir-opt-level=3" "-Zdump-mir-exclude-pass-number" "-Zdump-mir-dir=/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_test" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_test/a" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "lower_128bit_ops=yes" "-C" "debug_assertions=no" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt/lower_128bit_test/auxiliary"
2019-07-20T10:40:55.1646199Z ------------------------------------------
2019-07-20T10:40:55.1646399Z 
2019-07-20T10:40:55.1646697Z ------------------------------------------
2019-07-20T10:40:55.1646744Z stderr:
2019-07-20T10:40:55.1646744Z stderr:
2019-07-20T10:40:55.1646973Z ------------------------------------------
2019-07-20T10:40:55.1647043Z error: unknown debugging option: `lower_128bit_ops`
2019-07-20T10:40:55.1647102Z 
2019-07-20T10:40:55.1647317Z ------------------------------------------
2019-07-20T10:40:55.1647349Z 
2019-07-20T10:40:55.1647394Z 
---
2019-07-20T10:40:55.1648352Z test result: FAILED. 55 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out
2019-07-20T10:40:55.1648551Z 
2019-07-20T10:40:55.1648596Z 
2019-07-20T10:40:55.1648615Z 
2019-07-20T10:40:55.1650077Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/mir-opt" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "mir-opt" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-20T10:40:55.1650385Z 
2019-07-20T10:40:55.1650407Z 
2019-07-20T10:40:55.1650895Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-20T10:40:55.1651140Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-20T10:40:55.1651140Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-20T10:40:55.1651187Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-20T10:40:55.1651228Z Build completed unsuccessfully in 1:06:14
2019-07-20T10:40:57.9762581Z ##[error]Bash exited with code '1'.
2019-07-20T10:40:57.9800638Z ##[section]Starting: Checkout
2019-07-20T10:40:57.9802337Z ==============================================================================
2019-07-20T10:40:57.9802380Z Task         : Get sources
2019-07-20T10:40:57.9802436Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

@bors: r+ delegate+

@bors
Copy link
Contributor

bors commented Jul 20, 2019

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

@bors
Copy link
Contributor

bors commented Jul 20, 2019

✌️ @bjorn3 can now approve this pull request

@alexcrichton alexcrichton changed the title [WIP] Remove support for -Zlower-128bit-ops Remove support for -Zlower-128bit-ops Jul 20, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 20, 2019

📌 Commit 93de733 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Rollup of 10 pull requests

Successful merges:

 - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - rust-lang#61890 (Fix some sanity checks)
 - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item)
 - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - rust-lang#62801 (Remove support for -Zlower-128bit-ops)
 - rust-lang#62808 (Revert "Disable stack probing for gnux32.")
 - rust-lang#62819 (Display name of crate requiring rustc_private in error messages.)
 - rust-lang#62904 (Disable d32 on armv6 hf targets)
 - rust-lang#62907 (Initialize the MSP430 AsmParser)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jul 24, 2019
Rollup of 13 pull requests

Successful merges:

 - rust-lang#60938 (rustdoc: make #[doc(include)] relative to the containing file)
 - rust-lang#61890 (Fix some sanity checks)
 - rust-lang#62084 (allow clippy::unreadable_literal in unicode tables)
 - rust-lang#62261 (Take substs into account in `conservative_is_privately_uninhabited`)
 - rust-lang#62528 (Add joining slices of slices with a slice separator, not just a single item)
 - rust-lang#62735 (Turn `#[global_allocator]` into a regular attribute macro)
 - rust-lang#62801 (Remove support for -Zlower-128bit-ops)
 - rust-lang#62808 (Revert "Disable stack probing for gnux32.")
 - rust-lang#62822 (Improve some pointer-related documentation)
 - rust-lang#62904 (Disable d32 on armv6 hf targets)
 - rust-lang#62907 (Initialize the MSP430 AsmParser)
 - rust-lang#62921 (Add method disambiguation help for trait implementation)
 - rust-lang#62942 (Use match ergonomics in Condvar documentation)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 25, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 14 pull requests

Successful merges:

 - #62084 (allow clippy::unreadable_literal in unicode tables)
 - #62421 (Introduce `as_deref` to Option)
 - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
 - #62801 (Remove support for -Zlower-128bit-ops)
 - #62828 (Remove vector fadd/fmul reduction workarounds)
 - #62862 (code cleanup)
 - #62897 (Attempt to fix backtrace tests on i686-msvc)
 - #62904 (Disable d32 on armv6 hf targets)
 - #62907 (Initialize the MSP430 AsmParser)
 - #62956 (Implement slow-path for FirstSets::first)
 - #62963 (Allow lexer to recover from some homoglyphs)
 - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
 - #62983 (Remove needless indirection through Rc)
 - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
…lexcrichton

Remove support for -Zlower-128bit-ops

It is broken and unused

cc rust-lang#58969

blocked rust-lang/compiler-builtins#302 (removes definitions of the lang items removed in this PR)

r? @alexcrichton
bors added a commit that referenced this pull request Jul 26, 2019
Rollup of 22 pull requests

Successful merges:

 - #62084 (allow clippy::unreadable_literal in unicode tables)
 - #62120 (Add missing type links in documentation)
 - #62310 (Add missing doc links in boxed module)
 - #62421 (Introduce `as_deref` to Option)
 - #62583 (Implement Unpin for all raw pointers)
 - #62692 (rustc: precompute the largest Niche and store it in LayoutDetails.)
 - #62801 (Remove support for -Zlower-128bit-ops)
 - #62828 (Remove vector fadd/fmul reduction workarounds)
 - #62862 (code cleanup)
 - #62904 (Disable d32 on armv6 hf targets)
 - #62907 (Initialize the MSP430 AsmParser)
 - #62956 (Implement slow-path for FirstSets::first)
 - #62963 (Allow lexer to recover from some homoglyphs)
 - #62964 (clarify and unify some type test names)
 - #62970 (ci: gate toolstate repo pushes on the TOOLSTATE_PUBLISH envvar)
 - #62980 (std: Add more accessors for `Metadata` on Windows)
 - #62983 (Remove needless indirection through Rc)
 - #62985 (librustc_errors: Support ui-testing flag in annotate-snippet emitter)
 - #63002 (error_index_generator should output stdout/stderr when it panics.)
 - #63004 (Add test for issue-54062)
 - #63007 (ci: debug network failures while downloading awscli from PyPI)
 - #63009 (Remove redundant `mut` from variable declaration.)

Failed merges:

r? @ghost
@bors bors merged commit 93de733 into rust-lang:master Jul 26, 2019
@bjorn3 bjorn3 deleted the remove_lower_128bit_ops branch July 26, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants