Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the mention of LLDB from RELEASES.md #63192

Open
wants to merge 1 commit into
base: master
from

Conversation

@golddranks
Copy link
Contributor

commented Aug 1, 2019

Since #62592 (and rust-lang/llvm-project#19 ), building the lldb-preview component has been disabled and it's not currently shipped with the macOS components it used to be shipped with. Therefore it's misleading to say it's fixed in the release notes.

Now, I'm hoping that we could ship the component eventually, but the current status of it seems to be unclear: since the upgrade to LLVM 9, some Rust-specific patches on LLDB were outdated. I don't know if the pretty-printing scripts work without them and I don't have the time to test them right now. (The patches are here: https://github.com/nikic/llvm-project/commits/llvm-9-lldb ) Additionally, there is an open PR to replace the pretty printing scripts. I'm not sure about the status of that work, now that the Rust patches on LLDB were dropped, plus it seems to be WIP: #60826

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2019

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@nikic

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

rust-lldb should still work with system lldb -- right? I believe that's how it was intended to be used in the first place, same as with rust-gdb.

@golddranks

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

In that case let's not pull this in yet! I'll to arrange time tomorrow to see if it works and if it does, I'll close this and re-enable the LLDB build for macOS release :)

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Yes I believe the rust-lldb script should still work, like rust-gdb works but we don't ship a GDB build.

@jacobrosenthal

This comment has been minimized.

Copy link

commented Aug 4, 2019

Er. Got entered early.
rust-lldb does appear to give something where bare lldb doesnt

type summary list
Category: Rust
-----------------------
.*:  (hide value)
      lldb_rust_formatters.print_val(valobj,internal_dict)

but again to recap gdb
Im on macosx 10.13.6 (17G7024), stable-x86_64-apple-darwin (default) rustc 1.36.0 (a53f9df 2019-07-03), and rust-gdb doesnt work, in that it does not offer pretty printers.

I have in my path rust-gdb which is a binary

Jacobs-MacBook-Air:~ jacobrosenthal$ which rust-gdb
/Users/jacobrosenthal/.cargo/bin/rust-gdb
Jacobs-MacBook-Air:~ jacobrosenthal$ file /Users/jacobrosenthal/.cargo/bin/rust-gdb
/Users/jacobrosenthal/.cargo/bin/rust-gdb: Mach-O 64-bit executable x86_64

and I have $(rustc --print sysroot)/bin/rust-gdb which is the wrapper script

Jacobs-MacBook-Air:gdb-test jacobrosenthal$ file $(rustc --print sysroot)/bin/rust-gdb
/Users/jacobrosenthal/.rustup/toolchains/stable-x86_64-apple-darwin/bin/rust-gdb: POSIX shell script text executable, ASCII text

if I use either one

RUST_GDB=/usr/local/Cellar/gdb/8.3/bin/gdb $(rustc --print sysroot)/bin/rust-gdb -q target/x86_64-apple-darwin/debug/deps/gdb_test-bc8254d659b4f30e

or

RUST_GDB=/usr/local/Cellar/gdb/8.3/bin/gdb /Users/jacobrosenthal/.cargo/bin/rust-gdb -q target/x86_64-apple-darwin/debug/deps/gdb_test-bc8254d659b4f30e

I dont get pretty printing

(gdb) info pretty-printer
global pretty-printers:
  builtin
    mpx_bound128
(gdb) 

but I DO if use either, or not at all, but simply load it myself

python
import sys
sys.path.append('/Users/jacobrosenthal/.rustup/toolchains/stable-x86_64-apple-darwin/lib/rustlib/etc')
import gdb_rust_pretty_printing
gdb_rust_pretty_printing.register_printers(gdb)
end  
(gdb) info pretty-printer
global pretty-printers:
  builtin
    mpx_bound128
  rust_pretty_printer_lookup_function
(gdb) 

@joelpalmer

This comment has been minimized.

Copy link

commented Aug 12, 2019

Ping from Triage: Hi @golddranks I am going to change this to waiting-on-author. If you are waiting for a reviewer on something or plan to close this, please respond. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.