Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in #63135 #63202

Merged
merged 1 commit into from Aug 2, 2019
Merged

Fix ICE in #63135 #63202

merged 1 commit into from Aug 2, 2019

Conversation

ExpHP
Copy link
Contributor

@ExpHP ExpHP commented Aug 1, 2019

Closes #63135.

r?@estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 1, 2019
@ExpHP ExpHP changed the title Fix #63135 Fix ICE in #63135 Aug 1, 2019
@estebank
Copy link
Contributor

estebank commented Aug 2, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 2, 2019

📌 Commit b3321fb has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 2, 2019
bors added a commit that referenced this pull request Aug 2, 2019
Rollup of 7 pull requests

Successful merges:

 - #62663 (More questionmarks in doctests)
 - #62969 (Changing the structure of `mir::interpret::InterpError`)
 - #63153 (Remove redundant method with const variable resolution)
 - #63189 (Doc improvements)
 - #63198 (Allow trailing comma in macro 2.0 declarations.)
 - #63202 (Fix ICE in #63135)
 - #63203 (Make is_mutable use PlaceRef instead of it's fields)

Failed merges:

r? @ghost
@bors bors merged commit b3321fb into rust-lang:master Aug 2, 2019
@ExpHP ExpHP deleted the parser-ice-63135 branch August 2, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE on "Error constructed but not emitted"
4 participants