-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #63228
Rollup of 7 pull requests #63228
Commits on Jul 30, 2019
-
On
format!()
arg count mismatch provide extra infoWhen positional width and precision formatting flags are present in a formatting string that has an argument count mismatch, provide extra information pointing at them making it easiser to understand where the problem may lay: ``` error: 4 positional arguments in format string, but there are 3 arguments --> $DIR/ifmt-bad-arg.rs:78:15 | LL | println!("{} {:.*} {}", 1, 3.2, 4); | ^^ ^^--^ ^^ --- this parameter corresponds to the precision flag | | | this precision flag adds an extra required argument at position 1, which is why there are 4 arguments expected | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html error: 4 positional arguments in format string, but there are 3 arguments --> $DIR/ifmt-bad-arg.rs:81:15 | LL | println!("{} {:07$.*} {}", 1, 3.2, 4); | ^^ ^^-----^ ^^ --- this parameter corresponds to the precision flag | | | | | this precision flag adds an extra required argument at position 1, which is why there are 4 arguments expected | this width flag expects an `usize` argument at position 7, but there are 3 arguments | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html error: 3 positional arguments in format string, but there are 3 arguments --> $DIR/ifmt-bad-arg.rs:84:15 | LL | println!("{} {:07$} {}", 1, 3.2, 4); | ^^ ^^---^ ^^ | | | this width flag expects an `usize` argument at position 7, but there are 3 arguments | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html ```
Configuration menu - View commit details
-
Copy full SHA for 159dcb2 - Browse repository at this point
Copy the full SHA 159dcb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86f4f68 - Browse repository at this point
Copy the full SHA 86f4f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 762f645 - Browse repository at this point
Copy the full SHA 762f645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e59d74 - Browse repository at this point
Copy the full SHA 9e59d74View commit details
Commits on Jul 31, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 22ea38d - Browse repository at this point
Copy the full SHA 22ea38dView commit details
Commits on Aug 1, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 79a1e7a - Browse repository at this point
Copy the full SHA 79a1e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d8c97b - Browse repository at this point
Copy the full SHA 0d8c97bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f61de - Browse repository at this point
Copy the full SHA 30f61deView commit details
Commits on Aug 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 14be088 - Browse repository at this point
Copy the full SHA 14be088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 875cef0 - Browse repository at this point
Copy the full SHA 875cef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd98727 - Browse repository at this point
Copy the full SHA dd98727View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1c89d6 - Browse repository at this point
Copy the full SHA d1c89d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 57f9423 - Browse repository at this point
Copy the full SHA 57f9423View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b4afe - Browse repository at this point
Copy the full SHA 13b4afeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3725e35 - Browse repository at this point
Copy the full SHA 3725e35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208672f - Browse repository at this point
Copy the full SHA 208672fView commit details -
Added support for armv7-unknown-linux-gnueabi and armv7-unknown-linux…
…-musleabi. Support for the targets in the compiler and std build in the CI.
Configuration menu - View commit details
-
Copy full SHA for 2b0f448 - Browse repository at this point
Copy the full SHA 2b0f448View commit details -
Rollup merge of rust-lang#63107 - adrian-budau:master, r=alexcrichton
Added support for armv7-unknown-linux-gnueabi/musleabi Fixes rust-lang#63101 Some things that are not done and I hope someone can help me with: * During the ci build of `armv7-unknown-linux-gnueabi` `openssl` must be built (to build cargo) but `openssl` does not yet support this target. This feels slightly like a chicken-and-egg problem, any feedback is welcome. * Should I add any tests for any of these targets?
Configuration menu - View commit details
-
Copy full SHA for a2735a3 - Browse repository at this point
Copy the full SHA a2735a3View commit details -
Rollup merge of rust-lang#63121 - estebank:formatting-pos, r=alexcric…
…hton On `format!()` arg count mismatch provide extra info When positional width and precision formatting flags are present in a formatting string that has an argument count mismatch, provide extra information pointing at them making it easiser to understand where the problem may lay: ``` error: 4 positional arguments in format string, but there are 3 arguments --> $DIR/ifmt-bad-arg.rs:78:15 | LL | println!("{} {:.*} {}", 1, 3.2, 4); | ^^ ^^--^ ^^ --- this parameter corresponds to the precision flag | | | this precision flag adds an extra required argument at position 1, which is why there are 4 arguments expected | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html error: 4 positional arguments in format string, but there are 3 arguments --> $DIR/ifmt-bad-arg.rs:81:15 | LL | println!("{} {:07$.*} {}", 1, 3.2, 4); | ^^ ^^-----^ ^^ --- this parameter corresponds to the precision flag | | | | | this precision flag adds an extra required argument at position 1, which is why there are 4 arguments expected | this width flag expects an `usize` argument at position 7, but there are 3 arguments | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html error: invalid reference to positional argument 7 (there are 3 arguments) --> $DIR/ifmt-bad-arg.rs:84:18 | LL | println!("{} {:07$} {}", 1, 3.2, 4); | ^^^--^ | | | this width flag expects an `usize` argument at position 7, but there are 3 arguments | = note: positional arguments are zero-based = note: for information about formatting flags, visit https://doc.rust-lang.org/std/fmt/index.html ``` Fix rust-lang#49384.
Configuration menu - View commit details
-
Copy full SHA for edc846f - Browse repository at this point
Copy the full SHA edc846fView commit details -
Rollup merge of rust-lang#63196 - RalfJung:build_helper, r=alexcrichton
build_helper: try less confusing method names build_helper's `*_silent` methods were likely called that way because they do not print the command being run to stdout. [In the original file this all makes sense](rust-lang@046e687#diff-5c3d6537a43ecae03014e118a7fe3321). But later it also gained `*_suppressed` methods and the difference between `silent` and `suppressed` is far from clear. So rename `run` (which prints the command being run) to `run_verbose`. Then we can call the methods that just run a command and show its output but nothing extra `run` and `try_run`. `run_verbose` (formerly `run`) is unused from what I can tell. Should I remove it? r? @alexcrichton Cc @Mark-Simulacrum Also see rust-lang#63089 (comment).
Configuration menu - View commit details
-
Copy full SHA for 726f39a - Browse repository at this point
Copy the full SHA 726f39aView commit details -
Rollup merge of rust-lang#63206 - BaoshanPang:master, r=alexcrichton
remove unsupported test case r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for ed7b044 - Browse repository at this point
Copy the full SHA ed7b044View commit details -
Rollup merge of rust-lang#63208 - tmandry:issue-62658, r=cramertj
Round generator sizes to a multiple of their alignment Fixes rust-lang#62658. r? @cramertj cc @eddyb
Configuration menu - View commit details
-
Copy full SHA for 109b21f - Browse repository at this point
Copy the full SHA 109b21fView commit details -
Rollup merge of rust-lang#63212 - Centril:param-attrs-pretty, r=david…
…twco Pretty print attributes in `print_arg` Fixes rust-lang#63210. cc rust-lang#60406 r? @petrochenkov
Configuration menu - View commit details
-
Copy full SHA for f6d8977 - Browse repository at this point
Copy the full SHA f6d8977View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4520a39 - Browse repository at this point
Copy the full SHA 4520a39View commit details