Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup & Simplify stuff in lowering #63432

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@Centril
Copy link
Member

commented Aug 10, 2019

Closes #60253 as a byproduct.

It turns out that it is in fact necessary to have a DropTemps(...) around the match_expr and there is a test (https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-13304.rs) which fails without that.

r? @eddyb

@eddyb
eddyb approved these changes Aug 10, 2019
@eddyb

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

📌 Commit 8758d7f has been approved by eddyb

Centril added a commit to Centril/rust that referenced this pull request Aug 10, 2019
Rollup merge of rust-lang#63432 - Centril:simplify-lowering, r=eddyb
Cleanup & Simplify stuff in lowering

Closes rust-lang#60253 as a byproduct.

It turns out that it is in fact necessary to have a `DropTemps(...)` around the `match_expr` and there is a test (https://github.com/rust-lang/rust/blob/master/src/test/ui/issues/issue-13304.rs) which fails without that.

r? @eddyb
bors added a commit that referenced this pull request Aug 10, 2019
Auto merge of #63437 - Centril:rollup-ryx881p, r=Centril
Rollup of 4 pull requests

Successful merges:

 - #63400 (Try to break resolve into more isolated parts)
 - #63425 (Cleanup historical stability comments)
 - #63429 (.gitignore: Readd `/tmp/`)
 - #63432 (Cleanup & Simplify stuff in lowering)

Failed merges:

r? @ghost

@bors bors merged commit 8758d7f into rust-lang:master Aug 10, 2019

4 checks passed

pr Build #20190810.25 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details

@Centril Centril deleted the Centril:simplify-lowering branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.