Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use constraint span when lowering associated types #63620

Merged
merged 2 commits into from Aug 20, 2019
Merged

Use constraint span when lowering associated types #63620

merged 2 commits into from Aug 20, 2019

Conversation

estebank
Copy link
Contributor

Fix #63594.

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor Author

cc @alexreg

@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril added the F-associated_type_bounds `#![feature(associated_type_bounds)]` label Aug 16, 2019
Centril
Centril reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh; didn't expect anyone to fix this before I had filed my tests (including the one added here) as a PR. =P

src/test/ui/associated-item/associated-item-type-issue-63594.rs Outdated Show resolved Hide resolved
src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Aug 16, 2019

cc #52662

@Centril
Copy link
Contributor

Centril commented Aug 16, 2019

r=me with changes ^---

@alexreg
Copy link
Contributor

alexreg commented Aug 16, 2019

Thanks @estebank!

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2019
@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Aug 19, 2019

📌 Commit 1808e4d has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 19, 2019
@Centril
Rollup merge of rust-lang#63620 - estebank:assoc-type-span, r=Centril
a2080a6 
Use constraint span when lowering associated types

Fix rust-lang#63594.

r? @Centril
@Centril Centril mentioned this pull request Aug 19, 2019
Merged
bors added a commit that referenced this pull request Aug 19, 2019
@bors
Auto merge of #63715 - Centril:rollup-dga8qtp, r=Centril
c1b08dd 
Rollup of 5 pull requests

Successful merges:

 - #63252 (Remove recommendation about idiomatic syntax for Arc::clone)
 - #63376 (use different lifetime name for object-lifetime-default elision)
 - #63620 (Use constraint span when lowering associated types)
 - #63699 (Fix suggestion from incorrect `move async` to `async move`.)
 - #63704 ( Fixed: error: unnecessary trailing semicolon)

Failed merges:

r? @ghost
@bors bors merged commit 1808e4d into rust-lang:master Aug 20, 2019
@Centril Centril mentioned this pull request Aug 20, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
F-associated_type_bounds `#![feature(associated_type_bounds)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrectly-/Un-spanned error with type Out = Box<dyn Bar<Assoc: Copy>>;
5 participants
@estebank @rust-highfive @Centril @alexreg @bors