Rename overflowing_{add,sub,mul} intrinsics to wrapping_{add,sub,mul}. #63642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Bootstrap changes look fine. |
Gankra
reviewed
Aug 16, 2019
| @@ -67,7 +67,7 @@ pub fn intrisic_operation_unsafety(intrinsic: &str) -> hir::Unsafety { | |||
| match intrinsic { | |||
| "size_of" | "min_align_of" | "needs_drop" | | |||
| "add_with_overflow" | "sub_with_overflow" | "mul_with_overflow" | | |||
There was a problem hiding this comment.
should these be changed to match the others, or is their different signature sufficient to motivate a different naming convention? (this naming convention is not reflected in the std names)
There was a problem hiding this comment.
These match the LLVM intrinsics. We could rename them later but they're not outright wrong like overflowing_* intrinsics were.
|
r=me on the code changes, don't have an opinion on the rustbuild stuff though. |
|
@bors r=rkruppe,Mark-Simulacrum |
|
📌 Commit 892ef6f has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 16, 2019
…mulacrum
Rename overflowing_{add,sub,mul} intrinsics to wrapping_{add,sub,mul}.
These confused @Gankra, and then, also me, especially since `overflowing_*` *methods* also exist, but they map to `*_with_overflow` intrinsics!
r? @oli-obk / @nikomatsakis cc @Mark-Simulacrum (on the rustbuild workaround)
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 17, 2019
…mulacrum
Rename overflowing_{add,sub,mul} intrinsics to wrapping_{add,sub,mul}.
These confused @Gankra, and then, also me, especially since `overflowing_*` *methods* also exist, but they map to `*_with_overflow` intrinsics!
r? @oli-obk / @nikomatsakis cc @Mark-Simulacrum (on the rustbuild workaround)
bors
added a commit
that referenced
this pull request
Aug 17, 2019
Rollup of 6 pull requests Successful merges: - #63149 (resolve: Populate external modules in more automatic and lazy way) - #63545 (Feature gate 'yield $expr?' pre-expansion) - #63548 (Update rustc-demangle to 0.1.16.) - #63558 (Remap paths for proc-macro crates.) - #63641 (add git keyword to submodule comments in config.example.toml) - #63642 (Rename overflowing_{add,sub,mul} intrinsics to wrapping_{add,sub,mul}.) Failed merges: r? @ghost
cuviper
reviewed
Sep 20, 2019
| cmd.arg("--cfg").arg("bootstrap"); | ||
| } else { | ||
| // NOTE(eddyb) see FIXME above, except now we need annotations again in core. | ||
| cmd.arg("--cfg").arg("boostrap_stdarch_ignore_this"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These confused @Gankra, and then, also me, especially since
overflowing_*methods also exist, but they map to*_with_overflowintrinsics!r? @oli-obk / @nikomatsakis cc @Mark-Simulacrum (on the rustbuild workaround)