Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully implement or-pattern parsing #63693

Merged
merged 34 commits into from
Aug 27, 2019
Merged

Fully implement or-pattern parsing #63693

merged 34 commits into from
Aug 27, 2019

Commits on Aug 24, 2019

  1. parser: extract ban_unexpected_or_or.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    5299d8a View commit details
    Browse the repository at this point in the history

  2. parser: type alias type Expected = Option<&'static str>;.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    1ba7550 View commit details
    Browse the repository at this point in the history

  3. parser: refactor parse_pat_with_or + use it in [p0, p1, ..] pats.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    0bbea47 View commit details
    Browse the repository at this point in the history

  4. parser: improve or-patterns recovery.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    30b841d View commit details
    Browse the repository at this point in the history

  5. parser: move multiple-pattern-typo -> or-patterns directory.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    d34ee76 View commit details
    Browse the repository at this point in the history

  6. parser: multiple-pattern-typo: cover more or-pattern places.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    5f57fee View commit details
    Browse the repository at this point in the history

  7. parser: simplify parse_pat_with_or.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    f852c7c View commit details
    Browse the repository at this point in the history

  8. parser: extract maybe_recover_unexpected_comma.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    21d9b85 View commit details
    Browse the repository at this point in the history

  9. parser: integrate maybe_recover_unexpected_comma in `parse_pat_with… 

    …_or`.
    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    a4a34ab View commit details
    Browse the repository at this point in the history

  10. parser: extract eat_or_separator.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    7b59b4f View commit details
    Browse the repository at this point in the history

  11. parser: improve parse_pat_with_or docs.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    dc5bbaf View commit details
    Browse the repository at this point in the history

  12. parser: use eat_or_separator for leading vert.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    6498959 View commit details
    Browse the repository at this point in the history

  13. parser: move maybe_recover_unexpected_comma to a more appropriate p… 

    …lace.
    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    39f5e5b View commit details
    Browse the repository at this point in the history

  14. parser: document ban_unexpected_or_or.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    8f6a0cd View commit details
    Browse the repository at this point in the history

  15. parser: parse_pats -> parse_top_pat{_unpack}.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b7178ef View commit details
    Browse the repository at this point in the history

  16. parser: document parse_pat.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    92d66a1 View commit details
    Browse the repository at this point in the history

  17. parser: let stmts & for exprs: allow or-patterns.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    95792b4 View commit details
    Browse the repository at this point in the history

  18. parser: drive-by: simplify parse_arg_general.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    5f6bec8 View commit details
    Browse the repository at this point in the history

  19. move ui/or-pattern-mismatch -> ui/or-patterns/.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    a9af18b View commit details
    Browse the repository at this point in the history

  20. or-patterns: add syntactic tests.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    f35432e View commit details
    Browse the repository at this point in the history

  21. move feature-gate-or_patterns.* -> ui/or-patterns/

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    d3b3bce View commit details
    Browse the repository at this point in the history

  22. or-patterns: harden feature gating tests.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    1ffea18 View commit details
    Browse the repository at this point in the history

  23. parser: better recovery for || in inner pats.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b205055 View commit details
    Browse the repository at this point in the history

  24. parser: bool -> GateOr.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b2966e6 View commit details
    Browse the repository at this point in the history

  25. parser: bool -> TopLevel.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    a9ef859 View commit details
    Browse the repository at this point in the history

  26. parse_top_pat: silence leading vert gating sometimes.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    3a40542 View commit details
    Browse the repository at this point in the history

  27. parser: extract recover_inner_leading_vert.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    e374772 View commit details
    Browse the repository at this point in the history

  28. parser: reword || recovery.

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    0ab8430 View commit details
    Browse the repository at this point in the history

  29. parser: simplify parse_pat_with_or_{inner}

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    1202cb0 View commit details
    Browse the repository at this point in the history

  30. parser: 'while parsing this or-pattern...'

    @Centril
    Centril committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    083963e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2019

  1. parser: gracefully handle fn foo(A | B: type).

    @Centril
    Centril committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    1caaa40 View commit details
    Browse the repository at this point in the history

  2. or_patterns: add run-rustfix tests.

    @Centril
    Centril committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    6a73199 View commit details
    Browse the repository at this point in the history

  3. parser: TopLevel -> RecoverComma.

    @Centril
    Centril committed Aug 25, 2019
    Configuration menu
    Copy the full SHA
    acb1130 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. parser: fix span for leading vert.

    @Centril
    Centril committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    2bd27fb View commit details
    Browse the repository at this point in the history