Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for overlapping ranges to unreachable patterns lint #64007

Merged
merged 10 commits into from
Oct 19, 2019
Merged

Add check for overlapping ranges to unreachable patterns lint #64007

merged 10 commits into from
Oct 19, 2019

Commits on Oct 16, 2019

  1. Add check for overlapping ranges to unreachable patterns lint

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    91a3db9 View commit details
    Browse the repository at this point in the history

  2. Move overlapping patterns to its own lint

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    220b9b2 View commit details
    Browse the repository at this point in the history

  3. Silence lint in fit_signed and fit_unsigned

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    916936c View commit details
    Browse the repository at this point in the history

  4. Move lint emitter to its own method

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d2cb5a8 View commit details
    Browse the repository at this point in the history

  5. review comments: use if let

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    be9e6af View commit details
    Browse the repository at this point in the history

  6. Deduplicate code for formatting RangeEnd

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    1ec6073 View commit details
    Browse the repository at this point in the history

  7. rename method

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    6832da8 View commit details
    Browse the repository at this point in the history

  8. Continue to emit unreachable pattern on cases caught by overlapping p… 

    …atterns
    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    89b19cc View commit details
    Browse the repository at this point in the history

  9. Only emit overlapping patterns lint if the overlap is partial

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    73d6efc View commit details
    Browse the repository at this point in the history

  10. Lint only on single element overlap

    @estebank
    estebank committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    593cdcc View commit details
    Browse the repository at this point in the history