Migrate internal diagnostic registration to macro_rules #64139

Mark-Simulacrum · 2019-09-04T02:44:34Z

Review is best done commit-by-commit.

rust-highfive · 2019-09-04T02:44:37Z

Some changes occurred in diagnostic error codes

Mark-Simulacrum · 2019-09-04T02:46:12Z

src/bootstrap/builder.rs

@@ -848,6 +848,7 @@ impl<'a> Builder<'a> {
        // things still build right, please do!
        match mode {
            Mode::Std => metadata.push_str("std"),
+            Mode::Codegen => metadata.push_str("codegen"),


@alexcrichton I was getting "found two different crates with name num_cpus that are not distinguished by differing -C metadata. This will result in symbol conflicts between the two." and a similar error for cc without this change; does it seem reasonable to just add this? I didn't change Cargo.lock at all so my assumption is that how we're linking things together changed due to differing uses of syntax or something like that.

A better fix might actually to be to just remove the cc and num_cpus dependencies from the Cargo.toml of librustc_codegen_llvm, that way it just pulls in the sysroot crates used by the compiler already

Hm so this is a bit painful due to build scripts being built with the beta compiler always I believe which leads us to not being able to load cc and such from the sysroot there -- this addition works in practice so I'd like to land it for now.

I don't think that's quite right, if you're getting conflicting crates then something in the rustc_driver dependency graph already links to the cc crate, and that's what's being loaded. If you delete this addition and delete the lines in Cargo.toml the build should work just fine.

I guess maybe we can't ever conflict with build deps since those are always built separately? I'll try that.

rust-highfive · 2019-09-04T03:04:32Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-04T02:45:13.0198656Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-04T02:45:13.0382651Z ##[command]git config gc.auto 0
2019-09-04T02:45:13.0432348Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-04T02:45:13.0482698Z ##[command]git config --get-all http.proxy
2019-09-04T02:45:13.0610097Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-04T02:51:49.7805219Z     Finished release [optimized] target(s) in 1m 17s
2019-09-04T02:51:49.7877148Z tidy check
2019-09-04T02:51:50.5603721Z * 578 error codes
2019-09-04T02:51:50.5603893Z * highest error code: E0733
2019-09-04T02:51:50.5897590Z tidy error: /checkout/src/libsyntax/feature_gate/removed.rs:107: feature rustc_diagnostic_macros is not sorted by since
2019-09-04T02:51:51.4225887Z some tidy checks failed
2019-09-04T02:51:51.4226873Z 
2019-09-04T02:51:51.4226873Z 
2019-09-04T02:51:51.4227949Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-09-04T02:51:51.4232025Z 
2019-09-04T02:51:51.4232936Z 
2019-09-04T02:51:51.4239634Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-09-04T02:51:51.4239919Z Build completed unsuccessfully in 0:01:19
2019-09-04T02:51:51.4239919Z Build completed unsuccessfully in 0:01:19
2019-09-04T02:51:51.4285577Z == clock drift check ==
2019-09-04T02:51:51.4302644Z   local time: Wed Sep  4 02:51:51 UTC 2019
2019-09-04T02:51:51.5771690Z   network time: Wed, 04 Sep 2019 02:51:51 GMT
2019-09-04T02:51:51.5777353Z == end clock drift check ==
2019-09-04T02:51:53.2157074Z ##[error]Bash exited with code '1'.
2019-09-04T02:51:53.2185831Z ##[section]Starting: Checkout
2019-09-04T02:51:53.2187291Z ==============================================================================
2019-09-04T02:51:53.2187332Z Task         : Get sources
2019-09-04T02:51:53.2187372Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libsyntax/diagnostics/macros.rs

Mark-Simulacrum · 2019-09-04T11:53:05Z

src/libsyntax/diagnostics/macros.rs

-    );
-    ($($code:tt: $description:tt),*,) => (
-        $($crate::register_diagnostic! { $code, $description })*
+    ($($ecode:ident: $message:expr,)* ; $($code:ident,)*) => (


I would love to drop the ; here to separate long and short error codes but wasn't able to quickly come up with a way to do so. It seems reasonable to me to leave further improvement to a future PR.

rust-highfive · 2019-09-04T14:24:05Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-04T13:08:08.9372777Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-04T13:08:09.7354779Z ##[command]git config gc.auto 0
2019-09-04T13:08:09.7357964Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-04T13:08:09.7359883Z ##[command]git config --get-all http.proxy
2019-09-04T13:08:09.7362772Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-04T14:10:20.4500741Z .................................................................................................... 1500/8989
2019-09-04T14:10:26.2384446Z .................................................................................................... 1600/8989
2019-09-04T14:10:39.1377272Z .................................................i...............i.................................. 1700/8989
2019-09-04T14:10:47.6248219Z .................................................................................................... 1800/8989
2019-09-04T14:11:02.1322615Z ........................................iiiii....................................................... 1900/8989
2019-09-04T14:11:13.1548826Z .................................................................................................... 2100/8989
2019-09-04T14:11:15.7600162Z .................................................................................................... 2200/8989
2019-09-04T14:11:19.9620620Z .................................................................................................... 2300/8989
2019-09-04T14:11:27.6289309Z .................................................................................................... 2400/8989
---
2019-09-04T14:14:26.7258581Z ...........................i..............i......................................................... 4700/8989
2019-09-04T14:14:38.5051726Z .................................................................................................... 4800/8989
2019-09-04T14:14:44.8832270Z .................................................................................................... 4900/8989
2019-09-04T14:14:55.8913118Z .................................................................................................... 5000/8989
2019-09-04T14:15:01.6362129Z .......ii.ii........................................................................................ 5100/8989
2019-09-04T14:15:14.9119438Z .................................................................................................... 5300/8989
2019-09-04T14:15:23.3453981Z ......................................................................i............................. 5400/8989
2019-09-04T14:15:30.7569435Z .................................................................................................... 5500/8989
2019-09-04T14:15:37.6031299Z .................................................................................................... 5600/8989
2019-09-04T14:15:37.6031299Z .................................................................................................... 5600/8989
2019-09-04T14:15:47.9751428Z ................................................................ii...i...ii..........i.............. 5700/8989
2019-09-04T14:16:13.6791285Z .................................................................................................... 5900/8989
2019-09-04T14:16:23.1665363Z .................................................................................................... 6000/8989
2019-09-04T14:16:23.1665363Z .................................................................................................... 6000/8989
2019-09-04T14:16:32.2401237Z ..................................................................i..ii............................. 6100/8989
2019-09-04T14:17:01.4976786Z .................................................................................................... 6300/8989
2019-09-04T14:17:03.5382149Z .....................i.............................................................................. 6400/8989
2019-09-04T14:17:05.7324055Z .............................................................................................i...... 6500/8989
2019-09-04T14:17:08.3517601Z .................................................................................................... 6600/8989
---
2019-09-04T14:21:56.9232103Z  finished in 20.017
2019-09-04T14:21:56.9462399Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:21:57.1290625Z 
2019-09-04T14:21:57.1291080Z running 149 tests
2019-09-04T14:22:00.4305192Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-09-04T14:22:02.7489753Z ..iiii..............i.........iii.i......ii......
2019-09-04T14:22:02.7491205Z 
2019-09-04T14:22:02.7497159Z  finished in 5.803
2019-09-04T14:22:02.7682535Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:22:02.9323514Z 
---
2019-09-04T14:22:05.1054573Z  finished in 2.337
2019-09-04T14:22:05.1257474Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:22:05.3038030Z 
2019-09-04T14:22:05.3038530Z running 9 tests
2019-09-04T14:22:05.3039511Z iiiiiiiii
2019-09-04T14:22:05.3040702Z 
2019-09-04T14:22:05.3040894Z  finished in 0.178
2019-09-04T14:22:05.3231163Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:22:05.5087232Z 
---
2019-09-04T14:22:24.1753945Z  finished in 18.852
2019-09-04T14:22:24.2000060Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:22:24.3928611Z 
2019-09-04T14:22:24.3928951Z running 123 tests
2019-09-04T14:22:49.1135593Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-04T14:22:53.9358006Z i.i.i......iii.i.....ii
2019-09-04T14:22:53.9359663Z 
2019-09-04T14:22:53.9364872Z  finished in 29.736
2019-09-04T14:22:53.9376501Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T14:22:53.9376835Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-04T14:23:58.5502838Z 
2019-09-04T14:23:58.5503191Z ------------------------------------------
2019-09-04T14:23:58.5503367Z stderr:
2019-09-04T14:23:58.5503735Z ------------------------------------------
2019-09-04T14:23:58.5504392Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
2019-09-04T14:23:58.5504737Z 
2019-09-04T14:23:58.5505073Z ------------------------------------------
2019-09-04T14:23:58.5505226Z 
2019-09-04T14:23:58.5505362Z 
---
2019-09-04T14:23:58.5506806Z test result: FAILED. 68 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-09-04T14:23:58.5507043Z 
2019-09-04T14:23:58.5507187Z 
2019-09-04T14:23:58.5507297Z 
2019-09-04T14:23:58.5508939Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-04T14:23:58.5509638Z 
2019-09-04T14:23:58.5509759Z 
2019-09-04T14:23:58.5509913Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-04T14:23:58.5510056Z Build completed unsuccessfully in 1:08:36
2019-09-04T14:23:58.5510056Z Build completed unsuccessfully in 1:08:36
2019-09-04T14:23:58.5510670Z == clock drift check ==
2019-09-04T14:23:58.5510896Z   local time: Wed Sep  4 14:23:58 UTC 2019
2019-09-04T14:23:58.5511036Z   network time: Wed, 04 Sep 2019 14:23:58 GMT
2019-09-04T14:23:58.5511179Z == end clock drift check ==
2019-09-04T14:23:59.1093024Z ##[error]Bash exited with code '1'.
2019-09-04T14:23:59.1133268Z ##[section]Starting: Checkout
2019-09-04T14:23:59.1135180Z ==============================================================================
2019-09-04T14:23:59.1135253Z Task         : Get sources
2019-09-04T14:23:59.1135298Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2019-09-04T15:03:55Z

The failure seems spurious?
@bors r+

bors · 2019-09-04T15:03:56Z

📌 Commit 87dbf92a22ce87cfda271635ab963a656dc8c64f has been approved by petrochenkov

Mark-Simulacrum · 2019-09-04T15:13:10Z

Yeah, failure is almost certainly spurious.

Mark-Simulacrum · 2019-09-04T17:23:09Z

r? @alexcrichton on the codegen dep commit (c124683 in the current rebase, I'll try to edit if I need to rebase again)

rust-highfive · 2019-09-04T17:54:52Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-04T17:50:10.9711955Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-04T17:50:10.9918398Z ##[command]git config gc.auto 0
2019-09-04T17:50:11.0026075Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-04T17:50:11.0081312Z ##[command]git config --get-all http.proxy
2019-09-04T17:50:11.0236076Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-04T17:53:50.7475154Z #################################################################         90.7%
2019-09-04T17:53:50.7476264Z ######################################################################## 100.0%
2019-09-04T17:53:52.1100479Z extracting /checkout/obj/build/cache/2019-08-13/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
2019-09-04T17:53:52.4210867Z     Updating crates.io index
2019-09-04T17:54:27.7694363Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-09-04T17:54:27.7720814Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-09-04T17:54:27.7768715Z Makefile:67: recipe for target 'prepare' failed
2019-09-04T17:54:27.7771421Z make: *** [prepare] Error 1
2019-09-04T17:54:28.7788609Z Command failed. Attempt 2/5:
2019-09-04T17:54:28.7788609Z Command failed. Attempt 2/5:
2019-09-04T17:54:28.9878251Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-09-04T17:54:28.9896847Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-09-04T17:54:28.9953506Z Makefile:67: recipe for target 'prepare' failed
2019-09-04T17:54:28.9953622Z make: *** [prepare] Error 1
2019-09-04T17:54:30.9967413Z Command failed. Attempt 3/5:
2019-09-04T17:54:30.9967413Z Command failed. Attempt 3/5:
2019-09-04T17:54:31.2198176Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-09-04T17:54:31.2214377Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-09-04T17:54:31.2260514Z Makefile:67: recipe for target 'prepare' failed
2019-09-04T17:54:31.2264218Z make: *** [prepare] Error 1
2019-09-04T17:54:34.2281922Z Command failed. Attempt 4/5:
2019-09-04T17:54:34.2281922Z Command failed. Attempt 4/5:
2019-09-04T17:54:34.4368883Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-09-04T17:54:34.4386214Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-09-04T17:54:34.4434037Z Makefile:67: recipe for target 'prepare' failed
2019-09-04T17:54:34.4434453Z make: *** [prepare] Error 1
2019-09-04T17:54:38.4461465Z Command failed. Attempt 5/5:
2019-09-04T17:54:38.4461465Z Command failed. Attempt 5/5:
2019-09-04T17:54:38.6533562Z error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
2019-09-04T17:54:38.6548030Z failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
2019-09-04T17:54:38.6594443Z Makefile:67: recipe for target 'prepare' failed
2019-09-04T17:54:38.6599814Z make: *** [prepare] Error 1
2019-09-04T17:54:38.6605362Z The command has failed after 5 attempts.
2019-09-04T17:54:38.6605434Z == clock drift check ==
2019-09-04T17:54:38.6605434Z == clock drift check ==
2019-09-04T17:54:38.6611865Z   local time: Wed Sep  4 17:54:38 UTC 2019
2019-09-04T17:54:38.8181040Z   network time: Wed, 04 Sep 2019 17:54:38 GMT
2019-09-04T17:54:38.8186244Z == end clock drift check ==
2019-09-04T17:54:39.8459283Z ##[error]Bash exited with code '1'.
2019-09-04T17:54:39.8499628Z ##[section]Starting: Checkout
2019-09-04T17:54:39.8501479Z ==============================================================================
2019-09-04T17:54:39.8501553Z Task         : Get sources
2019-09-04T17:54:39.8501898Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-04T19:40:41Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-04T18:20:09.0081842Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-04T18:20:09.0305408Z ##[command]git config gc.auto 0
2019-09-04T18:20:09.0423929Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-04T18:20:09.0492155Z ##[command]git config --get-all http.proxy
2019-09-04T18:20:09.0657596Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-04T19:26:08.5040958Z .................................................................................................... 1500/8989
2019-09-04T19:26:14.5613405Z .................................................................................................... 1600/8989
2019-09-04T19:26:27.9838830Z .................................................i...............i.................................. 1700/8989
2019-09-04T19:26:36.9475848Z .................................................................................................... 1800/8989
2019-09-04T19:26:52.0017862Z ........................................iiiii....................................................... 1900/8989
2019-09-04T19:27:03.5705161Z .................................................................................................... 2100/8989
2019-09-04T19:27:06.3939675Z .................................................................................................... 2200/8989
2019-09-04T19:27:10.7643039Z .................................................................................................... 2300/8989
2019-09-04T19:27:18.8685362Z .................................................................................................... 2400/8989
---
2019-09-04T19:30:31.5539177Z ..........................i...............i......................................................... 4700/8989
2019-09-04T19:30:44.3408810Z .................................................................................................... 4800/8989
2019-09-04T19:30:51.0514213Z .................................................................................................... 4900/8989
2019-09-04T19:31:02.5922031Z .................................................................................................... 5000/8989
2019-09-04T19:31:08.6276683Z .......ii.ii........................................................................................ 5100/8989
2019-09-04T19:31:22.8349094Z .................................................................................................... 5300/8989
2019-09-04T19:31:31.7772081Z ......................................................................i............................. 5400/8989
2019-09-04T19:31:39.6496549Z .................................................................................................... 5500/8989
2019-09-04T19:31:46.9773995Z .................................................................................................... 5600/8989
2019-09-04T19:31:46.9773995Z .................................................................................................... 5600/8989
2019-09-04T19:31:58.0358404Z ................................................................ii...i..ii...........i.............. 5700/8989
2019-09-04T19:32:25.7542359Z .................................................................................................... 5900/8989
2019-09-04T19:32:36.0849501Z .................................................................................................... 6000/8989
2019-09-04T19:32:36.0849501Z .................................................................................................... 6000/8989
2019-09-04T19:32:43.1580621Z ..................................................................i..ii............................. 6100/8989
2019-09-04T19:33:14.2629538Z .................................................................................................... 6300/8989
2019-09-04T19:33:16.5900997Z .....................i.............................................................................. 6400/8989
2019-09-04T19:33:19.0196456Z .............................................................................................i...... 6500/8989
2019-09-04T19:33:21.9770864Z .................................................................................................... 6600/8989
---
2019-09-04T19:38:28.3320426Z  finished in 22.953
2019-09-04T19:38:28.3534734Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:38:28.5566184Z 
2019-09-04T19:38:28.5567265Z running 149 tests
2019-09-04T19:38:32.2553273Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-09-04T19:38:34.3595113Z ..iiii..............i.........iii.i......ii......
2019-09-04T19:38:34.3596841Z 
2019-09-04T19:38:34.3601568Z  finished in 6.006
2019-09-04T19:38:34.3810064Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:38:34.5551843Z 
---
2019-09-04T19:38:36.8256252Z  finished in 2.444
2019-09-04T19:38:36.8485313Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:38:37.0204505Z 
2019-09-04T19:38:37.0205692Z running 9 tests
2019-09-04T19:38:37.0207082Z iiiiiiiii
2019-09-04T19:38:37.0208338Z 
2019-09-04T19:38:37.0208961Z  finished in 0.172
2019-09-04T19:38:37.0437511Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:38:37.2369824Z 
---
2019-09-04T19:38:57.3761010Z  finished in 20.332
2019-09-04T19:38:57.4033349Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:38:57.6104003Z 
2019-09-04T19:38:57.6104302Z running 123 tests
2019-09-04T19:39:24.4058109Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-04T19:39:29.6585979Z i.i.i......iii.i.....ii
2019-09-04T19:39:29.6586597Z 
2019-09-04T19:39:29.6592104Z  finished in 32.256
2019-09-04T19:39:29.6604044Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-04T19:39:29.6604585Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-04T19:40:36.2198553Z 
2019-09-04T19:40:36.2198778Z ------------------------------------------
2019-09-04T19:40:36.2198827Z stderr:
2019-09-04T19:40:36.2199067Z ------------------------------------------
2019-09-04T19:40:36.2199412Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
2019-09-04T19:40:36.2199534Z 
2019-09-04T19:40:36.2200044Z ------------------------------------------
2019-09-04T19:40:36.2200108Z 
2019-09-04T19:40:36.2200133Z 
---
2019-09-04T19:40:36.2201293Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-04T19:40:36.2201393Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-04T19:40:36.2201428Z 
2019-09-04T19:40:36.2201560Z 
2019-09-04T19:40:36.2203474Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-04T19:40:36.2204684Z 
2019-09-04T19:40:36.2206486Z 
2019-09-04T19:40:36.2207505Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-04T19:40:36.2207568Z Build completed unsuccessfully in 1:13:05
2019-09-04T19:40:36.2207568Z Build completed unsuccessfully in 1:13:05
2019-09-04T19:40:36.2267591Z == clock drift check ==
2019-09-04T19:40:36.2282431Z   local time: Wed Sep  4 19:40:36 UTC 2019
2019-09-04T19:40:36.3665886Z   network time: Wed, 04 Sep 2019 19:40:36 GMT
2019-09-04T19:40:36.3668969Z == end clock drift check ==
2019-09-04T19:40:36.9891643Z ##[error]Bash exited with code '1'.
2019-09-04T19:40:36.9930307Z ##[section]Starting: Checkout
2019-09-04T19:40:36.9932331Z ==============================================================================
2019-09-04T19:40:36.9932511Z Task         : Get sources
2019-09-04T19:40:36.9932554Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2019-09-04T23:53:14Z

I don't think the dependencies necessarily need to be moved, only if they happen to already be in librustc they should be loaded there, otherwise it's fine for the codegen backend to depend on them.

Mark-Simulacrum · 2019-09-05T00:06:27Z

That's true, certainly, but this in theory nets us slightly faster compile times since the pipe is wider/deeper in librustc compilation and hopefully stops this from re-arising in the future when someone goes and adds tempfile to librustc itself.

But I can move the non-used ones in librustc back.

alexcrichton · 2019-09-05T14:15:43Z

Yeah let's just keep the non rustc ones in llvm, these all have inconsequential compile times

Mark-Simulacrum · 2019-09-05T15:04:20Z

Turns out there were no non-rustc ones afaict, so removed all of them. We've seen the create-dir-all failure twice in the PR builder on this PR but there's no way this PR is responsible that I can think of so I'm going to chalk it up to spurious failures. However, also going to not roll this up.

@bors r=petrochenkov rollup=never

bors · 2019-09-05T15:04:21Z

📌 Commit e39f5666317d217b2ec7815a03536f239367c370 has been approved by petrochenkov

rust-highfive · 2019-09-05T16:11:12Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-05T15:00:07.1717447Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-05T15:00:07.1915021Z ##[command]git config gc.auto 0
2019-09-05T15:00:07.1991979Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-05T15:00:07.2061970Z ##[command]git config --get-all http.proxy
2019-09-05T15:00:07.2211726Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-05T15:58:44.9939013Z .................................................................................................... 1500/8994
2019-09-05T15:58:50.1109783Z .................................................................................................... 1600/8994
2019-09-05T15:59:01.6609401Z ..................................................i...............i................................. 1700/8994
2019-09-05T15:59:09.2645881Z .................................................................................................... 1800/8994
2019-09-05T15:59:22.1419031Z .........................................iiiii...................................................... 1900/8994
2019-09-05T15:59:31.8625770Z .................................................................................................... 2100/8994
2019-09-05T15:59:34.1320090Z .................................................................................................... 2200/8994
2019-09-05T15:59:37.6850850Z .................................................................................................... 2300/8994
2019-09-05T15:59:44.6040152Z .................................................................................................... 2400/8994
---
2019-09-05T16:02:32.8052571Z ............................i...............i....................................................... 4700/8994
2019-09-05T16:02:44.1446222Z .................................................................................................... 4800/8994
2019-09-05T16:02:49.7695354Z .................................................................................................... 4900/8994
2019-09-05T16:02:59.9225505Z .................................................................................................... 5000/8994
2019-09-05T16:03:05.2007843Z .........ii.ii...................................................................................... 5100/8994
2019-09-05T16:03:17.3167141Z .................................................................................................... 5300/8994
2019-09-05T16:03:25.1678001Z ........................................................................i........................... 5400/8994
2019-09-05T16:03:31.9688319Z .................................................................................................... 5500/8994
2019-09-05T16:03:38.0028609Z .................................................................................................... 5600/8994
2019-09-05T16:03:38.0028609Z .................................................................................................... 5600/8994
2019-09-05T16:03:47.8001480Z ..................................................................ii...i..ii...........i............ 5700/8994
2019-09-05T16:04:10.9782639Z .................................................................................................... 5900/8994
2019-09-05T16:04:20.1591741Z .................................................................................................... 6000/8994
2019-09-05T16:04:20.1591741Z .................................................................................................... 6000/8994
2019-09-05T16:04:26.2401471Z ....................................................................i..ii........................... 6100/8994
2019-09-05T16:04:52.5760531Z .................................................................................................... 6300/8994
2019-09-05T16:04:54.4201401Z .......................i............................................................................ 6400/8994
2019-09-05T16:04:56.3769239Z ...............................................................................................i.... 6500/8994
2019-09-05T16:04:58.7040828Z .................................................................................................... 6600/8994
---
2019-09-05T16:09:18.9071743Z  finished in 17.960
2019-09-05T16:09:18.9247202Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:09:19.1170493Z 
2019-09-05T16:09:19.1170747Z running 149 tests
2019-09-05T16:09:22.1262663Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-09-05T16:09:23.9693452Z ..iiii..............i.........iii.i......ii......
2019-09-05T16:09:23.9695122Z 
2019-09-05T16:09:23.9699675Z  finished in 5.045
2019-09-05T16:09:23.9858528Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:09:24.1427888Z 
---
2019-09-05T16:09:26.0849238Z  finished in 2.099
2019-09-05T16:09:26.1025454Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:09:26.2464534Z 
2019-09-05T16:09:26.2465909Z running 9 tests
2019-09-05T16:09:26.2467748Z iiiiiiiii
2019-09-05T16:09:26.2469415Z 
2019-09-05T16:09:26.2469654Z  finished in 0.144
2019-09-05T16:09:26.2636204Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:09:26.4296373Z 
---
2019-09-05T16:09:42.8192067Z  finished in 16.555
2019-09-05T16:09:42.8383396Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:09:42.9960786Z 
2019-09-05T16:09:42.9961484Z running 123 tests
2019-09-05T16:10:04.6240993Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-05T16:10:09.1145779Z i.i.i......iii.i.....ii
2019-09-05T16:10:09.1149533Z 
2019-09-05T16:10:09.1149838Z  finished in 26.276
2019-09-05T16:10:09.1158164Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T16:10:09.1158737Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-05T16:11:05.2253620Z 
2019-09-05T16:11:05.2253848Z ------------------------------------------
2019-09-05T16:11:05.2253914Z stderr:
2019-09-05T16:11:05.2254141Z ------------------------------------------
2019-09-05T16:11:05.2254502Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
2019-09-05T16:11:05.2254865Z 
2019-09-05T16:11:05.2255057Z ------------------------------------------
2019-09-05T16:11:05.2255098Z 
2019-09-05T16:11:05.2255118Z 
---
2019-09-05T16:11:05.2255820Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-05T16:11:05.2255881Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-05T16:11:05.2255906Z 
2019-09-05T16:11:05.2255925Z 
2019-09-05T16:11:05.2262476Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-05T16:11:05.2263400Z 
2019-09-05T16:11:05.2263496Z 
2019-09-05T16:11:05.2273197Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-05T16:11:05.2325810Z Build completed unsuccessfully in 1:03:54
2019-09-05T16:11:05.2325810Z Build completed unsuccessfully in 1:03:54
2019-09-05T16:11:05.2325891Z == clock drift check ==
2019-09-05T16:11:05.2340777Z   local time: Thu Sep  5 16:11:05 UTC 2019
2019-09-05T16:11:05.3888173Z   network time: Thu, 05 Sep 2019 16:11:05 GMT
2019-09-05T16:11:05.3888928Z == end clock drift check ==
2019-09-05T16:11:06.2396033Z ##[error]Bash exited with code '1'.
2019-09-05T16:11:06.2468082Z ##[section]Starting: Checkout
2019-09-05T16:11:06.2469890Z ==============================================================================
2019-09-05T16:11:06.2469936Z Task         : Get sources
2019-09-05T16:11:06.2469974Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-09-05T16:27:44Z

☔ The latest upstream changes (presumably #64172) made this pull request unmergeable. Please resolve the merge conflicts.

The global restriction is 100, but since error codes are printed out via --explain we want to restrict them to just 80 columns.

Not doing this leads to building two copies of e.g. num_cpus in the sysroot and _llvm deps, leading to conflicts between the two when compiling librustc_codegen_llvm. It's not entirely clear why this is the case after the changes in this PR but likely has something to do with a subtle difference in ordering or similar.

Mark-Simulacrum · 2019-09-05T17:17:15Z

@bors r=petrochenkov

I was able to reproduce the UI test failure locally in the docker container once, but not more than that (have tried ~15 times since then, though admittedly without deleting cache), so I assume it's spurious.

bors · 2019-09-05T17:17:16Z

📌 Commit 41b39fc has been approved by petrochenkov

rust-highfive · 2019-09-05T18:45:39Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-05T17:27:44.7996359Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-05T17:27:44.8208208Z ##[command]git config gc.auto 0
2019-09-05T17:27:44.8282609Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-05T17:27:44.8349687Z ##[command]git config --get-all http.proxy
2019-09-05T17:27:45.5859694Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64139/merge:refs/remotes/pull/64139/merge
---
2019-09-05T18:31:48.9406766Z .................................................................................................... 1500/8999
2019-09-05T18:31:54.7519523Z .................................................................................................... 1600/8999
2019-09-05T18:32:07.8256115Z ......................................................i...............i............................. 1700/8999
2019-09-05T18:32:15.8458089Z .................................................................................................... 1800/8999
2019-09-05T18:32:30.5153285Z .............................................iiiii.................................................. 1900/8999
2019-09-05T18:32:41.3372457Z .................................................................................................... 2100/8999
2019-09-05T18:32:43.8476391Z .................................................................................................... 2200/8999
2019-09-05T18:32:47.3417081Z .................................................................................................... 2300/8999
2019-09-05T18:32:55.1948214Z .................................................................................................... 2400/8999
---
2019-09-05T18:36:02.5628314Z ................................i...............i................................................... 4700/8999
2019-09-05T18:36:14.6653296Z .................................................................................................... 4800/8999
2019-09-05T18:36:21.0518648Z .................................................................................................... 4900/8999
2019-09-05T18:36:32.1107428Z .................................................................................................... 5000/8999
2019-09-05T18:36:38.1402290Z ..............ii.ii................................................................................. 5100/8999
2019-09-05T18:36:49.3664936Z .................................................................................................... 5300/8999
2019-09-05T18:36:59.8690853Z .............................................................................i...................... 5400/8999
2019-09-05T18:37:08.1659625Z .................................................................................................... 5500/8999
2019-09-05T18:37:14.7460661Z .................................................................................................... 5600/8999
2019-09-05T18:37:14.7460661Z .................................................................................................... 5600/8999
2019-09-05T18:37:26.0909982Z .......................................................................ii...i..ii...........i....... 5700/8999
2019-09-05T18:37:52.9411978Z .................................................................................................... 5900/8999
2019-09-05T18:38:03.3381479Z .................................................................................................... 6000/8999
2019-09-05T18:38:03.3381479Z .................................................................................................... 6000/8999
2019-09-05T18:38:11.8516063Z .........................................................................i..ii...................... 6100/8999
2019-09-05T18:38:42.0598312Z .................................................................................................... 6300/8999
2019-09-05T18:38:44.3116997Z ............................i....................................................................... 6400/8999
2019-09-05T18:38:46.5248549Z .................................................................................................... 6500/8999
2019-09-05T18:38:49.2962185Z i................................................................................................... 6600/8999
---
2019-09-05T18:43:37.0352426Z  finished in 19.149
2019-09-05T18:43:37.0543883Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:43:37.2178991Z 
2019-09-05T18:43:37.2179102Z running 149 tests
2019-09-05T18:43:40.4062039Z i....iii......iii..iiii....i.............................i..i..................i....i.........ii.i.i 100/149
2019-09-05T18:43:42.3802942Z ..iiii..............i.........iii.i......ii......
2019-09-05T18:43:42.3805569Z 
2019-09-05T18:43:42.3806416Z  finished in 5.326
2019-09-05T18:43:42.3992182Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:43:42.5658760Z 
---
2019-09-05T18:43:44.7080181Z  finished in 2.308
2019-09-05T18:43:44.7274256Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:43:44.8921239Z 
2019-09-05T18:43:44.8921633Z running 9 tests
2019-09-05T18:43:44.8922999Z iiiiiiiii
2019-09-05T18:43:44.8923591Z 
2019-09-05T18:43:44.8923654Z  finished in 0.164
2019-09-05T18:43:44.9111654Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:43:45.0736628Z 
---
2019-09-05T18:44:03.1141982Z  finished in 18.203
2019-09-05T18:44:03.1421908Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:44:03.3024264Z 
2019-09-05T18:44:03.3024570Z running 123 tests
2019-09-05T18:44:26.5278959Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123
2019-09-05T18:44:31.0927889Z i.i.i......iii.i.....ii
2019-09-05T18:44:31.0929922Z 
2019-09-05T18:44:31.0930249Z  finished in 27.951
2019-09-05T18:44:31.0940741Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-09-05T18:44:31.0941740Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-09-05T18:45:34.2232094Z 
2019-09-05T18:45:34.2232583Z ------------------------------------------
2019-09-05T18:45:34.2232905Z stderr:
2019-09-05T18:45:34.2233363Z ------------------------------------------
2019-09-05T18:45:34.2233992Z thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1165:5
2019-09-05T18:45:34.2234589Z 
2019-09-05T18:45:34.2235254Z ------------------------------------------
2019-09-05T18:45:34.2235571Z 
2019-09-05T18:45:34.2235784Z 
---
2019-09-05T18:45:34.2242579Z test result: FAILED. 68 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2019-09-05T18:45:34.2242976Z 
2019-09-05T18:45:34.2243208Z 
2019-09-05T18:45:34.2243406Z 
2019-09-05T18:45:34.2245248Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-05T18:45:34.2245970Z 
2019-09-05T18:45:34.2246211Z 
2019-09-05T18:45:34.2246461Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-05T18:45:34.2246700Z Build completed unsuccessfully in 1:10:34
2019-09-05T18:45:34.2246700Z Build completed unsuccessfully in 1:10:34
2019-09-05T18:45:34.2250494Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-05T18:45:34.2250957Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-05T18:45:34.2293372Z == clock drift check ==
2019-09-05T18:45:34.2308842Z   local time: Thu Sep  5 18:45:34 UTC 2019
2019-09-05T18:45:34.3870548Z   network time: Thu, 05 Sep 2019 18:45:34 GMT
2019-09-05T18:45:34.3875113Z == end clock drift check ==
2019-09-05T18:45:35.0717768Z ##[error]Bash exited with code '1'.
2019-09-05T18:45:35.0757845Z ##[section]Starting: Checkout
2019-09-05T18:45:35.0760784Z ==============================================================================
2019-09-05T18:45:35.0760850Z Task         : Get sources
2019-09-05T18:45:35.0761124Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2019-09-05T20:32:39Z

I'm leaning towards deleting this test. There's no way that code in this PR could be responsible for this failure I think, unless I'm missing something?

@alexcrichton What do you think about that? Is it worth trying to get a more concrete reason for the failure?

alexcrichton · 2019-09-05T21:40:41Z

It seems to be happening pretty consistently here so I would say it's probably related to this. IIRC something about error indexes used build/tmp to do something at some point, and this looks like the test has always been buggy in that it assumes the tmpdir exists but it may not (nothing seems to create it when testing). The best fix is to probably actually create the tmpdir where it's set for compiletest to later read.

Mark-Simulacrum · 2019-09-05T21:44:33Z

Hm. I guess that makes sense then why I stopped being able to reproduce after the first attempt (something created the temp dir). I'll go ahead and add a create_dir_all on the current directory too.

Mark-Simulacrum · 2019-09-07T16:48:26Z

@bors r=petrochenkov

bors · 2019-09-07T16:48:27Z

📌 Commit 5153db1 has been approved by petrochenkov

…acro, r=petrochenkov Migrate internal diagnostic registration to macro_rules Review is best done commit-by-commit. Fixes rust-lang#64132.

@ghost

Rollup of 7 pull requests Successful merges: - #64023 (libstd fuchsia fixes) - #64098 (Ensure edition lints and internal lints are enabled with deny-warnings=false) - #64139 (Migrate internal diagnostic registration to macro_rules) - #64226 (Aggregation of cosmetic changes made during work on REPL PRs: libsyntax) - #64227 (Aggregation of cosmetic changes made during work on REPL PRs: librustc) - #64235 (Upgrade env_logger to 0.6) - #64258 (compiletest: Match suffixed environments) Failed merges: r? @ghost

rust-highfive assigned petrochenkov Sep 4, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

View reviewed changes

matklad reviewed Sep 4, 2019

View reviewed changes

src/libsyntax/diagnostics/macros.rs Show resolved Hide resolved

Mark-Simulacrum commented Sep 4, 2019

View reviewed changes

Mark-Simulacrum force-pushed the strip-legacy-proc-macro branch from 0556499 to 87dbf92 Compare September 4, 2019 13:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2019

Mark-Simulacrum force-pushed the strip-legacy-proc-macro branch from 87dbf92 to eff353e Compare September 4, 2019 17:22

rust-highfive assigned alexcrichton and unassigned petrochenkov Sep 4, 2019

Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2019

Mark-Simulacrum force-pushed the strip-legacy-proc-macro branch from eff353e to d63433d Compare September 4, 2019 18:19

Mark-Simulacrum force-pushed the strip-legacy-proc-macro branch from d63433d to e39f566 Compare September 5, 2019 14:59

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2019

Mark-Simulacrum added 5 commits September 5, 2019 12:34

Restrict error code length to 80 columns

74563b4

The global restriction is 100, but since error codes are printed out via --explain we want to restrict them to just 80 columns.

Replace diagnostic plugins with macro_rules

b437240

Fix error index generator for new register_diagnostics API

4de4f30

Remove rustc_diagnostic_macros feature

41b39fc

Mark-Simulacrum force-pushed the strip-legacy-proc-macro branch from e39f566 to 41b39fc Compare September 5, 2019 17:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2019

Explicitly create test tempdir

5153db1

Centril mentioned this pull request Sep 7, 2019

Rollup of 7 pull requests #64264

Merged

bors merged commit 5153db1 into rust-lang:master Sep 7, 2019

Xanewok mentioned this pull request Sep 8, 2019

Bump RLS and Rustfmt submodules to use rustc-ap-* v583 #64279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate internal diagnostic registration to macro_rules #64139

Migrate internal diagnostic registration to macro_rules #64139

Mark-Simulacrum commented Sep 4, 2019 •

edited

Loading

rust-highfive commented Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

alexcrichton Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

alexcrichton Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

rust-highfive commented Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

rust-highfive commented Sep 4, 2019

petrochenkov commented Sep 4, 2019

bors commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

rust-highfive commented Sep 4, 2019

rust-highfive commented Sep 4, 2019

alexcrichton commented Sep 4, 2019

Mark-Simulacrum commented Sep 5, 2019

alexcrichton commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

bors commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

bors commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

bors commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

alexcrichton commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

Mark-Simulacrum commented Sep 7, 2019

bors commented Sep 7, 2019

Migrate internal diagnostic registration to macro_rules #64139

Migrate internal diagnostic registration to macro_rules #64139

Conversation

Mark-Simulacrum commented Sep 4, 2019 • edited Loading

rust-highfive commented Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

Choose a reason for hiding this comment

alexcrichton Sep 4, 2019

Choose a reason for hiding this comment

Mark-Simulacrum Sep 4, 2019

Choose a reason for hiding this comment

alexcrichton Sep 4, 2019

Choose a reason for hiding this comment

Mark-Simulacrum Sep 4, 2019

Choose a reason for hiding this comment

rust-highfive commented Sep 4, 2019

Mark-Simulacrum Sep 4, 2019

Choose a reason for hiding this comment

rust-highfive commented Sep 4, 2019

petrochenkov commented Sep 4, 2019

bors commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

Mark-Simulacrum commented Sep 4, 2019

rust-highfive commented Sep 4, 2019

rust-highfive commented Sep 4, 2019

alexcrichton commented Sep 4, 2019

Mark-Simulacrum commented Sep 5, 2019

alexcrichton commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

bors commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

bors commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

bors commented Sep 5, 2019

rust-highfive commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

alexcrichton commented Sep 5, 2019

Mark-Simulacrum commented Sep 5, 2019

Mark-Simulacrum commented Sep 7, 2019

bors commented Sep 7, 2019

Mark-Simulacrum commented Sep 4, 2019 •

edited

Loading