Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save-analysis: Nest typeck tables when processing functions/methods #64250

Merged
merged 7 commits into from Sep 16, 2019
Merged

save-analysis: Nest typeck tables when processing functions/methods #64250

merged 7 commits into from Sep 16, 2019

Commits on Sep 13, 2019

  1. save-analysis: Nest typeck tables when processing functions/methods 

    Fixes an issue where we did not nest tables correctly when resolving
associated types in formal argument/return type positions
    @Xanewok
    Xanewok committed Sep 13, 2019
    Copy the full SHA
    ab73b32 View commit details
    Browse the repository at this point in the history

  2. Always validate HIR ID for TypeckTables 

    Performance shouldn't be impacted (see [1] for a perf run) and this
should allow us to catch more bugs, e.g. [2] and [3].

[1]: rust-lang#64262
[2]: rust-lang#64250
[3]: rust-lang#57298
    @Xanewok
    Xanewok committed Sep 13, 2019
    Copy the full SHA
    b456c82 View commit details
    Browse the repository at this point in the history

  3. save-analysis: Add a related test case

    @Xanewok
    Xanewok committed Sep 13, 2019
    Copy the full SHA
    6117faa View commit details
    Browse the repository at this point in the history

  4. save-analysis: Use process_bounds when processing opaque impl item type 

    ...since the code is literally the same and does the same thing.
    @Xanewok
    Xanewok committed Sep 13, 2019
    Copy the full SHA
    b4151dd View commit details
    Browse the repository at this point in the history

  5. save-analysis: Visit bounds in opaque types

    @Xanewok
    Xanewok committed Sep 13, 2019
    Copy the full SHA
    0fafd61 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2019

  1. save-analysis: Deduplicate lookup_{d,r}ef_id functions

    @Xanewok
    Xanewok committed Sep 14, 2019
    Copy the full SHA
    30e39e8 View commit details
    Browse the repository at this point in the history

  2. save-analysis: Process bounds in impl trait only in argument position

    @Xanewok
    Xanewok committed Sep 14, 2019
    Copy the full SHA
    a946b8d View commit details
    Browse the repository at this point in the history